From 080d37e405f16c2e99980e453c444d0b1925ab53 Mon Sep 17 00:00:00 2001 From: Colin Delahunty <72827203+colin99d@users.noreply.github.com> Date: Wed, 12 Apr 2023 08:01:15 -0700 Subject: [PATCH] Removed source from exp (#4749) * Removed source from exp * Removed source from other commands not using it * Added error handling --- .../miscellaneous/sources/openbb_default.json | 27 ------------------- .../stocks/options/options_controller.py | 3 +-- .../test_print_help.txt | 10 +++---- 3 files changed, 6 insertions(+), 34 deletions(-) diff --git a/openbb_terminal/miscellaneous/sources/openbb_default.json b/openbb_terminal/miscellaneous/sources/openbb_default.json index 2eb50be85cd..170fc01c41f 100644 --- a/openbb_terminal/miscellaneous/sources/openbb_default.json +++ b/openbb_terminal/miscellaneous/sources/openbb_default.json @@ -66,39 +66,12 @@ "Nasdaq", "Intrinio" ], - "exp": [ - "YahooFinance", - "Tradier", - "Nasdaq", - "Intrinio" - ], "pcr": [ "AlphaQuery" ], "info": [ "Barchart" ], - "chains": [ - "YahooFinance", - "Tradier", - "Nasdaq", - "Intrinio" - ], - "oi": [ - "YahooFinance", - "Tradier", - "Nasdaq" - ], - "vol": [ - "YahooFinance", - "Tradier", - "Nasdaq" - ], - "voi": [ - "YahooFinance", - "Tradier", - "Nasdaq" - ], "hist": [ "ChartExchange", "Tradier", diff --git a/openbb_terminal/stocks/options/options_controller.py b/openbb_terminal/stocks/options/options_controller.py index c68c183542a..a6ac8d6e8cd 100644 --- a/openbb_terminal/stocks/options/options_controller.py +++ b/openbb_terminal/stocks/options/options_controller.py @@ -153,7 +153,7 @@ class OptionsController(BaseController): else: self.expiry_dates = [] - self.default_chain = get_ordered_list_sources(f"{self.PATH}chains")[0] + self.default_chain = get_ordered_list_sources(f"{self.PATH}load")[0] if session and get_current_user().preferences.USE_PROMPT_TOOLKIT: choices: dict = self.choices_default @@ -726,7 +726,6 @@ class OptionsController(BaseController): self.selected_date = expiry_date if self.selected_date: - self.source = ns_parser.source self.chain = self.full_chain[ self.full_chain["expiration"] == self.selected_date ] diff --git a/tests/openbb_terminal/stocks/options/txt/test_options_controller/test_print_help.txt b/tests/openbb_terminal/stocks/options/txt/test_options_controller/test_print_help.txt index dc924dcbb06..d4f05028cac 100644 --- a/tests/openbb_terminal/stocks/options/txt/test_options_controller/test_print_help.txt +++ b/tests/openbb_terminal/stocks/options/txt/test_options_controller/test_print_help.txt @@ -4,17 +4,17 @@ > screen screens tickers based on preset load load new ticker [YahooFinance, Tradier, Nasdaq, Intrinio] -[unvl] exp see and set expiration dates[/unvl] [YahooFinance, Tradier, Nasdaq, Intrinio] +[unvl] exp see and set expiration dates[/unvl] Ticker: Expiry: [unvl] pcr display put call ratio for ticker[/unvl] [AlphaQuery] [unvl] info display option information (volatility, IV rank etc)[/unvl] [Barchart] -[unvl] chains display option chains with greeks[/unvl] [YahooFinance, Tradier, Nasdaq, Intrinio] -[unvl] oi plot open interest[/unvl] [YahooFinance, Tradier, Nasdaq] -[unvl] vol plot volume[/unvl] [YahooFinance, Tradier, Nasdaq] -[unvl] voi plot volume and open interest[/unvl] [YahooFinance, Tradier, Nasdaq] +[unvl] chains display option chains with greeks[/unvl] +[unvl] oi plot open interest[/unvl] +[unvl] vol plot volume[/unvl] +[unvl] voi plot volume and open interest[/unvl] [unvl] hist plot option history[/unvl] [ChartExchange, Tradier, Intrinio] [unvl] vsurf show 3D volatility surface[/unvl] [YahooFinance] [unvl] grhist plot option greek history[/unvl] [Syncretism, Intrinio]