From 0e2f0b4bfa85875e7e1c6b84f376bbba1c95539e Mon Sep 17 00:00:00 2001 From: Diogo Sousa Date: Fri, 21 Jul 2023 14:59:52 +0100 Subject: [PATCH] rename fetcher var --- .../sdk/core/openbb_core/app/static/package/root.py | 1 - openbb_sdk/sdk/provider/openbb_provider/registry.py | 13 +++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/openbb_sdk/sdk/core/openbb_core/app/static/package/root.py b/openbb_sdk/sdk/core/openbb_core/app/static/package/root.py index f224aa2ce7b..361e3096a12 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/static/package/root.py +++ b/openbb_sdk/sdk/core/openbb_core/app/static/package/root.py @@ -1,7 +1,6 @@ ### THIS FILE IS AUTO-GENERATED. DO NOT EDIT. ### - from openbb_core.app.static.container import Container diff --git a/openbb_sdk/sdk/provider/openbb_provider/registry.py b/openbb_sdk/sdk/provider/openbb_provider/registry.py index 7446b3086b1..4d8bd2a6b49 100644 --- a/openbb_sdk/sdk/provider/openbb_provider/registry.py +++ b/openbb_sdk/sdk/provider/openbb_provider/registry.py @@ -6,6 +6,7 @@ from typing import Any, Dict, Optional import pkg_resources from openbb_provider.abstract.data import QueryParams +from openbb_provider.abstract.fetcher import Fetcher from openbb_provider.abstract.provider import Provider, ProviderNameType @@ -35,7 +36,7 @@ class ProviderRegistry: return provider - def get_credentials( + def filter_credentials( self, provider_name: ProviderNameType, credentials: Optional[Dict[str, str]] = None, @@ -58,7 +59,7 @@ class ProviderRegistry: return result - def get_fetcher(self, provider: Provider, query_params: QueryParams) -> Any: + def get_fetcher(self, provider: Provider, query_params: QueryParams) -> Fetcher: """Get a fetcher from the provider.""" fetch_dict = provider.fetcher_dict[ "get_query_type" @@ -80,13 +81,13 @@ class ProviderRegistry: ): """Fetch data from a provider by using the OpenBB standard.""" provider = self.get_provider(provider_name) - loaded_credentials = self.get_credentials(provider_name, credentials) - fetcher = self.get_fetcher(provider, query_params) + filtered_credentials = self.filter_credentials(provider_name, credentials) + Fetcher_ = self.get_fetcher(provider, query_params) try: # TODO: Check if we really need to pass this "fetch_data" - return getattr(fetcher, "fetch_data")( - query_params, extra_params, loaded_credentials + return getattr(Fetcher_, "fetch_data")( + query_params, extra_params, filtered_credentials ) except Exception as e: raise ProviderError(e) from e