From 1165e57b40fd8481d23bdd810eea8f49f148ecca Mon Sep 17 00:00:00 2001 From: montezdesousa Date: Fri, 4 Aug 2023 10:56:20 +0100 Subject: [PATCH] make some provider args optional --- openbb_sdk/openbb/__init__.py | 2 +- .../app/static/package/__extensions__.py | 1 - .../core/openbb_core/app/static/package_builder.py | 4 ++-- .../provider/openbb_provider/abstract/fetcher.py | 4 +--- .../provider/openbb_provider/abstract/provider.py | 14 +++++++------- 5 files changed, 11 insertions(+), 14 deletions(-) diff --git a/openbb_sdk/openbb/__init__.py b/openbb_sdk/openbb/__init__.py index fcb01a25b33..0ea5db54139 100644 --- a/openbb_sdk/openbb/__init__.py +++ b/openbb_sdk/openbb/__init__.py @@ -12,4 +12,4 @@ def _rebuild_python_interface(*args, lint=True) -> None: PackageBuilder, ) - PackageBuilder.build(modules=list(args), lint = lint) + PackageBuilder.build(modules=list(args), lint=lint) diff --git a/openbb_sdk/sdk/core/openbb_core/app/static/package/__extensions__.py b/openbb_sdk/sdk/core/openbb_core/app/static/package/__extensions__.py index 4a2a8103640..fc3fea757a4 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/static/package/__extensions__.py +++ b/openbb_sdk/sdk/core/openbb_core/app/static/package/__extensions__.py @@ -1,7 +1,6 @@ ### THIS FILE IS AUTO-GENERATED. DO NOT EDIT. ### - from openbb_core.app.static.container import Container diff --git a/openbb_sdk/sdk/core/openbb_core/app/static/package_builder.py b/openbb_sdk/sdk/core/openbb_core/app/static/package_builder.py index f557763e7ed..fe7d66ac45e 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/static/package_builder.py +++ b/openbb_sdk/sdk/core/openbb_core/app/static/package_builder.py @@ -31,7 +31,7 @@ class PackageBuilder: """Build the extension package for the SDK.""" @classmethod - def build(cls, modules:Optional[List[str]]=None, lint: bool = True) -> None: + def build(cls, modules: Optional[List[str]] = None, lint: bool = True) -> None: """Build the extensions for the SDK.""" print("\nBuilding extensions package...\n") cls.save_module_map() @@ -56,7 +56,7 @@ class PackageBuilder: ) @classmethod - def save_modules(cls, modules:Optional[List[str]] = None): + def save_modules(cls, modules: Optional[List[str]] = None): """Save the modules.""" print("\nWriting modules...") route_map = PathHandler.build_route_map() diff --git a/openbb_sdk/sdk/provider/openbb_provider/abstract/fetcher.py b/openbb_sdk/sdk/provider/openbb_provider/abstract/fetcher.py index 78a1a29dd27..e7c98b708fc 100644 --- a/openbb_sdk/sdk/provider/openbb_provider/abstract/fetcher.py +++ b/openbb_sdk/sdk/provider/openbb_provider/abstract/fetcher.py @@ -50,9 +50,7 @@ class Fetcher( ) -> GenericDataType: """Fetch data from a provider.""" query = cls.transform_query(params=params) - data = cls.extract_data( - query=query, credentials=credentials, **kwargs - ) + data = cls.extract_data(query=query, credentials=credentials, **kwargs) results = cls.transform_data(data=data) return results diff --git a/openbb_sdk/sdk/provider/openbb_provider/abstract/provider.py b/openbb_sdk/sdk/provider/openbb_provider/abstract/provider.py index fd3f11b6e07..bb3f5d00b99 100644 --- a/openbb_sdk/sdk/provider/openbb_provider/abstract/provider.py +++ b/openbb_sdk/sdk/provider/openbb_provider/abstract/provider.py @@ -13,9 +13,9 @@ class Provider: self, name: str, description: str, - website: str, - fetcher_dict: Dict[str, Type[Fetcher]], + website: Optional[str] = None, required_credentials: Optional[List[str]] = None, + fetcher_dict: Optional[Dict[str, Type[Fetcher]]] = None, ) -> None: """Initialize the provider. @@ -25,17 +25,17 @@ class Provider: Name of the provider. description : str Description of the provider. - website : str - Website of the provider. - fetcher_dict : Dict[str, Type[Fetcher]] - Dictionary of fetchers. + website : Optional[str] + Website of the provider, by default None. required_credentials : Optional[List[str]], optional List of required credentials, by default None + fetcher_dict : Optional[Dict[str, Type[Fetcher]]] + Dictionary of fetchers, by default None. """ self.name = name self.description = description self.website = website - self.fetcher_dict = fetcher_dict + self.fetcher_dict = fetcher_dict or {} if required_credentials is None: self.required_credentials: List = [] else: