From 162a611973c3dced7edd2e69c8e4b97adb5d75ae Mon Sep 17 00:00:00 2001 From: didier Date: Sun, 2 May 2021 22:17:03 +0100 Subject: [PATCH] fix finnhub naming --- gamestonk_terminal/README.md | 4 ++-- gamestonk_terminal/technical_analysis/README.md | 2 +- .../technical_analysis/{finhub_view.py => finnhub_view.py} | 0 gamestonk_terminal/technical_analysis/ta_controller.py | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) rename gamestonk_terminal/technical_analysis/{finhub_view.py => finnhub_view.py} (100%) diff --git a/gamestonk_terminal/README.md b/gamestonk_terminal/README.md index f1c79fdbaef..e314b341ba2 100644 --- a/gamestonk_terminal/README.md +++ b/gamestonk_terminal/README.md @@ -183,7 +183,7 @@ Command | Description | Sources `view` | view historical data and trendlines| [Finviz](https://finviz.com/quote.ashx?t=tsla) `summary` | technical summary report| [FinBrain](https://finbrain.tech) `recom` | recommendation based on Technical Indicators| [Tradingview](https://uk.tradingview.com/widget/technical-analysis/) -`pr` | pattern recognition| [Finhub](https://finnhub.io) +`pr` | pattern recognition| [Finnhub](https://finnhub.io) [overlap](https://github.com/twopirllc/pandas-ta/tree/master/pandas_ta/overlap) | `ema` | exponential moving average | [Wikipedia](https://en.wikipedia.org/wiki/Moving_average#Exponential_moving_average), [Investopedia](https://www.investopedia.com/terms/e/ema.asp) `sma` |simple moving average | [Wikipedia](https://en.wikipedia.org/wiki/Moving_average#Simple_moving_average_(boxcar_filter)), [Investopedia](https://www.investopedia.com/terms/s/sma.asp) @@ -398,7 +398,7 @@ positionbook |display the positionbook if Oanda provides one for the forex instr Command|Description ------ | -------- `ema` | buy when price exceeds EMA(l) -`ema_cross` | buy when EMA(short) > EMA(long) +`ema_cross` | buy when EMA(short) > EMA(long) `rsi` | buy when RSI < low and sell when RSI > high diff --git a/gamestonk_terminal/technical_analysis/README.md b/gamestonk_terminal/technical_analysis/README.md index 8ee5d86bf73..aa5ca8a0fe6 100644 --- a/gamestonk_terminal/technical_analysis/README.md +++ b/gamestonk_terminal/technical_analysis/README.md @@ -9,7 +9,7 @@ This menu aims to perform a technical analysis on a pre-loaded ticker chart, and * [recom](#recom) - recommendation based on Technical Indicators [Tradingview API] * [pr](#pr) - - pattern recognition [Finhub] + - pattern recognition [Finnhub] [OVERLAP](#OVERLAP) * [ema](#ema) diff --git a/gamestonk_terminal/technical_analysis/finhub_view.py b/gamestonk_terminal/technical_analysis/finnhub_view.py similarity index 100% rename from gamestonk_terminal/technical_analysis/finhub_view.py rename to gamestonk_terminal/technical_analysis/finnhub_view.py diff --git a/gamestonk_terminal/technical_analysis/ta_controller.py b/gamestonk_terminal/technical_analysis/ta_controller.py index 685d4b104fa..2d48fced7d9 100644 --- a/gamestonk_terminal/technical_analysis/ta_controller.py +++ b/gamestonk_terminal/technical_analysis/ta_controller.py @@ -20,7 +20,7 @@ from gamestonk_terminal.technical_analysis import volume as ta_volume from gamestonk_terminal.technical_analysis import finbrain_view from gamestonk_terminal.technical_analysis import tradingview_view from gamestonk_terminal.technical_analysis import finviz_view -from gamestonk_terminal.technical_analysis import finhub_view +from gamestonk_terminal.technical_analysis import finnhub_view class TechnicalAnalysisController: @@ -90,7 +90,7 @@ class TechnicalAnalysisController: print( " recom recommendation based on Technical Indicators [Tradingview API]" ) - print(" pr pattern recognition [Finhub]") + print(" pr pattern recognition [Finnhub]") print("") print("overlap:") print(" ema exponential moving average") @@ -163,7 +163,7 @@ class TechnicalAnalysisController: def call_pr(self, other_args: List[str]): """Process pr command""" - finhub_view.pattern_recognition_view(other_args, self.ticker) + finnhub_view.pattern_recognition_view(other_args, self.ticker) # OVERLAP def call_ema(self, other_args: List[str]):