From 1a9a14296333ba2bad7ca32d0e651f16f53a84dc Mon Sep 17 00:00:00 2001 From: Pratyush Shukla Date: Wed, 2 Aug 2023 17:03:08 +0530 Subject: [PATCH] refactored base and types --- .../polygon/openbb_polygon/utils/types.py | 46 ++----------------- .../provider/openbb_provider/models/base.py | 2 +- 2 files changed, 4 insertions(+), 44 deletions(-) diff --git a/openbb_sdk/providers/polygon/openbb_polygon/utils/types.py b/openbb_sdk/providers/polygon/openbb_polygon/utils/types.py index ec4289b8362..f370a3ffba9 100644 --- a/openbb_sdk/providers/polygon/openbb_polygon/utils/types.py +++ b/openbb_sdk/providers/polygon/openbb_polygon/utils/types.py @@ -1,24 +1,11 @@ """Polygon types helpers.""" -from datetime import date, datetime, timedelta -from enum import Enum -from typing import Literal, Optional, Union +from datetime import date +from typing import Literal, Optional -from openbb_provider.abstract.data import Data -from openbb_provider.abstract.query_params import QueryParams from openbb_provider.models.income_statement import IncomeStatementQueryParams -from pydantic import Field, PositiveFloat, PositiveInt, validator - - -class Timespan(str, Enum): - minute = "minute" - hour = "hour" - day = "day" - week = "week" - month = "month" - quarter = "quarter" - year = "year" +from pydantic import Field class PolygonFundamentalQueryParams(IncomeStatementQueryParams): @@ -79,30 +66,3 @@ class PolygonFundamentalQueryParams(IncomeStatementQueryParams): sort: Optional[Literal["filing_date", "period_of_report_date"]] = Field( description="The sort of the financial statement." ) - - -class BaseStockQueryParams(QueryParams): - stocksTicker: str = Field(alias="symbol") - start_date: Union[date, datetime] = Field( - default=datetime.now().date() - timedelta(days=8) - ) - end_date: Union[date, datetime] = Field( - default=datetime.now().date() - timedelta(days=1) - ) - timespan: Timespan = Field(default=Timespan.day) - sort: Literal["asc", "desc"] = Field(default="desc") - limit: PositiveInt = Field(default=49999) - adjusted: bool = Field(default=True) - multiplier: PositiveInt = Field(default=1) - - -class BaseStockData(Data): - c: PositiveFloat = Field(alias="close") - o: PositiveFloat = Field(alias="open") - h: PositiveFloat = Field(alias="high") - l: PositiveFloat = Field(alias="low") # noqa: E741 - t: datetime = Field(alias="date") - - @validator("t", pre=True) - def time_validate(cls, v): # pylint: disable=E0213 - return datetime.fromtimestamp(v / 1000) diff --git a/openbb_sdk/sdk/provider/openbb_provider/models/base.py b/openbb_sdk/sdk/provider/openbb_provider/models/base.py index 862c63fc3c3..45f615beae5 100644 --- a/openbb_sdk/sdk/provider/openbb_provider/models/base.py +++ b/openbb_sdk/sdk/provider/openbb_provider/models/base.py @@ -19,5 +19,5 @@ class FinancialStatementQueryParams(QueryParams, BaseSymbol): default="annually", description=QUERY_DESCRIPTIONS.get("period", "") ) limit: Optional[NonNegativeInt] = Field( - default=1, description="The limit of the income statement." + default=200, description=QUERY_DESCRIPTIONS.get("limit", "") )