From 35e34a12fec0ff4f522d055bc9f25d2f406b0847 Mon Sep 17 00:00:00 2001 From: Theodore Aptekarev Date: Tue, 29 Mar 2022 17:35:02 +0300 Subject: [PATCH] Resolve no-else and inconsistent return --- openbb_terminal/economy/finviz_model.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/openbb_terminal/economy/finviz_model.py b/openbb_terminal/economy/finviz_model.py index 0f4638e68dc..b92fa5d2e01 100644 --- a/openbb_terminal/economy/finviz_model.py +++ b/openbb_terminal/economy/finviz_model.py @@ -35,8 +35,9 @@ def get_valuation_performance_data(group: str, data_type: str) -> pd.DataFrame: try: if data_type == "valuation": return valuation.Valuation().screener_view(group=group) - elif data_type == "performance": + if data_type == "performance": return performance.Performance().screener_view(group=group) + return pd.DataFrame() except IndexError: console.print("Data not found.\n") return pd.DataFrame() @@ -68,7 +69,7 @@ def get_futures() -> dict: ).text slice_source = source[ - source.find("var groups = ") : source.find( + source.find("var groups = ") : source.find( # noqa: E203 "\r\n\r\n groups.forEach(function(group) " ) ] @@ -79,7 +80,7 @@ def get_futures() -> dict: ) titles = literal_eval( slice_source[ - slice_source.find("\r\n var tiles = ") : -1 + slice_source.find("\r\n var tiles = ") : -1 # noqa: E203 ].strip("\r\n var tiles = ") )