From 3b9c8ecccefe0502b64525a269323c36db10e6c4 Mon Sep 17 00:00:00 2001 From: DidierRLopes Date: Sat, 6 Nov 2021 11:53:42 +0000 Subject: [PATCH] remove PR command due to paid paywall (#924) --- .../stocks/technical_analysis/README.md | 1 - .../technical_analysis/ta_controller.py | 43 ------------------- .../common/technical_analysis/pr/_index.md | 18 -------- website/data/menu/main.yml | 2 - 4 files changed, 64 deletions(-) delete mode 100755 website/content/common/technical_analysis/pr/_index.md diff --git a/gamestonk_terminal/stocks/technical_analysis/README.md b/gamestonk_terminal/stocks/technical_analysis/README.md index be2f6dc353d..1d5276e77a8 100644 --- a/gamestonk_terminal/stocks/technical_analysis/README.md +++ b/gamestonk_terminal/stocks/technical_analysis/README.md @@ -5,7 +5,6 @@ Command | Description | Info `view` | view historical data and trendlines| [Finviz](https://finviz.com/quote.ashx?t=tsla) `summary` | technical summary report| [FinBrain](https://finbrain.tech) `recom` | recommendation based on Technical Indicators| [Tradingview](https://uk.tradingview.com/widget/technical-analysis/) -`pr` | pattern recognition| [Finnhub](https://finnhub.io) [overlap](https://github.com/twopirllc/pandas-ta/tree/master/pandas_ta/overlap) | `ema` | exponential moving average | [Wikipedia](https://en.wikipedia.org/wiki/Moving_average#Exponential_moving_average), [Investopedia](https://www.investopedia.com/terms/e/ema.asp) `sma` |simple moving average | [Wikipedia](https://en.wikipedia.org/wiki/Moving_average#Simple_moving_average_(boxcar_filter)), [Investopedia](https://www.investopedia.com/terms/s/sma.asp) diff --git a/gamestonk_terminal/stocks/technical_analysis/ta_controller.py b/gamestonk_terminal/stocks/technical_analysis/ta_controller.py index bccb35cb84a..aa117bacc3e 100644 --- a/gamestonk_terminal/stocks/technical_analysis/ta_controller.py +++ b/gamestonk_terminal/stocks/technical_analysis/ta_controller.py @@ -25,7 +25,6 @@ from gamestonk_terminal.menu import session from gamestonk_terminal.stocks.technical_analysis import ( finviz_view, finbrain_view, - finnhub_view, tradingview_view, ) from gamestonk_terminal.common.technical_analysis import ( @@ -47,7 +46,6 @@ class TechnicalAnalysisController: "view", "summary", "recom", - "pr", "ema", "sma", "wma", @@ -112,7 +110,6 @@ Technical Analysis: view view historical data and trendlines [Finviz] summary technical summary report [FinBrain API] recom recommendation based on Technical Indicators [Tradingview API] - pr pattern recognition [Finnhub] Overlap: ema exponential moving average @@ -289,46 +286,6 @@ Custom: export=ns_parser.export, ) - @try_except - def call_pr(self, other_args: List[str]): - """Process pr command""" - - parser = argparse.ArgumentParser( - add_help=False, - formatter_class=argparse.ArgumentDefaultsHelpFormatter, - prog="pr", - description=""" - Display pattern recognition signals on the data. [Source: Finnhub]""", - ) - parser.add_argument( - "-r", - "--resolution", - action="store", - dest="resolution", - type=str, - default="D", - choices=["1", "5", "15", "30", "60", "D", "W", "M"], - help="Plot resolution to look for pattern signals", - ) - parser.add_argument( - "--export", - choices=["csv", "json", "xlsx"], - default="", - type=str, - dest="export", - help="Export dataframe data to csv,json,xlsx file", - ) - - ns_parser = parse_known_args_and_warn(parser, other_args) - if not ns_parser: - return - - finnhub_view.plot_pattern_recognition( - ticker=self.ticker, - resolution=ns_parser.resolution, - export=ns_parser.export, - ) - # COMMON # TODO: Go through all models and make sure all needed columns are in dfs @try_except diff --git a/website/content/common/technical_analysis/pr/_index.md b/website/content/common/technical_analysis/pr/_index.md deleted file mode 100755 index 896362a4030..00000000000 --- a/website/content/common/technical_analysis/pr/_index.md +++ /dev/null @@ -1,18 +0,0 @@ -``` -usage: pr [-r {1,5,15,30,60,D,W,M}] [--export {csv,json,xlsx}] [-h] -``` - -Display pattern recognition signals on the data. [Source: https://finnhub.io] - -``` -optional arguments: - -r {1,5,15,30,60,D,W,M}, --resolution {1,5,15,30,60,D,W,M} - Plot resolution to look for pattern signals (default: D) - --export {csv,json,xlsx} - Export dataframe data to csv,json,xlsx file (default: ) - -h, --help show this help message (default: False) -``` - -![pr](https://user-images.githubusercontent.com/25267873/116812520-06338700-ab47-11eb-8db4-8f5e940507ed.png) - -Captura de ecrã 2021-05-02, às 02 27 10 diff --git a/website/data/menu/main.yml b/website/data/menu/main.yml index e7da3680fed..ed99f72be7a 100755 --- a/website/data/menu/main.yml +++ b/website/data/menu/main.yml @@ -359,8 +359,6 @@ main: ref: "/common/technical_analysis/summary" - name: recom ref: "/common/technical_analysis/recom" - - name: pr - ref: "/common/technical_analysis/pr" - name: ema ref: "/common/technical_analysis/ema" - name: sma