diff --git a/gamestonk_terminal/due_diligence/business_insider_view.py b/gamestonk_terminal/due_diligence/business_insider_view.py index 68f4f573a50..fd83d023cc3 100644 --- a/gamestonk_terminal/due_diligence/business_insider_view.py +++ b/gamestonk_terminal/due_diligence/business_insider_view.py @@ -25,7 +25,7 @@ register_matplotlib_converters() def price_target_from_analysts( other_args: List[str], stock: DataFrame, ticker: str, start: str, interval: str ): - """Print analysts' price targets for a given stock + """Display analysts' price targets for a given stock Parameters ---------- @@ -143,7 +143,7 @@ def price_target_from_analysts( def estimates(other_args: List[str], ticker: str): - """Print analysts' estimates for a given ticker + """Display analysts' estimates for a given ticker Parameters ---------- @@ -314,7 +314,7 @@ def estimates(other_args: List[str], ticker: str): def insider_activity( other_args: List[str], stock: DataFrame, ticker: str, start: str, interval: str ): - """Print insider activity + """Display insider activity Parameters ---------- diff --git a/gamestonk_terminal/due_diligence/dd_controller.py b/gamestonk_terminal/due_diligence/dd_controller.py index bc3a85379a4..deebd355a4d 100644 --- a/gamestonk_terminal/due_diligence/dd_controller.py +++ b/gamestonk_terminal/due_diligence/dd_controller.py @@ -7,7 +7,7 @@ from pandas.core.frame import DataFrame from prompt_toolkit.completion import NestedCompleter from gamestonk_terminal.due_diligence import business_insider_view as bi_view -from gamestonk_terminal.due_diligence import financial_modeling_prep_api as fmp_api +from gamestonk_terminal.due_diligence import financial_modeling_prep_view as fmp_view from gamestonk_terminal.due_diligence import finviz_api as fvz_api from gamestonk_terminal.due_diligence import market_watch_api as mw_api from gamestonk_terminal.due_diligence import quandl_api as q_api @@ -161,7 +161,7 @@ class DueDiligenceController: def call_rating(self, other_args: List[str]): """ Process rating command """ - fmp_api.rating(other_args, self.ticker) + fmp_view.rating(other_args, self.ticker) def call_warnings(self, other_args: List[str]): """ Process rating command """ diff --git a/gamestonk_terminal/due_diligence/financial_modeling_prep_api.py b/gamestonk_terminal/due_diligence/financial_modeling_prep_view.py similarity index 65% rename from gamestonk_terminal/due_diligence/financial_modeling_prep_api.py rename to gamestonk_terminal/due_diligence/financial_modeling_prep_view.py index 9163bf02149..68cb7aae1c4 100644 --- a/gamestonk_terminal/due_diligence/financial_modeling_prep_api.py +++ b/gamestonk_terminal/due_diligence/financial_modeling_prep_view.py @@ -1,10 +1,24 @@ +""" Due Diligence Controller """ +__docformat__ = "numpy" + import argparse +from typing import List import FundamentalAnalysis as fa # Financial Modeling Prep from gamestonk_terminal import config_terminal as cfg from gamestonk_terminal.helper_funcs import parse_known_args_and_warn -def rating(l_args, s_ticker): +def rating(other_args: List[str], ticker: str): + """Display ratings for a given ticker + + Parameters + ---------- + other_args : List[str] + argparse other args + ticker : str + Stock ticker + """ + parser = argparse.ArgumentParser( add_help=False, prog="rating", @@ -16,18 +30,18 @@ def rating(l_args, s_ticker): ) try: - ns_parser = parse_known_args_and_warn(parser, l_args) + ns_parser = parse_known_args_and_warn(parser, other_args) if not ns_parser: return - df_fa = fa.rating(s_ticker, cfg.API_KEY_FINANCIALMODELINGPREP) + df_fa = fa.rating(ticker, cfg.API_KEY_FINANCIALMODELINGPREP) print(df_fa) print("") except KeyError: print( - f"Financialmodelingprep.com is returning empty response the ticker {s_ticker}." + f"Financialmodelingprep.com is returning empty response the ticker {ticker}." ) print("") return diff --git a/tests/test_dd_financial_modeling_prep_api.py b/tests/test_dd_financial_modeling_prep_api.py deleted file mode 100644 index 952fecdfb73..00000000000 --- a/tests/test_dd_financial_modeling_prep_api.py +++ /dev/null @@ -1,9 +0,0 @@ -""" fundamental_analysis/business_insider_api.py tests """ -import unittest - -from gamestonk_terminal.due_diligence.financial_modeling_prep_api import rating - - -class TestDdFinancialModelingPrepApi(unittest.TestCase): - def test_rating(self): - rating([], "PLTR")