From c2a64085678735afb0819c0fed6dbeb954d3f1db Mon Sep 17 00:00:00 2001 From: Diogo Sousa Date: Sat, 25 Feb 2023 19:09:58 +0000 Subject: [PATCH 1/3] remove yfinance from news --- openbb_terminal/stocks/stocks_controller.py | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/openbb_terminal/stocks/stocks_controller.py b/openbb_terminal/stocks/stocks_controller.py index f11a4386909..fac78739545 100644 --- a/openbb_terminal/stocks/stocks_controller.py +++ b/openbb_terminal/stocks/stocks_controller.py @@ -535,15 +535,9 @@ class StocksController(StockBaseController): self.ticker = ns_parser.ticker self.custom_load_wrapper([self.ticker]) if self.ticker: - try: - d_stock = yf.Ticker(self.ticker).info - except TypeError: - d_stock = dict() if ns_parser.source == "NewsApi": newsapi_view.display_news( - query=d_stock["shortName"].replace(" ", "+") - if "shortName" in d_stock - else self.ticker, + query=self.ticker, limit=ns_parser.limit, start_date=ns_parser.n_start_date.strftime("%Y-%m-%d"), show_newest=ns_parser.n_oldest, @@ -551,9 +545,7 @@ class StocksController(StockBaseController): ) elif ns_parser.source == "Feedparser": feedparser_view.display_news( - term=d_stock["shortName"].replace(" ", "+") - if "shortName" in d_stock - else self.ticker, + term=self.ticker, sources=ns_parser.sources, limit=ns_parser.limit, export=ns_parser.export, From c10053e209808f850d63e25eb729644508e9dbda Mon Sep 17 00:00:00 2001 From: Diogo Sousa Date: Sat, 25 Feb 2023 19:36:11 +0000 Subject: [PATCH 2/3] ruff --- openbb_terminal/stocks/stocks_controller.py | 1 - 1 file changed, 1 deletion(-) diff --git a/openbb_terminal/stocks/stocks_controller.py b/openbb_terminal/stocks/stocks_controller.py index fac78739545..db8b4bc9fb4 100644 --- a/openbb_terminal/stocks/stocks_controller.py +++ b/openbb_terminal/stocks/stocks_controller.py @@ -8,7 +8,6 @@ from datetime import datetime, timedelta from typing import List, Optional import financedatabase -import yfinance as yf from openbb_terminal import feature_flags as obbff from openbb_terminal.common import feedparser_view, newsapi_view From 8661f228845306cf612970d5c4946971616c9bf8 Mon Sep 17 00:00:00 2001 From: Diogo Sousa Date: Mon, 27 Feb 2023 17:49:14 +0000 Subject: [PATCH 3/3] fix test --- tests/openbb_terminal/stocks/test_stocks_controller.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/tests/openbb_terminal/stocks/test_stocks_controller.py b/tests/openbb_terminal/stocks/test_stocks_controller.py index 9382acee0cf..bc93b6653c4 100644 --- a/tests/openbb_terminal/stocks/test_stocks_controller.py +++ b/tests/openbb_terminal/stocks/test_stocks_controller.py @@ -435,14 +435,6 @@ def test_call_func( ) # MOCK TICKER + INFO - mocker.patch( - target=f"{path_controller}.yf.Ticker", - ) - mocker.patch( - target=f"{path_controller}.yf.Ticker.info", - return_value={"shortName": "MOCK_SHORT_NAME"}, - ) - if mocked_func: mock = mocker.Mock() mocker.patch(