From 49bdd76e9fbaa13151afa9e2392f344a5895a34d Mon Sep 17 00:00:00 2001 From: Danglewood <85772166+deeleeramone@users.noreply.github.com> Date: Thu, 23 Nov 2023 08:22:45 -0800 Subject: [PATCH] hotfix/yfinance-download: Fix Intraday Helper (#5785) * fix yfinance_download intraday helper * fix today getting cutoff --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> --- .../yfinance/openbb_yfinance/models/equity_historical.py | 7 ++----- .../providers/yfinance/openbb_yfinance/utils/helpers.py | 5 ++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/openbb_platform/providers/yfinance/openbb_yfinance/models/equity_historical.py b/openbb_platform/providers/yfinance/openbb_yfinance/models/equity_historical.py index bfe6955838e..5802b54408b 100644 --- a/openbb_platform/providers/yfinance/openbb_yfinance/models/equity_historical.py +++ b/openbb_platform/providers/yfinance/openbb_yfinance/models/equity_historical.py @@ -151,12 +151,9 @@ class YFinanceEquityHistoricalFetcher( data.set_index("date", inplace=True) data.index = to_datetime(data.index) - start_date_dt = datetime.combine(query.start_date, datetime.min.time()) - end_date_dt = datetime.combine(query.end_date, datetime.min.time()) - data = data[ - (data.index >= start_date_dt + timedelta(days=days)) - & (data.index <= end_date_dt) + (data.index >= to_datetime(query.start_date)) + & (data.index <= to_datetime(query.end_date + timedelta(days=days))) ] data.reset_index(inplace=True) diff --git a/openbb_platform/providers/yfinance/openbb_yfinance/utils/helpers.py b/openbb_platform/providers/yfinance/openbb_yfinance/utils/helpers.py index bebaac47b61..ae93cd32a92 100644 --- a/openbb_platform/providers/yfinance/openbb_yfinance/utils/helpers.py +++ b/openbb_platform/providers/yfinance/openbb_yfinance/utils/helpers.py @@ -10,8 +10,7 @@ from typing import Any, Literal, Optional, Union import pandas as pd import yfinance as yf from dateutil.relativedelta import relativedelta - -from .references import MONTHS +from openbb_yfinance.utils.references import MONTHS def get_futures_data() -> pd.DataFrame: @@ -107,7 +106,7 @@ def yf_download( _start_date = None if interval in ["2m", "5m", "15m", "30m", "90m"]: - _start_date = (datetime.now().date() - relativedelta(days=59)).strftime( + _start_date = (datetime.now().date() - relativedelta(days=58)).strftime( "%Y-%m-%d" )