From 683b0d3f8843d86e646bfcedfd974c419588973c Mon Sep 17 00:00:00 2001 From: Artem Veremey Date: Tue, 23 Nov 2021 16:18:28 -0800 Subject: [PATCH] Enable consider-iterating-dictionary and consider-using-in --- .pylintrc | 2 +- gamestonk_terminal/reports/reports_controller.py | 2 +- .../stocks/options/calculator_model.py | 2 +- .../stocks/screener/finviz_model.py | 16 ++++++++-------- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.pylintrc b/.pylintrc index 06886301726..6d549c4c9e0 100644 --- a/.pylintrc +++ b/.pylintrc @@ -54,7 +54,7 @@ confidence= # disable=import-error,print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,import-star-module-level,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call # disable=too-many-instance-attributes,len-as-condition,too-few-public-methods,anomalous-backslash-in-string,no-else-return,simplifiable-if-statement,too-many-arguments,duplicate-code,no-name-in-module,no-member,print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,import-star-module-level,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call,import-error,missing-docstring,invalid-name,bad-whitespace,consider-using-enumerate,unexpected-keyword-arg -disable=useless-return,missing-docstring,invalid-name,import-error,bad-continuation,broad-except,unnecessary-lambda,no-self-use,duplicate-code,consider-using-generator,unbalanced-tuple-unpacking,use-list-literal,no-name-in-module,use-sequence-for-iteration,use-dict-literal,unspecified-encoding,unsubscriptable-object,consider-using-f-string,unsupported-assignment-operation,consider-iterating-dictionary,consider-using-in +disable=useless-return,missing-docstring,invalid-name,import-error,bad-continuation,broad-except,unnecessary-lambda,no-self-use,duplicate-code,consider-using-generator,unbalanced-tuple-unpacking,use-list-literal,no-name-in-module,use-sequence-for-iteration,use-dict-literal,unspecified-encoding,unsubscriptable-object,consider-using-f-string,unsupported-assignment-operation # Enable the message, report, category or checker with the given id(s). You can # either give multiple identifier separated by comma (,) or put this option diff --git a/gamestonk_terminal/reports/reports_controller.py b/gamestonk_terminal/reports/reports_controller.py index 721fd24d3fb..3d681479120 100644 --- a/gamestonk_terminal/reports/reports_controller.py +++ b/gamestonk_terminal/reports/reports_controller.py @@ -132,7 +132,7 @@ Select one of the following reports: (known_args, other_args) = self.report_parser.parse_known_args(an_input.split()) # Help menu again - if known_args.cmd == "?" or known_args.cmd == "help": + if known_args.cmd in ["?", "help"]: self.print_help() return None diff --git a/gamestonk_terminal/stocks/options/calculator_model.py b/gamestonk_terminal/stocks/options/calculator_model.py index 82e4bcd76bf..4c5e0798e5b 100644 --- a/gamestonk_terminal/stocks/options/calculator_model.py +++ b/gamestonk_terminal/stocks/options/calculator_model.py @@ -33,7 +33,7 @@ def pnl_calculator( Breakeven point """ - if "x_min" in kwargs.keys() and "x_max" in kwargs.keys(): + if "x_min" in kwargs and "x_max" in kwargs: price_at_expiry = np.linspace(kwargs["x_min"], kwargs["x_max"], 301) else: price_at_expiry = np.linspace(strike / 2, 1.5 * strike, 301) diff --git a/gamestonk_terminal/stocks/screener/finviz_model.py b/gamestonk_terminal/stocks/screener/finviz_model.py index 091e02ed0d5..7aeca2d0dc0 100644 --- a/gamestonk_terminal/stocks/screener/finviz_model.py +++ b/gamestonk_terminal/stocks/screener/finviz_model.py @@ -51,17 +51,17 @@ def get_screener_data( for section in ["General", "Descriptive", "Fundamental", "Technical"]: for key, val in {**preset_filter[section]}.items(): - if key in d_check_screener.keys(): - if val not in d_check_screener[key]: - print( - f"Invalid [{section}] {key}={val}. " - f"Choose one of the following options:\n{', '.join(d_check_screener[key])}.\n" - ) - return pd.DataFrame() - else: + if not key in d_check_screener: print(f"The screener variable {section}.{key} shouldn't exist!\n") return pd.DataFrame() + if val not in d_check_screener[key]: + print( + f"Invalid [{section}] {key}={val}. " + f"Choose one of the following options:\n{', '.join(d_check_screener[key])}.\n" + ) + return pd.DataFrame() + d_filters = {k: v for k, v in d_filters.items() if v} if data_type == "overview":