From 6c702a3ed0fef3a56a354ef59210e0b7e4e74da7 Mon Sep 17 00:00:00 2001 From: Igor Radovanovic <74266147+IgorWounds@users.noreply.github.com> Date: Mon, 7 Aug 2023 21:56:27 +0200 Subject: [PATCH] Fix some failing tests --- .../tests/app/static/test_package_builder.py | 6 +- .../core/tests/app/test_provider_interface.py | 17 +-- .../sdk/core/tests/test_provider_interface.py | 100 ------------------ 3 files changed, 4 insertions(+), 119 deletions(-) delete mode 100644 openbb_sdk/sdk/core/tests/test_provider_interface.py diff --git a/openbb_sdk/sdk/core/tests/app/static/test_package_builder.py b/openbb_sdk/sdk/core/tests/app/static/test_package_builder.py index e922fa1cf3a..659061194a2 100644 --- a/openbb_sdk/sdk/core/tests/app/static/test_package_builder.py +++ b/openbb_sdk/sdk/core/tests/app/static/test_package_builder.py @@ -3,7 +3,6 @@ from dataclasses import dataclass from inspect import _empty -from typing import Annotated import pytest from openbb_core.app.static.package_builder import ( @@ -17,6 +16,7 @@ from openbb_core.app.static.package_builder import ( PathHandler, ) from pydantic import Field +from typing_extensions import Annotated @pytest.fixture(scope="module") @@ -395,7 +395,7 @@ def test_clean_path(path_handler): def test_build_module_name(path_handler): """Test build module name.""" module_name = path_handler.build_module_name(path="") - assert module_name == "__commands__" + assert module_name == "__extensions__" module_name = path_handler.build_module_name(path="/stocks/load") assert module_name == "stocks_load" @@ -404,7 +404,7 @@ def test_build_module_name(path_handler): def test_build_module_class(path_handler): """Test build module class.""" module_class = path_handler.build_module_class(path="") - assert module_class == "Commands" + assert module_class == "Extensions" module_class = path_handler.build_module_class(path="/stocks/load") assert module_class == "CLASS_stocks_load" diff --git a/openbb_sdk/sdk/core/tests/app/test_provider_interface.py b/openbb_sdk/sdk/core/tests/app/test_provider_interface.py index e61fdda19ca..56483d23571 100644 --- a/openbb_sdk/sdk/core/tests/app/test_provider_interface.py +++ b/openbb_sdk/sdk/core/tests/app/test_provider_interface.py @@ -5,7 +5,6 @@ import pytest from openbb_core.app.provider_interface import ( ProviderChoices, ProviderInterface, - ProviderRegistry, get_provider_interface, ) @@ -37,7 +36,7 @@ def test_map(provider_interface): def test_required_credentials(provider_interface): """Test required credentials.""" required_credentials = provider_interface.required_credentials - assert isinstance(required_credentials, dict) + assert isinstance(required_credentials, list) assert len(required_credentials) > 0 @@ -64,14 +63,6 @@ def test_data(provider_interface): assert "StockEOD" in data -def test_merged_data(provider_interface): - """Test merged data.""" - merged_data = provider_interface.merged_data - assert isinstance(merged_data, dict) - assert len(merged_data) > 0 - assert "StockEOD" in merged_data - - def test_providers_literal(provider_interface): """Test providers literal.""" providers_literal = provider_interface.providers_literal @@ -92,9 +83,3 @@ def test_models(provider_interface): assert isinstance(models, list) assert len(models) > 0 assert "StockEOD" in models - - -def test_build_registry(provider_interface): - """Test build registry.""" - build_registry = provider_interface.build_registry() - assert isinstance(build_registry, ProviderRegistry) diff --git a/openbb_sdk/sdk/core/tests/test_provider_interface.py b/openbb_sdk/sdk/core/tests/test_provider_interface.py deleted file mode 100644 index e61fdda19ca..00000000000 --- a/openbb_sdk/sdk/core/tests/test_provider_interface.py +++ /dev/null @@ -1,100 +0,0 @@ -"""Test provider interface.""" -# pylint: disable=redefined-outer-name - -import pytest -from openbb_core.app.provider_interface import ( - ProviderChoices, - ProviderInterface, - ProviderRegistry, - get_provider_interface, -) - - -@pytest.fixture(scope="module") -def provider_interface(): - """Set up provider_interface.""" - return ProviderInterface() - - -def test_init(provider_interface): - """Test init.""" - assert provider_interface - - -def test_get_provider_interface(): - """Test get provider interface.""" - assert isinstance(get_provider_interface(), ProviderInterface) - - -def test_map(provider_interface): - """Test map.""" - provider_interface_map = provider_interface.map - assert isinstance(provider_interface_map, dict) - assert len(provider_interface_map) > 0 - assert "StockEOD" in provider_interface_map - - -def test_required_credentials(provider_interface): - """Test required credentials.""" - required_credentials = provider_interface.required_credentials - assert isinstance(required_credentials, dict) - assert len(required_credentials) > 0 - - -def test_model_providers(provider_interface): - """Test model providers.""" - model_providers = provider_interface.model_providers - assert isinstance(model_providers, dict) - assert len(model_providers) > 0 - - -def test_params(provider_interface): - """Test params.""" - params = provider_interface.params - assert isinstance(params, dict) - assert len(params) > 0 - assert "StockEOD" in params - - -def test_data(provider_interface): - """Test data.""" - data = provider_interface.data - assert isinstance(data, dict) - assert len(data) > 0 - assert "StockEOD" in data - - -def test_merged_data(provider_interface): - """Test merged data.""" - merged_data = provider_interface.merged_data - assert isinstance(merged_data, dict) - assert len(merged_data) > 0 - assert "StockEOD" in merged_data - - -def test_providers_literal(provider_interface): - """Test providers literal.""" - providers_literal = provider_interface.providers_literal - assert isinstance(type(providers_literal), type) - assert len(providers_literal.__args__) > 0 - assert "openbb" not in providers_literal.__args__ - - -def test_provider_choices(provider_interface): - """Test provider choices.""" - provider_choices = provider_interface.provider_choices - assert isinstance(provider_choices, type(ProviderChoices)) - - -def test_models(provider_interface): - """Test models.""" - models = provider_interface.models - assert isinstance(models, list) - assert len(models) > 0 - assert "StockEOD" in models - - -def test_build_registry(provider_interface): - """Test build registry.""" - build_registry = provider_interface.build_registry() - assert isinstance(build_registry, ProviderRegistry)