jerry/OpenBB
1
0
Fork 0
mirror of https://github.com/OpenBB-finance/OpenBB.git synced 2026-11-06 17:31:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[BugFix] openbb-cboe: Fix cache lock so that concurrent callers in separate processes don't hang (#7796)

Browse Source 
* fix cboe's cache lock so that concurrent callers in separate processes don't hang

* fix test coverage and ty check

* more test failure

* more test failure

* more Windows Python 3.10 test failure

* Move lint path filter into a job so required checks always report

lint-openbb-platform.yml used `on.pull_request.paths` to skip PRs that only
touch api/extensions/providers/obbject_extensions. A workflow skipped by a
trigger filter never reports its checks, so the required "General Code
Linting" and "Markdown Linting" checks stayed pending forever on those PRs.

Detect relevant changes in a `changes` job instead and gate the lint jobs with
a job-level `if:`. Skipped jobs report success, so required checks resolve.
The gate fails closed: if detection fails, the lint jobs still run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: dlee-bq <325002271+dlee-bq@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
dlee-bq
2026-10-16 17:50:40 +00:00
committed by GitHub
parent 7c9d4221bd
commit 7f49354884
9 changed files with 1522 additions and 322 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
.github/workflows/lint-openbb-platform.yml vendored
View File

@@ -6,15 +6,6 @@ env:
on:
pull_request:
types: [opened, synchronize, edited]
paths:
- 'openbb_platform/**'
- '!openbb_platform/api/**'
- '!openbb_platform/extensions/**'
- '!openbb_platform/providers/**'
- '!openbb_platform/obbject_extensions/**'
- '.github/workflows/lint-openbb-platform.yml'
- '.github/codeql/**'
- '.github/workflows/codeql.yml'
merge_group:
types: [checks_requested]
@@ -23,8 +14,46 @@ concurrency:
cancel-in-progress: true
jobs:
changes:
name: Detect Changes
runs-on: ubuntu-latest
permissions:
pull-requests: read
outputs:
platform: ${{ steps.filter.outputs.platform }}
steps:
- name: Check for shared platform changes
id: filter
env:
GH_TOKEN: ${{ github.token }}
EVENT_NAME: ${{ github.event_name }}
REPO: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: |
# Path filtering lives here instead of `on.pull_request.paths`: a workflow
# skipped by a trigger filter never reports its checks, which leaves the
# required "General Code Linting" and "Markdown Linting" checks pending
# forever. Jobs skipped by a job-level `if:` report success instead.
if [ "$EVENT_NAME" != "pull_request" ]; then
echo "platform=true" >> "$GITHUB_OUTPUT"
exit 0
fi
gh api --paginate "repos/${REPO}/pulls/${PR_NUMBER}/files" --jq '.[].filename' > changed_files.txt
if awk '
/^\.github\/(workflows\/(lint-openbb-platform|codeql)\.yml$|codeql\/)/ { found = 1 }
/^openbb_platform\// && !/^openbb_platform\/(api|extensions|providers|obbject_extensions)\// { found = 1 }
END { exit !found }
' changed_files.txt; then
echo "platform=true" >> "$GITHUB_OUTPUT"
else
echo "platform=false" >> "$GITHUB_OUTPUT"
fi
code-linting:
name: General Code Linting
needs: changes
# Fail closed: run unless change detection explicitly found nothing relevant.
if: ${{ !cancelled() && needs.changes.outputs.platform != 'false' }}
runs-on: ubuntu-latest
env:
UV_CACHE_DIR: ${{ github.workspace }}/.uv-cache
@@ -122,6 +151,8 @@ jobs:
markdown-link-check:
name: Markdown Linting
needs: changes
if: ${{ !cancelled() && needs.changes.outputs.platform != 'false' }}
runs-on: ubuntu-latest
permissions:
contents: read
@@ -136,6 +167,8 @@ jobs:
json-yaml-validate:
name: JSON Check
needs: changes
if: ${{ !cancelled() && needs.changes.outputs.platform != 'false' }}
runs-on: ubuntu-latest
permissions:
contents: read