From 8ce8380ef3fa44231aa1b3b372c070b11152362b Mon Sep 17 00:00:00 2001 From: James Maslek Date: Mon, 24 Apr 2023 19:04:21 -0400 Subject: [PATCH] Last minutes enhancements (#4885) * Remove tab, fix overwrite, transpose exports * missed some * eodhd transpose --- openbb_terminal/featflags_controller.py | 10 +--------- openbb_terminal/miscellaneous/i18n/en.yml | 1 - .../stocks/fundamental_analysis/av_view.py | 8 ++++---- .../stocks/fundamental_analysis/eodhd_view.py | 2 +- .../stocks/fundamental_analysis/fmp_view.py | 14 +++++++------- .../stocks/fundamental_analysis/polygon_view.py | 2 +- .../fundamental_analysis/yahoo_finance_view.py | 2 +- tests/openbb_terminal/test_featflags_controller.py | 4 ---- 8 files changed, 15 insertions(+), 28 deletions(-) diff --git a/openbb_terminal/featflags_controller.py b/openbb_terminal/featflags_controller.py index 0f0100529a8..43ef32893e6 100644 --- a/openbb_terminal/featflags_controller.py +++ b/openbb_terminal/featflags_controller.py @@ -77,7 +77,6 @@ class FeatureFlagsController(BaseController): mt.add_info("_info_") mt.add_raw("\n") mt.add_setting("retryload", current_user.preferences.RETRY_WITH_LOAD) - mt.add_setting("tab", current_user.preferences.USE_TABULATE_DF) mt.add_setting("interactive", current_user.preferences.USE_INTERACTIVE_DF) mt.add_setting("cls", current_user.preferences.USE_CLEAR_AFTER_CMD) mt.add_setting("promptkit", current_user.preferences.USE_PROMPT_TOOLKIT) @@ -95,7 +94,7 @@ class FeatureFlagsController(BaseController): def call_overwrite(self, _): """Process overwrite command""" set_and_save_preference( - "FILE_OVERWITE", not get_current_user().preferences.FILE_OVERWRITE + "FILE_OVERWRITE", not get_current_user().preferences.FILE_OVERWRITE ) def call_version(self, _): @@ -110,13 +109,6 @@ class FeatureFlagsController(BaseController): "RETRY_WITH_LOAD", not get_current_user().preferences.RETRY_WITH_LOAD ) - @log_start_end(log=logger) - def call_tab(self, _): - """Process tab command""" - set_and_save_preference( - "USE_TABULATE_DF", not get_current_user().preferences.USE_TABULATE_DF - ) - @log_start_end(log=logger) def call_interactive(self, _): """Process interactive command""" diff --git a/openbb_terminal/miscellaneous/i18n/en.yml b/openbb_terminal/miscellaneous/i18n/en.yml index df319972174..eb46cce409b 100644 --- a/openbb_terminal/miscellaneous/i18n/en.yml +++ b/openbb_terminal/miscellaneous/i18n/en.yml @@ -48,7 +48,6 @@ en: sources/set: set default data source for a command featflags/_info_: Feature flags through environment variables featflags/retryload: retry misspelled commands with load first - featflags/tab: use tabulate to print dataframes featflags/interactive: open dataframes in interactive window featflags/cls: clear console after each command featflags/color: use coloring features diff --git a/openbb_terminal/stocks/fundamental_analysis/av_view.py b/openbb_terminal/stocks/fundamental_analysis/av_view.py index 3de31755121..922d0f71f00 100644 --- a/openbb_terminal/stocks/fundamental_analysis/av_view.py +++ b/openbb_terminal/stocks/fundamental_analysis/av_view.py @@ -77,7 +77,7 @@ def display_key(symbol: str, export: str = "", sheet_name: Optional[str] = None) export, os.path.dirname(os.path.abspath(__file__)), "key", - df_key, + df_key.transpose(), sheet_name, ) @@ -174,7 +174,7 @@ def display_income_statement( export, os.path.dirname(os.path.abspath(__file__)), "income", - df_income, + df_income.transpose(), sheet_name, fig, ) @@ -271,7 +271,7 @@ def display_balance_sheet( export, os.path.dirname(os.path.abspath(__file__)), "balance", - df_balance, + df_balance.transpose(), sheet_name, fig, ) @@ -366,7 +366,7 @@ def display_cash_flow( export, os.path.dirname(os.path.abspath(__file__)), "cash", - df_cash, + df_cash.transpose(), sheet_name, fig, ) diff --git a/openbb_terminal/stocks/fundamental_analysis/eodhd_view.py b/openbb_terminal/stocks/fundamental_analysis/eodhd_view.py index ca6583e4bb3..7bef2ae96fb 100644 --- a/openbb_terminal/stocks/fundamental_analysis/eodhd_view.py +++ b/openbb_terminal/stocks/fundamental_analysis/eodhd_view.py @@ -141,7 +141,7 @@ def display_fundamentals( export, os.path.dirname(os.path.abspath(__file__)), statement, - fundamentals, + fundamentals.transpose(), sheet_name, fig, ) diff --git a/openbb_terminal/stocks/fundamental_analysis/fmp_view.py b/openbb_terminal/stocks/fundamental_analysis/fmp_view.py index 88a8b2d5f04..057f7104e9a 100644 --- a/openbb_terminal/stocks/fundamental_analysis/fmp_view.py +++ b/openbb_terminal/stocks/fundamental_analysis/fmp_view.py @@ -241,7 +241,7 @@ def display_discounted_cash_flow( export, os.path.dirname(os.path.abspath(__file__)), "dcf", - dcf, + dcf.transpose(), sheet_name, ) @@ -345,7 +345,7 @@ def display_income_statement( export, os.path.dirname(os.path.abspath(__file__)), "income", - income, + income.transpose(), sheet_name, fig, ) @@ -449,7 +449,7 @@ def display_balance_sheet( export, os.path.dirname(os.path.abspath(__file__)), "balance", - balance, + balance.transpose(), sheet_name, fig, ) @@ -553,7 +553,7 @@ def display_cash_flow( export, os.path.dirname(os.path.abspath(__file__)), "cash", - cash, + cash.transpose(), sheet_name, fig, ) @@ -602,7 +602,7 @@ def display_key_metrics( export, os.path.dirname(os.path.abspath(__file__)), "metrics", - key_metrics, + key_metrics.transpose(), sheet_name, ) else: @@ -650,7 +650,7 @@ def display_financial_ratios( export, os.path.dirname(os.path.abspath(__file__)), "grratiosowth", - ratios, + ratios.transpose(), sheet_name, ) else: @@ -697,7 +697,7 @@ def display_financial_statement_growth( export, os.path.dirname(os.path.abspath(__file__)), "growth", - growth, + growth.transpose(), sheet_name, ) else: diff --git a/openbb_terminal/stocks/fundamental_analysis/polygon_view.py b/openbb_terminal/stocks/fundamental_analysis/polygon_view.py index a0c647f6e4e..ce9c27709db 100644 --- a/openbb_terminal/stocks/fundamental_analysis/polygon_view.py +++ b/openbb_terminal/stocks/fundamental_analysis/polygon_view.py @@ -131,7 +131,7 @@ def display_fundamentals( export, os.path.dirname(os.path.abspath(__file__)), statement, - fundamentals, + fundamentals.transpose(), sheet_name, fig, ) diff --git a/openbb_terminal/stocks/fundamental_analysis/yahoo_finance_view.py b/openbb_terminal/stocks/fundamental_analysis/yahoo_finance_view.py index 7eed7853020..32e3dc78136 100644 --- a/openbb_terminal/stocks/fundamental_analysis/yahoo_finance_view.py +++ b/openbb_terminal/stocks/fundamental_analysis/yahoo_finance_view.py @@ -459,7 +459,7 @@ def display_fundamentals( export, os.path.dirname(os.path.abspath(__file__)), statement, - fundamentals, + fundamentals.transpose(), sheet_name, fig, ) diff --git a/tests/openbb_terminal/test_featflags_controller.py b/tests/openbb_terminal/test_featflags_controller.py index 1ed75da1a9c..635fbada0af 100644 --- a/tests/openbb_terminal/test_featflags_controller.py +++ b/tests/openbb_terminal/test_featflags_controller.py @@ -34,10 +34,6 @@ def test_print_help(controller): controller.print_help() -def test_call_tab(controller): - controller.call_tab(None) - - def test_call_cls(controller): controller.call_cls(None)