From 8ec4d64ce3f5af2b152c9e66e161b77d12676757 Mon Sep 17 00:00:00 2001 From: hjoaquim Date: Wed, 24 Jan 2024 10:38:49 +0000 Subject: [PATCH] removing unnecessary credentials variable cc @montezdesousa --- openbb_platform/core/openbb_core/app/model/obbject.py | 1 - openbb_platform/core/openbb_core/app/static/container.py | 1 - .../development/developer-guidelines/obbject_extensions.md | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/openbb_platform/core/openbb_core/app/model/obbject.py b/openbb_platform/core/openbb_core/app/model/obbject.py index 6bd40a27d52..4f5c2da7d06 100644 --- a/openbb_platform/core/openbb_core/app/model/obbject.py +++ b/openbb_platform/core/openbb_core/app/model/obbject.py @@ -60,7 +60,6 @@ class OBBject(Tagged, Generic[T]): default_factory=dict, description="Extra info.", ) - _credentials: ClassVar[Optional[BaseModel]] = None _user_settings: ClassVar[Optional[BaseModel]] = None _system_settings: ClassVar[Optional[BaseModel]] = None diff --git a/openbb_platform/core/openbb_core/app/static/container.py b/openbb_platform/core/openbb_core/app/static/container.py index e2eda5ba019..19e12e73ba9 100644 --- a/openbb_platform/core/openbb_core/app/static/container.py +++ b/openbb_platform/core/openbb_core/app/static/container.py @@ -10,7 +10,6 @@ class Container: def __init__(self, command_runner: CommandRunner) -> None: self._command_runner = command_runner - OBBject._credentials = command_runner.user_settings.credentials OBBject._user_settings = command_runner.user_settings OBBject._system_settings = command_runner.system_settings diff --git a/website/content/platform/development/developer-guidelines/obbject_extensions.md b/website/content/platform/development/developer-guidelines/obbject_extensions.md index e22004a85e7..17f87cbdf40 100644 --- a/website/content/platform/development/developer-guidelines/obbject_extensions.md +++ b/website/content/platform/development/developer-guidelines/obbject_extensions.md @@ -56,7 +56,7 @@ class Example: self._obbject = obbject def hello(self): - api_key = self._obbject._credentials.some_api_key.get_secret_value() + api_key = self._obbject._user_settings.credentials.some_api_key.get_secret_value() print(f"Hello, this is my credential: {api_key}!") ```