From 99c73d3df5c551570ebe26cb9729d16f7a3728e1 Mon Sep 17 00:00:00 2001 From: Jamie Date: Sat, 24 Apr 2021 14:56:07 -0400 Subject: [PATCH] add + update readme + linting --- gamestonk_terminal/backtesting/README.md | 2 +- gamestonk_terminal/backtesting/bt_view.py | 10 +++++----- gamestonk_terminal/config_terminal.py | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/gamestonk_terminal/backtesting/README.md b/gamestonk_terminal/backtesting/README.md index 33075f34a69..6a567e027e4 100644 --- a/gamestonk_terminal/backtesting/README.md +++ b/gamestonk_terminal/backtesting/README.md @@ -44,7 +44,7 @@ usage: ema_cross [-l] [-s] [--spy] [--no_bench] [--no_short] im ### RSI This strategy goes long when the RSI is "oversold" - defined as the low parameter. It goes short when -the RSI is "overbought" - defined as the high (upper) paramter +the RSI is "overbought" - defined as the high (upper) parameter ```` usage: rsi [-u] [-l] [-p] [--spy] [--no_bench] [--no_short] ```` diff --git a/gamestonk_terminal/backtesting/bt_view.py b/gamestonk_terminal/backtesting/bt_view.py index f40a7601a3b..0a33047b31b 100644 --- a/gamestonk_terminal/backtesting/bt_view.py +++ b/gamestonk_terminal/backtesting/bt_view.py @@ -1,7 +1,7 @@ """bt view module""" __docformat__ = "numpy" import argparse -from typing import List +from typing import List, Union from datetime import datetime import matplotlib.pyplot as plt import pandas as pd @@ -13,7 +13,7 @@ from gamestonk_terminal import feature_flags as gtff from gamestonk_terminal.backtesting.bt_helper import buy_and_hold -def simple_ema(ticker: str, start_date: datetime, other_args: List[str]): +def simple_ema(ticker: str, start_date: Union[str, datetime], other_args: List[str]): parser = argparse.ArgumentParser(add_help=False, prog="ema") parser.add_argument( @@ -87,7 +87,7 @@ def simple_ema(ticker: str, start_date: datetime, other_args: List[str]): return -def ema_cross(ticker: str, start_date: datetime, other_args: List[str]): +def ema_cross(ticker: str, start_date: Union[str, datetime], other_args: List[str]): parser = argparse.ArgumentParser(add_help=False, prog="ema_cross") parser.add_argument( "-l", "--long", default=50, dest="long", type=int, help="Long EMA period" @@ -185,7 +185,7 @@ def ema_cross(ticker: str, start_date: datetime, other_args: List[str]): return -def rsi_strat(ticker: str, start_date: datetime, other_args: List[str]): +def rsi_strat(ticker: str, start_date: Union[datetime, str], other_args: List[str]): parser = argparse.ArgumentParser(add_help=False, prog="rsi_strat") parser.add_argument( "-p", @@ -240,7 +240,7 @@ def rsi_strat(ticker: str, start_date: datetime, other_args: List[str]): rsi = pd.DataFrame(ta.rsi(prices[ticker], ns_parser.periods)) rsi.columns = [ticker] - signal = 0*rsi.copy() + signal = 0 * rsi.copy() signal[rsi > ns_parser.high] = -1 signal[rsi < ns_parser.low] = 1 signal[rsi.isnull()] = 0 diff --git a/gamestonk_terminal/config_terminal.py b/gamestonk_terminal/config_terminal.py index f371d30a25f..556b088f77c 100644 --- a/gamestonk_terminal/config_terminal.py +++ b/gamestonk_terminal/config_terminal.py @@ -48,7 +48,7 @@ TRADIER_TOKEN = os.getenv("GT_TRADIER_TOKEN") or "REPLACE_ME" # Selenium Webbrowser drivers can be found at https://selenium-python.readthedocs.io/installation.html WEBDRIVER_TO_USE = "chrome" -PATH_TO_SELENIUM_DRIVER = None # Replace with "PATH" +PATH_TO_SELENIUM_DRIVER = None # Replace with "PATH" # https://coinmarketcap.com/api/ COINMARKETCAP_KEY = os.getenv("GT_CMC_API_KEY") or "REPLACE_ME"