From 9e742c0bb6bf454632708aa0f360f5327ae4d3df Mon Sep 17 00:00:00 2001 From: Colin Delahunty <72827203+colin99d@users.noreply.github.com> Date: Mon, 26 Sep 2022 20:23:50 +0200 Subject: [PATCH] Added recom error handling (#2628) --- .../stocks/technical_analysis/tradingview_model.py | 5 ++++- .../stocks/technical_analysis/tradingview_view.py | 5 +++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/openbb_terminal/stocks/technical_analysis/tradingview_model.py b/openbb_terminal/stocks/technical_analysis/tradingview_model.py index 48d28bd3295..11a8796518d 100644 --- a/openbb_terminal/stocks/technical_analysis/tradingview_model.py +++ b/openbb_terminal/stocks/technical_analysis/tradingview_model.py @@ -52,7 +52,10 @@ def get_tradingview_recommendation( if not exchange: s_req = f"https://www.alphavantage.co/query?function=OVERVIEW&symbol={symbol}&apikey={cfg.API_KEY_ALPHAVANTAGE}" result = requests.get(s_req, stream=True) - exchange = result.json()["Exchange"] + data = result.json() + if not data: + return pd.DataFrame() + exchange = data["Exchange"] if interval: intervals = [interval] diff --git a/openbb_terminal/stocks/technical_analysis/tradingview_view.py b/openbb_terminal/stocks/technical_analysis/tradingview_view.py index 79511b7dfed..94b98ea8fd0 100644 --- a/openbb_terminal/stocks/technical_analysis/tradingview_view.py +++ b/openbb_terminal/stocks/technical_analysis/tradingview_view.py @@ -7,6 +7,7 @@ import os from openbb_terminal.decorators import log_start_end from openbb_terminal.helper_funcs import export_data, print_rich_table from openbb_terminal.stocks.technical_analysis import tradingview_model +from openbb_terminal.rich_config import console logger = logging.getLogger(__name__) @@ -39,6 +40,10 @@ def print_recommendation( symbol, screener, exchange, interval ) + if recom.empty: + console.print("[red]The API did not return any recommendations.[/red]\n") + return + export_data( export, os.path.dirname(os.path.abspath(__file__)),