From a06ec394098fac14d27b2576db63a94a64c000c2 Mon Sep 17 00:00:00 2001 From: Diogo Sousa Date: Fri, 21 Jul 2023 14:11:59 +0100 Subject: [PATCH] rename method and add todo --- openbb_sdk/sdk/core/openbb_core/app/provider_interface.py | 8 ++++---- openbb_sdk/sdk/core/openbb_core/app/query.py | 4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py b/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py index 175db554730..37acf017957 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py +++ b/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py @@ -69,8 +69,8 @@ class ProviderInterface: Methods ------- - get_registry : ProviderRegistry - Get provider registry + build_registry : ProviderRegistry + Build provider registry """ def __init__(self) -> None: @@ -137,8 +137,8 @@ class ProviderInterface: """List of model names.""" return list(self.__map.keys()) - def get_registry(self) -> ProviderRegistry: - """Get provider registry.""" + def build_registry(self) -> ProviderRegistry: + """Build provider registry.""" return build_provider_registry(extensions_dict__) @staticmethod diff --git a/openbb_sdk/sdk/core/openbb_core/app/query.py b/openbb_sdk/sdk/core/openbb_core/app/query.py index 557372b40d8..154f26299a3 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/query.py +++ b/openbb_sdk/sdk/core/openbb_core/app/query.py @@ -69,7 +69,9 @@ class Query: def execute(self) -> BaseModel: """Execute the query.""" - registry = get_provider_interface().get_registry() + + # TODO: Understand if we really need to create the registry in every call + registry = get_provider_interface().build_registry() creds = self.cc.user_settings.credentials.dict() query_params = self.to_query_params(self.standard_params)