From ba1068ee47b335b5ac86898a4d67a8f70f654bf3 Mon Sep 17 00:00:00 2001 From: James Simmons <53658028+simmonsj330@users.noreply.github.com> Date: Tue, 1 Nov 2022 03:21:37 -0400 Subject: [PATCH] Fixing 6 crypto bugs (#3228) * fixing 6 crypto bugs * fixing filter stuff Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com> --- .../cryptocurrency/due_diligence/dd_controller.py | 2 +- openbb_terminal/cryptocurrency/nft/nft_controller.py | 2 -- .../cryptocurrency/onchain/onchain_controller.py | 4 ++-- .../cryptocurrency/overview/overview_controller.py | 6 +++--- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/openbb_terminal/cryptocurrency/due_diligence/dd_controller.py b/openbb_terminal/cryptocurrency/due_diligence/dd_controller.py index 5bb79f85119..75fa7425048 100644 --- a/openbb_terminal/cryptocurrency/due_diligence/dd_controller.py +++ b/openbb_terminal/cryptocurrency/due_diligence/dd_controller.py @@ -1056,7 +1056,7 @@ class DueDiligenceController(CryptoBaseController): parser.add_argument( "--descend", - action="store_false", + action="store_true", help="Flag to sort in descending order (lowest first)", dest="descend", default=False, diff --git a/openbb_terminal/cryptocurrency/nft/nft_controller.py b/openbb_terminal/cryptocurrency/nft/nft_controller.py index 8c2fdaab05c..bea640f6444 100644 --- a/openbb_terminal/cryptocurrency/nft/nft_controller.py +++ b/openbb_terminal/cryptocurrency/nft/nft_controller.py @@ -51,8 +51,6 @@ class NFTController(BaseController): choices["stats"] = { "--slug": None, "-s": None, - "--limit": {str(c): {} for c in range(1, 100)}, - "-l": "--limit", } choices["collections"] = { "--fp": {}, diff --git a/openbb_terminal/cryptocurrency/onchain/onchain_controller.py b/openbb_terminal/cryptocurrency/onchain/onchain_controller.py index ed74bd76ca5..9a93e6ecfcd 100644 --- a/openbb_terminal/cryptocurrency/onchain/onchain_controller.py +++ b/openbb_terminal/cryptocurrency/onchain/onchain_controller.py @@ -1190,7 +1190,7 @@ class OnchainController(BaseController): parser.add_argument( "--descend", - action="store_false", + action="store_true", help="Flag to sort in descending order (lowest first)", dest="descend", default=False, @@ -1343,7 +1343,7 @@ class OnchainController(BaseController): parser.add_argument( "--descend", - action="store_false", + action="store_true", help="Flag to sort in descending order (lowest first)", dest="descend", default=False, diff --git a/openbb_terminal/cryptocurrency/overview/overview_controller.py b/openbb_terminal/cryptocurrency/overview/overview_controller.py index 6f0144f1b6e..38902aeab7f 100644 --- a/openbb_terminal/cryptocurrency/overview/overview_controller.py +++ b/openbb_terminal/cryptocurrency/overview/overview_controller.py @@ -170,7 +170,7 @@ class OverviewController(BaseController): "-l": "--limit", "--descend": {}, } - choices["derivates"] = { + choices["derivatives"] = { "--sort": {c: {} for c in pycoingecko_model.DERIVATIVES_FILTERS}, "-s": "--sort", "--limit": {str(c): {} for c in range(1, 100)}, @@ -1129,10 +1129,10 @@ class OverviewController(BaseController): parser.add_argument( "--descend", - action="store_false", + action="store_true", help="Flag to sort in descending order (lowest first)", dest="descend", - default=True, + default=False, ) ns_parser = self.parse_known_args_and_warn(