diff --git a/openbb_extensions/qa/openbb_qa/qa_router.py b/openbb_extensions/qa/openbb_qa/qa_router.py index 590cd2cedd3..4678b602f49 100644 --- a/openbb_extensions/qa/openbb_qa/qa_router.py +++ b/openbb_extensions/qa/openbb_qa/qa_router.py @@ -1,7 +1,12 @@ from typing import List, Literal import numpy as np -from openbb_sdk_core.app.utils import basemodel_to_df, df_to_basemodel, get_target_column, get_target_columns +from openbb_sdk_core.app.utils import ( + basemodel_to_df, + df_to_basemodel, + get_target_column, + get_target_columns, +) import pandas as pd import pandas_ta as ta import statsmodels.api as sm diff --git a/openbb_extensions/ta/openbb_ta/ta_router.py b/openbb_extensions/ta/openbb_ta/ta_router.py index 52abe645c4e..cbedcfe76d4 100644 --- a/openbb_extensions/ta/openbb_ta/ta_router.py +++ b/openbb_extensions/ta/openbb_ta/ta_router.py @@ -1,5 +1,10 @@ from typing import List, Literal, Optional -from openbb_sdk_core.app.utils import basemodel_to_df, df_to_basemodel, get_target_column, get_target_columns +from openbb_sdk_core.app.utils import ( + basemodel_to_df, + df_to_basemodel, + get_target_column, + get_target_columns, +) import pandas as pd from builtin_extensions.common.ta import ta_helpers diff --git a/openbb_providers/builtin_providers/fmp/company_profile.py b/openbb_providers/builtin_providers/fmp/company_profile.py index a8279f3d75a..f1fabc31f99 100644 --- a/openbb_providers/builtin_providers/fmp/company_profile.py +++ b/openbb_providers/builtin_providers/fmp/company_profile.py @@ -32,6 +32,7 @@ class FMPCompanyOverviewQueryParams(CompanyOverviewQueryParams): The symbol of the company. """ + class FMPCompanyOverviewData(Data): symbol: str price: float diff --git a/openbb_providers/builtin_providers/fmp/crypto_price.py b/openbb_providers/builtin_providers/fmp/crypto_price.py index a9501c6fa6a..05a487b840b 100644 --- a/openbb_providers/builtin_providers/fmp/crypto_price.py +++ b/openbb_providers/builtin_providers/fmp/crypto_price.py @@ -41,7 +41,6 @@ class FMPCryptoPriceQueryParams(QueryParams): The interval of the data. """ - symbol: str = Field(min_length=1) interval: Interval = Field(default=Interval.onehour) diff --git a/openbb_providers/builtin_providers/fmp/stock_insider_trading.py b/openbb_providers/builtin_providers/fmp/stock_insider_trading.py index cc38dd7d96c..43368fbc09c 100644 --- a/openbb_providers/builtin_providers/fmp/stock_insider_trading.py +++ b/openbb_providers/builtin_providers/fmp/stock_insider_trading.py @@ -38,8 +38,6 @@ class FMPStockInsiderTradingQueryParams(StockInsiderTradingQueryParams): """ - - class FMPStockInsiderTradingData(StockInsiderTradingData): """FMP Stock Insider Trading data.""" diff --git a/openbb_providers/builtin_providers/fmp/stock_ownership.py b/openbb_providers/builtin_providers/fmp/stock_ownership.py index 634a0533dd4..f3af2cac8fd 100644 --- a/openbb_providers/builtin_providers/fmp/stock_ownership.py +++ b/openbb_providers/builtin_providers/fmp/stock_ownership.py @@ -31,8 +31,6 @@ class FMPStockOwnershipQueryParams(StockOwnershipQueryParams): """ - - class FMPStockOwnershipData(StockOwnershipData): """FMP Stock Ownership data.""" diff --git a/openbb_providers/builtin_providers/polygon/major_indices_eod.py b/openbb_providers/builtin_providers/polygon/major_indices_eod.py index 797d428aa70..f83a8446256 100644 --- a/openbb_providers/builtin_providers/polygon/major_indices_eod.py +++ b/openbb_providers/builtin_providers/polygon/major_indices_eod.py @@ -43,8 +43,6 @@ class PolygonMajorIndicesEODQueryParams(BaseStockQueryParams): """ - - class PolygonMajorIndicesEODData(BaseStockData): """Polygon major indices end of day data.""" diff --git a/openbb_providers/builtin_providers/polygon/major_indices_price.py b/openbb_providers/builtin_providers/polygon/major_indices_price.py index 02fd4fdeede..371758729d0 100644 --- a/openbb_providers/builtin_providers/polygon/major_indices_price.py +++ b/openbb_providers/builtin_providers/polygon/major_indices_price.py @@ -43,8 +43,6 @@ class PolygonMajorIndicesPriceQueryParams(BaseStockQueryParams): """ - - class PolygonMajorIndicesPriceData(BaseStockData): """Polygon major indices price data.""" diff --git a/openbb_sdk/openbb_sdk_core/openbb_sdk_core/app/command_runner.py b/openbb_sdk/openbb_sdk_core/openbb_sdk_core/app/command_runner.py index c1dafc3a514..988f1848875 100644 --- a/openbb_sdk/openbb_sdk_core/openbb_sdk_core/app/command_runner.py +++ b/openbb_sdk/openbb_sdk_core/openbb_sdk_core/app/command_runner.py @@ -108,7 +108,7 @@ class ParametersBuilder: ) if journal_entry and journal_entry.journal_id == journal.id: - kwargs[parameter_name] = journal_entry.output.item + kwargs[parameter_name] = journal_entry.output.results else: raise AttributeError( f"Cannot find JournalEntry for the JournalQuery: {journal_query}.\n" diff --git a/openbb_sdk/openbb_sdk_core/openbb_sdk_core/app/utils.py b/openbb_sdk/openbb_sdk_core/openbb_sdk_core/app/utils.py index 791a949327c..73590179c96 100644 --- a/openbb_sdk/openbb_sdk_core/openbb_sdk_core/app/utils.py +++ b/openbb_sdk/openbb_sdk_core/openbb_sdk_core/app/utils.py @@ -25,8 +25,10 @@ def df_to_basemodel( # TODO: Move utils in common used in ta and qa to here + def get_target_column(*args, **kwargs): raise NotImplementedError + def get_target_columns(*args, **kwargs): raise NotImplementedError