From ca6265d9cfad3ed4044246afecf842e8b4ffd369 Mon Sep 17 00:00:00 2001 From: Artem Veremey Date: Sun, 28 Feb 2021 20:42:59 -0800 Subject: [PATCH] More pylint cleanups --- .pylintrc | 2 +- .../due_diligence/business_insider_api.py | 15 +++++++++------ .../financial_modeling_prep_api.py | 3 ++- .../due_diligence/finviz_api.py | 9 ++++++--- .../due_diligence/market_watch_api.py | 10 ++++++---- .../due_diligence/quandl_api.py | 19 ++++++++++--------- .../due_diligence/reddit_api.py | 4 +++- .../fundamental_analysis/market_watch_api.py | 18 ++++++++++++------ 8 files changed, 49 insertions(+), 31 deletions(-) diff --git a/.pylintrc b/.pylintrc index a8089202b5c..5ca10d665e6 100755 --- a/.pylintrc +++ b/.pylintrc @@ -54,7 +54,7 @@ confidence= # disable=import-error,print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,import-star-module-level,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call # disable=too-many-instance-attributes,len-as-condition,too-few-public-methods,anomalous-backslash-in-string,no-else-return,simplifiable-if-statement,too-many-arguments,duplicate-code,no-name-in-module,no-member,print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,import-star-module-level,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call,import-error,missing-docstring,invalid-name,bad-whitespace,consider-using-enumerate,unexpected-keyword-arg -disable=useless-return,missing-docstring,invalid-name,import-error,bad-continuation,broad-except +disable=useless-return,missing-docstring,invalid-name,import-error,bad-continuation,broad-except,unnecessary-lambda # Enable the message, report, category or checker with the given id(s). You can # either give multiple identifier separated by comma (,) or put this option diff --git a/gamestonk_terminal/due_diligence/business_insider_api.py b/gamestonk_terminal/due_diligence/business_insider_api.py index f97ec4b9b46..6a0cb9e4c5d 100644 --- a/gamestonk_terminal/due_diligence/business_insider_api.py +++ b/gamestonk_terminal/due_diligence/business_insider_api.py @@ -65,7 +65,7 @@ def price_target_from_analysts(l_args, df_stock, s_ticker, s_start, s_interval): ["DateLabel", "Company", "InternalRating", "PriceTarget"] ] df_analyst_data.columns = ["Date", "Company", "Rating", "Price Target"] - df_analyst_data + # df_analyst_data df_analyst_data["Rating"].replace( {"gut": "BUY", "neutral": "HOLD", "schlecht": "SELL"}, inplace=True ) @@ -109,7 +109,8 @@ def price_target_from_analysts(l_args, df_stock, s_ticker, s_start, s_interval): ) print("") - except: + except Exception as e: + print(e) print("") return @@ -122,7 +123,7 @@ def estimates(l_args, s_ticker): ) try: - (ns_parser, l_unknown_args) = parser.parse_known_args(l_args) + (_, l_unknown_args) = parser.parse_known_args(l_args) if l_unknown_args: print(f"The following args couldn't be interpreted: {l_unknown_args}\n") @@ -269,7 +270,8 @@ def estimates(l_args, s_ticker): ) print("") - except: + except Exception as e: + print(e) print("") return @@ -339,7 +341,7 @@ def insider_activity(l_args, df_stock, s_ticker, s_start, s_interval): if s_start: df_insider = df_insider[s_start:] - pfig, ax = plt.subplots() + _, ax = plt.subplots() if s_interval == "1440min": plt.plot(df_stock.index, df_stock["5. adjusted close"].values, lw=3) @@ -447,6 +449,7 @@ def insider_activity(l_args, df_stock, s_ticker, s_start, s_interval): ) print("") - except: + except Exception as e: + print(e) print("") return diff --git a/gamestonk_terminal/due_diligence/financial_modeling_prep_api.py b/gamestonk_terminal/due_diligence/financial_modeling_prep_api.py index 4046d98fe23..b4539ea273d 100644 --- a/gamestonk_terminal/due_diligence/financial_modeling_prep_api.py +++ b/gamestonk_terminal/due_diligence/financial_modeling_prep_api.py @@ -25,6 +25,7 @@ def rating(l_args, s_ticker): print("") - except: + except Exception as e: + print(e) print("") return diff --git a/gamestonk_terminal/due_diligence/finviz_api.py b/gamestonk_terminal/due_diligence/finviz_api.py index 703334b2378..b8dd1da5052 100644 --- a/gamestonk_terminal/due_diligence/finviz_api.py +++ b/gamestonk_terminal/due_diligence/finviz_api.py @@ -49,7 +49,8 @@ def insider(l_args, s_ticker): print("") - except: + except Exception as e: + print(e) print("") return @@ -92,7 +93,8 @@ def news(l_args, s_ticker): print("") - except: + except Exception as e: + print(e) print("") return @@ -120,6 +122,7 @@ def analyst(l_args, s_ticker): print(df_fa) print("") - except: + except Exception as e: + print(e) print("") return diff --git a/gamestonk_terminal/due_diligence/market_watch_api.py b/gamestonk_terminal/due_diligence/market_watch_api.py index a9a9e5cdad0..24a665aa362 100644 --- a/gamestonk_terminal/due_diligence/market_watch_api.py +++ b/gamestonk_terminal/due_diligence/market_watch_api.py @@ -1,7 +1,7 @@ import argparse +import requests import pandas as pd from bs4 import BeautifulSoup -import requests import numpy as np from gamestonk_terminal.helper_funcs import ( check_positive, @@ -47,7 +47,7 @@ def sec_fillings(l_args, s_ticker): "lxml", ) - a_financials_header = list() + # a_financials_header = list() b_ready_to_process_info = False soup_financials = text_soup_financials.findAll("tr", {"class": "table__row"}) for financials_info in soup_financials: @@ -76,7 +76,8 @@ def sec_fillings(l_args, s_ticker): print(df_financials.head(n=ns_parser.n_num).to_string()) print("") - except: + except Exception as e: + print(e) print("") return @@ -307,6 +308,7 @@ def sean_seah_warnings(l_args, s_ticker): print("") - except: + except Exception as e: + print(e) print("") return diff --git a/gamestonk_terminal/due_diligence/quandl_api.py b/gamestonk_terminal/due_diligence/quandl_api.py index 80ae60092f6..22463024dbf 100644 --- a/gamestonk_terminal/due_diligence/quandl_api.py +++ b/gamestonk_terminal/due_diligence/quandl_api.py @@ -1,19 +1,19 @@ -import quandl -from datetime import datetime -from gamestonk_terminal import config_terminal as cfg import argparse +import quandl from matplotlib import pyplot as plt -import numpy as np import matplotlib.ticker as ticker import pandas as pd -from gamestonk_terminal.helper_funcs import * +from gamestonk_terminal.helper_funcs import check_positive, long_number_format +from gamestonk_terminal import config_terminal as cfg # -------------------------------------------------------- SHORT_INTEREST -------------------------------------------------------- def short_interest(l_args, s_ticker, s_start): parser = argparse.ArgumentParser( prog="short", - description="""Plots the short interest of a stock. This corresponds to the number of shares that - have been sold short but have not yet been covered or closed out. Either NASDAQ or NYSE [Source: Quandl]""", + description=""" + Plots the short interest of a stock. This corresponds to the number of shares that + have been sold short but have not yet been covered or closed out. Either NASDAQ or NYSE [Source: Quandl] + """, ) parser.add_argument( @@ -60,7 +60,7 @@ def short_interest(l_args, s_ticker, s_start): 2, ) - fig, ax = plt.subplots() + _, ax = plt.subplots() ax.bar( df_short_interest.index, df_short_interest["Short Volume"], 0.3, color="r" ) @@ -111,6 +111,7 @@ def short_interest(l_args, s_ticker, s_start): plt.show() - except: + except Exception as e: + print(e) print("") return diff --git a/gamestonk_terminal/due_diligence/reddit_api.py b/gamestonk_terminal/due_diligence/reddit_api.py index ca0ebbed56e..02bc8c20489 100644 --- a/gamestonk_terminal/due_diligence/reddit_api.py +++ b/gamestonk_terminal/due_diligence/reddit_api.py @@ -169,7 +169,9 @@ def due_diligence(l_args, s_ticker): f"{('No more posts with specified requirements found.', '')[n_flair_posts_found > ns_parser.n_limit-1]}" ) # Create df with found data. Useful for saving all info in excel file. - # df_submissions = pd.DataFrame.from_dict(d_submission, orient='index', columns=list(d_submission[next(iter(d_submission.keys()))].keys())) + # df_submissions = pd.DataFrame.from_dict( + # d_submission, orient='index', columns=list(d_submission[next(iter(d_submission.keys()))].keys()) + # ) # df_submissions.sort_values(by=['created_utc'], inplace=True, ascending=True) except Exception as e: diff --git a/gamestonk_terminal/fundamental_analysis/market_watch_api.py b/gamestonk_terminal/fundamental_analysis/market_watch_api.py index 5348bd96113..b52a05cdce1 100644 --- a/gamestonk_terminal/fundamental_analysis/market_watch_api.py +++ b/gamestonk_terminal/fundamental_analysis/market_watch_api.py @@ -79,7 +79,8 @@ def income(l_args, s_ticker): print(df_financials.to_string(index=False)) print("") - except: + except Exception as e: + print(e) print("") return @@ -161,7 +162,8 @@ def assets(l_args, s_ticker): print(df_financials.iloc[:33].to_string()) print("") - except: + except Exception as e: + print(e) print("") return @@ -247,7 +249,8 @@ def liabilities(l_args, s_ticker): print(df_financials.iloc[34:].to_string()) print("") - except: + except Exception as e: + print(e) print("") return @@ -329,7 +332,8 @@ def operating(l_args, s_ticker): print(df_financials.iloc[:16].to_string()) print("") - except: + except Exception as e: + print(e) print("") return @@ -411,7 +415,8 @@ def investing(l_args, s_ticker): print(df_financials.iloc[17:30].to_string()) print("") - except: + except Exception as e: + print(e) print("") return @@ -496,6 +501,7 @@ def financing(l_args, s_ticker): print(df_financials.iloc[31:].to_string()) print("") - except: + except Exception as e: + print(e) print("") return