From d89aa1415a299e8eac689e3d7ca522b2b54bd5d0 Mon Sep 17 00:00:00 2001 From: Diogo Sousa Date: Thu, 27 Jul 2023 19:06:01 +0100 Subject: [PATCH] add comment --- openbb_sdk/sdk/core/openbb_core/app/provider_interface.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py b/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py index b464e2fd5d1..36e3bb4dad5 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py +++ b/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py @@ -213,6 +213,13 @@ class ProviderInterface: else: for name, field in model_details["QueryParams"].items(): if name not in providers["openbb"]["QueryParams"]: + + + # TODO: We should consider forcing extra_params to + # be Optional here, in case someone forgets to add + # it on the model. Otherwise the Validation layer + # will block running the command. + incoming = cls._create_field( name, field, provider_name, query=True )