From eb2b17cfeb5e1fd448b1d6533b62810e9a8b4577 Mon Sep 17 00:00:00 2001 From: Pratyush Shukla Date: Thu, 27 Jul 2023 23:29:58 +0530 Subject: [PATCH] date Field and optional dates params in `CryptoEOD` for fmp and polygon --- .../providers/fmp/openbb_fmp/models/crypto_eod.py | 12 +++++------- .../polygon/openbb_polygon/models/crypto_eod.py | 1 + 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/crypto_eod.py b/openbb_sdk/providers/fmp/openbb_fmp/models/crypto_eod.py index 5f172aa9c4f..9708c3b22bb 100644 --- a/openbb_sdk/providers/fmp/openbb_fmp/models/crypto_eod.py +++ b/openbb_sdk/providers/fmp/openbb_fmp/models/crypto_eod.py @@ -1,7 +1,7 @@ """FMP Cryptos end of day fetcher.""" -from datetime import datetime, timedelta +from datetime import datetime from typing import Dict, List, Optional from openbb_provider.abstract.fetcher import Fetcher @@ -65,13 +65,10 @@ class FMPCryptoEODFetcher( def transform_query( query: CryptoEODQueryParams, extra_params: Optional[Dict] = None ) -> FMPCryptoEODQueryParams: - now = datetime.now().date() - start_date = query.start_date or (now - timedelta(days=7)) - end_date = query.end_date or now return FMPCryptoEODQueryParams( symbol=query.symbol, - start_date=start_date, - end_date=end_date, + start_date=query.start_date, + end_date=query.end_date, **extra_params or {}, ) @@ -85,7 +82,8 @@ class FMPCryptoEODFetcher( base_url = "https://financialmodelingprep.com/api/v3/" query_str = get_querystring(query.dict(), ["symbol"]) query_str = query_str.replace("start_date", "from").replace("end_date", "to") - url = f"{base_url}historical-price-full/{query.symbol}?{query_str}&apikey={api_key}" + url = f"{base_url}historical-price-full/crypto/{query.symbol}?{query_str}&apikey={api_key}" + return get_data_many(url, FMPCryptoEODData, "historical") @staticmethod diff --git a/openbb_sdk/providers/polygon/openbb_polygon/models/crypto_eod.py b/openbb_sdk/providers/polygon/openbb_polygon/models/crypto_eod.py index a80912cbe29..10626a4d692 100644 --- a/openbb_sdk/providers/polygon/openbb_polygon/models/crypto_eod.py +++ b/openbb_sdk/providers/polygon/openbb_polygon/models/crypto_eod.py @@ -46,6 +46,7 @@ class PolygonCryptoEODData(CryptoEODData): "volume": "v", } + t: datetime = Field(description="The timestamp of the data.") n: PositiveInt = Field( description="The number of transactions for the symbol in the time period." )