From ecf16ca58b913e677ebdce2390034860deb4a996 Mon Sep 17 00:00:00 2001 From: tehcoderer Date: Tue, 8 Aug 2023 10:09:24 -0400 Subject: [PATCH] merge --- .../providers/benzinga/openbb_benzinga/utils/helpers.py | 2 +- openbb_sdk/providers/fmp/openbb_fmp/models/stock_quote.py | 7 ++++--- openbb_sdk/sdk/core/openbb_core/app/provider_interface.py | 6 +----- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/openbb_sdk/providers/benzinga/openbb_benzinga/utils/helpers.py b/openbb_sdk/providers/benzinga/openbb_benzinga/utils/helpers.py index a6910311f61..82523b28025 100644 --- a/openbb_sdk/providers/benzinga/openbb_benzinga/utils/helpers.py +++ b/openbb_sdk/providers/benzinga/openbb_benzinga/utils/helpers.py @@ -5,7 +5,7 @@ from datetime import datetime from typing import Any, Dict, List, Optional from openbb_provider import helpers -from openbb_provider.models.stock_news import StockNewsData +from openbb_provider.standard_models.stock_news import StockNewsData from pydantic import BaseModel, Field diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/stock_quote.py b/openbb_sdk/providers/fmp/openbb_fmp/models/stock_quote.py index f216cc764cd..9eb911dddbb 100644 --- a/openbb_sdk/providers/fmp/openbb_fmp/models/stock_quote.py +++ b/openbb_sdk/providers/fmp/openbb_fmp/models/stock_quote.py @@ -5,7 +5,10 @@ from datetime import datetime from typing import Any, Dict, List, Optional from openbb_provider.abstract.fetcher import Fetcher -from openbb_provider.models.stock_quote import StockQuoteData, StockQuoteQueryParams +from openbb_provider.standard_models.stock_quote import ( + StockQuoteData, + StockQuoteQueryParams, +) from pydantic import validator from openbb_fmp.utils.helpers import get_data_many, get_querystring @@ -45,8 +48,6 @@ class FMPStockQuoteData(StockQuoteData): class FMPStockQuoteFetcher( Fetcher[ - StockQuoteQueryParams, - List[StockQuoteData], FMPStockQuoteQueryParams, List[FMPStockQuoteData], ] diff --git a/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py b/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py index 0b22f6160bb..42049eb387a 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py +++ b/openbb_sdk/sdk/core/openbb_core/app/provider_interface.py @@ -435,16 +435,12 @@ class ProviderInterface: class Config(BaseConfig): extra = Extra.allow - ReturnModel = create_model( # type: ignore + result[model_name] = create_model( # type: ignore model_name, __config__=Config, **fields_dict, # type: ignore ) - # TODO: If we want to support multiple return schemas, we need - # to change this `List` to the schema type - result[model_name] = List[ReturnModel] # type: ignore - return result def _get_provider_literal(self, available_providers: List[str]) -> type: