From ee95fc4eebeb0d8e2ad6550c0f770d73be3b3b3b Mon Sep 17 00:00:00 2001 From: Pratyush Shukla Date: Sat, 15 Jul 2023 22:12:12 +0530 Subject: [PATCH] cleanup in `stocks.ca.get` --- openbb_sdk/providers/fmp/openbb_fmp/stock_peers.py | 8 +------- .../sdk/provider/openbb_provider/models/stock_peers.py | 5 ++--- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/openbb_sdk/providers/fmp/openbb_fmp/stock_peers.py b/openbb_sdk/providers/fmp/openbb_fmp/stock_peers.py index ae2e426d436..0dc70b991bb 100644 --- a/openbb_sdk/providers/fmp/openbb_fmp/stock_peers.py +++ b/openbb_sdk/providers/fmp/openbb_fmp/stock_peers.py @@ -9,9 +9,6 @@ from openbb_provider.helpers import data_transformer # IMPORT INTERNAL from openbb_provider.models.stock_peers import StockPeersData, StockPeersQueryParams -# IMPORT THIRD-PARTY -from pydantic import Field - from .helpers import create_url, get_data_many # FMP SPECIFIC FUNCTIONALITY CURRENTLY @@ -32,9 +29,6 @@ class FMPStockPeersQueryParams(StockPeersQueryParams): class FMPStockPeersData(StockPeersData): """FMP Stock Peers data.""" - symbol: str = Field(min_length=1) - peers_list: List[str] = Field(alias="peersList") - class FMPStockPeersFetcher( Fetcher[ @@ -55,7 +49,7 @@ class FMPStockPeersFetcher( query: FMPStockPeersQueryParams, api_key: str ) -> List[FMPStockPeersData]: url = create_url(4, "stock_peers", api_key, query) - return get_data_many(url, FMPStockPeersData, "peersList") + return get_data_many(url, FMPStockPeersData) @staticmethod def transform_data(data: List[FMPStockPeersData]) -> List[StockPeersData]: diff --git a/openbb_sdk/sdk/provider/openbb_provider/models/stock_peers.py b/openbb_sdk/sdk/provider/openbb_provider/models/stock_peers.py index 3e22feca975..862cf668252 100644 --- a/openbb_sdk/sdk/provider/openbb_provider/models/stock_peers.py +++ b/openbb_sdk/sdk/provider/openbb_provider/models/stock_peers.py @@ -1,7 +1,6 @@ """Stock Peers data model.""" - -from typing import List +from typing import List, Optional from openbb_provider.abstract.data import Data, QueryParams from openbb_provider.models.base import BaseSymbol @@ -29,4 +28,4 @@ class StockPeersData(Data): """ symbol: str - peers_list: List[str] + peers_list: Optional[List[str]]