From eeb9cda6f6981ec786fd3a996eb6a4a2e70b71bf Mon Sep 17 00:00:00 2001 From: hjoaquim Date: Mon, 11 Mar 2024 11:34:51 +0000 Subject: [PATCH] reverting treating models as props --- argparse_translator/argparse_class_processor.py | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/argparse_translator/argparse_class_processor.py b/argparse_translator/argparse_class_processor.py index 492fdcf9e1b..d6b6a2021a7 100644 --- a/argparse_translator/argparse_class_processor.py +++ b/argparse_translator/argparse_class_processor.py @@ -1,5 +1,5 @@ import inspect -from typing import Callable, Dict, Type +from typing import Dict, Type # TODO: this needs to be done differently from openbb_core.app.static.container import Container @@ -69,11 +69,6 @@ class ArgparseClassProcessor: ) -> Dict[str, ArgparseTranslator]: methods = {} - def make_prop_as_callable(name): - # This is necessary because lambda functions capture variables by reference, - # not by value, leading to all lambdas using the last value of name from the loop. - return lambda: getattr(target, name) - for name, member in inspect.getmembers(target): if name.startswith("__") or name.startswith("_"): continue @@ -82,13 +77,6 @@ class ArgparseClassProcessor: methods[f"{class_name}_{name}"] = ArgparseTranslator( func=member, add_help=add_help ) - if isinstance(getattr(target.__class__, name, None), property): - prop_as_callable: Callable = make_prop_as_callable(name) - prop_as_callable.__doc__ = getattr(target.__class__, name).__doc__ - prop_as_callable.__name__ = name - methods[name] = ArgparseTranslator( - func=prop_as_callable, add_help=add_help - ) elif isinstance(member, Container): methods = { **methods,