From fa93242f67201b7c26c95a74a7c38e2fa0de07e1 Mon Sep 17 00:00:00 2001 From: Diogo Sousa Date: Tue, 22 Aug 2023 14:30:33 +0100 Subject: [PATCH] remove run_in_isolation: cannot pickle nested classes --- openbb_sdk/sdk/core/README.md | 1 - .../sdk/core/openbb_core/app/command_runner.py | 16 +--------------- .../openbb_core/app/model/system_settings.py | 4 ---- .../openbb_core/app/service/system_service.py | 1 - 4 files changed, 1 insertion(+), 21 deletions(-) diff --git a/openbb_sdk/sdk/core/README.md b/openbb_sdk/sdk/core/README.md index 4886c8cf2dd..2ed54f39b33 100644 --- a/openbb_sdk/sdk/core/README.md +++ b/openbb_sdk/sdk/core/README.md @@ -144,7 +144,6 @@ Update your system settings by modifying the `.openbb_sdk/system_settings.json` ```{json} { - "run_in_isolation": null, "dbms_uri": null } ``` diff --git a/openbb_sdk/sdk/core/openbb_core/app/command_runner.py b/openbb_sdk/sdk/core/openbb_core/app/command_runner.py index 4a4b583952b..e62327a59e2 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/command_runner.py +++ b/openbb_sdk/sdk/core/openbb_core/app/command_runner.py @@ -1,4 +1,3 @@ -import multiprocessing import warnings from contextlib import nullcontext from copy import deepcopy @@ -189,16 +188,6 @@ class StaticCommandRunner: logging_manager: LoggingManager = LoggingManager() charting_manager: ChartingManager = ChartingManager() - @staticmethod - def __run_in_isolation(func, args=None, kwargs=None) -> OBBject: - args = args or () - kwargs = kwargs or {} - - with multiprocessing.Pool(processes=1) as pool: - result = pool.apply(func=func, args=args, kwds=kwargs) - - return result - @classmethod def __command( cls, system_settings: SystemSettings, func: Callable, kwargs: Dict[str, Any] @@ -211,10 +200,7 @@ class StaticCommandRunner: ) with context_manager as warning_list: - if system_settings.run_in_isolation: - obbject = cls.__run_in_isolation(func=func, kwargs=kwargs) - else: - obbject = func(**kwargs) + obbject = func(**kwargs) obbject.provider = getattr( kwargs.get("provider_choices", None), "provider", None diff --git a/openbb_sdk/sdk/core/openbb_core/app/model/system_settings.py b/openbb_sdk/sdk/core/openbb_core/app/model/system_settings.py index 5b18692b03f..95126730b00 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/model/system_settings.py +++ b/openbb_sdk/sdk/core/openbb_core/app/model/system_settings.py @@ -47,10 +47,6 @@ class SystemSettings(Tagged): test_mode: bool = False debug_mode: bool = False headless: bool = False - run_in_isolation: bool = FrozenField( - default=False, - description="Whether or not to run each command in total isolation.", - ) class Config: validate_assignment = True diff --git a/openbb_sdk/sdk/core/openbb_core/app/service/system_service.py b/openbb_sdk/sdk/core/openbb_core/app/service/system_service.py index 184e8ea6df6..b4338417f50 100644 --- a/openbb_sdk/sdk/core/openbb_core/app/service/system_service.py +++ b/openbb_sdk/sdk/core/openbb_core/app/service/system_service.py @@ -15,7 +15,6 @@ class SystemService: "test_mode", "headless", "debug_mode", - "run_in_isolation", "dbms_uri", }