Commit Graph

1989 Commits

Author SHA1 Message Date
hjoaquim
583d1632e6 added verification for windows. if start is prior to 1970, convert it to 1970-01-02 (1 day buffer in case of timezone adjustments) (#2056)
reference_1 : https://stackoverflow.com/questions/2518706/python-mktime-overflow-error
reference_2 : https://discuss.python.org/t/please-help-getting-try-except-working-for-yfinance-download/11682/6

Co-authored-by: Chavithra <chavithra@gmail.com>
2022-07-07 13:30:51 +01:00
DidierRLopes
0276784b35 Update defaults.ini (#2035)
* update defaults.ini

* fix arg

* Make arg more robust when you use ini file

* Fix tests

Co-authored-by: JerBouma <jer.bouma@gmail.com>
2022-07-07 13:39:29 +02:00
northern-64bit
89297fadc4 Adding new portfolio metrics (#2029)
* Making pa active + pa minor features

Makes pa actice and adds country to the df. The groupby command also gets percents of holding allocation. It also fixes warnings and prepares for a later pr that I'm currently working on.

* Fix linting

* black linter

* Fixes

Should fix everything

* Linting

* Making pa controller to base class standard

* Fix linting

* first metrics

* Adding calmar ratio

* Adding metrics to controller

* Linting

* Linting

* Test fixes

* Test fixes

* Adding tests

* Linting

* Restructuring added tests

* Linting

* Updating hugo website and fixing help

* Fixing commands

* Fix kelly criterion command

* Fixing tests

* Linting

* More linting

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-07 10:14:16 +02:00
Jeroen Bouma
b749d6e3c6 Improvements within the Terminal for the Documentation (#2048)
* Change about us to open_terminal_documentation

* Change the home menu to be more compact

* Make changes to menu layout and change bottom bar

* Change about command to send you to the documentation and add about to bottom bar

* Add in about choices to all menus

* Adjust wording

* Adjust the website to match terminal commands and make adjustments for common menus

* Update the website and small change to about command

* Small adjustment to about command

* Remove update command

* Add some more info about arguments

* Fix broken link

* Add pro tip

* Update keys to work well with about

* Fix some common paths

* Add back in the update command with exception if packaged application

* Remove update comment

* Fix all the things

* Make about more robust and also add in exe

* Make sure that there are actual commands and menus
2022-07-06 13:52:26 +01:00
northern-64bit
5188884105 Crypto api fixes (#1959)
* Making pa active + pa minor features

Makes pa actice and adds country to the df. The groupby command also gets percents of holding allocation. It also fixes warnings and prepares for a later pr that I'm currently working on.

* Fix linting

* black linter

* Fixes

Should fix everything

* Linting

* Making pa controller to base class standard

* Fix linting

* Refactor API to accept Crypto Symbol as an input argument

* Crypto API fixes

* Fixes

* Linting

* Linting

* More linting

* Fixes

* Tests : cryptocurrency/helper

* Tests : cryptocurrency/glassnode

* Pytest : Cryptocurrency/due_diligence

* Pytest : cryptocurrency/discovery

* Pytest : cryptocurrency/due_diligence

* Remove not a needed function argument

* Linting

* Test fixes

* Fixing mentioned fixes

* Test fixes

* Tests: cryptocurrency/defi

* Fix linting

* Final test fixes

Co-Authored-By: Chavithra <6114398+Chavithra@users.noreply.github.com>

* Fix merge

* Linting

* Fixing error

* Linting

* Removed long link

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
Co-authored-by: Minh Hoang <nminh.hoang1023@gmail.com>
Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
Co-authored-by: Chavithra PARANA <chavithra@gmail.com>
Co-authored-by: Chavithra <6114398+Chavithra@users.noreply.github.com>
2022-07-06 13:08:32 +01:00
northern-64bit
85ce998d57 Making the news command pretty with more data (#2045)
* Formatting news command

* Linting

* Linting
2022-07-05 23:31:24 +01:00
DidierRLopes
ac4820cdef Fix trading hours bringing ticker in (#2038)
* fix trading hours bringing ticker in

* fix conditions that were not accounted for

Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-05 13:22:41 +01:00
DidierRLopes
eba85a56c5 Fix sorting of candle data (#2032)
* fix sorting of candle data

* fix adjclose sorting

Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-04 11:21:55 +01:00
DidierRLopes
3d3ee96874 Remove print and fix issue with str on sia/vis (#2034)
* remove print and fix issue with str on sia/vis

* fix tests

Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-04 10:08:14 +01:00
DidierRLopes
0517135bc9 Fix volatility of crypto (#2039)
* fix volatility of crypto

* fix wrong annual value being used

Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
2022-07-04 09:22:25 +02:00
DidierRLopes
2ffaace7c3 fix documentation (#2037)
Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
2022-07-03 23:44:57 +01:00
DidierRLopes
17fc484651 fix messari spelling (#2036)
Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
2022-07-03 22:34:39 +01:00
DidierRLopes
066d347c63 replace curve brackets by square ones (#2040) 2022-07-03 21:31:04 +01:00
soggyomelette
45f0a0a049 Fixes #2018 and updates default dates in dd_controller.py (#2028)
* Fixes #2018 and updates default dates in dd_controller.py

* Fixing linting

Co-authored-by: Chavithra PARANA <chavithra@gmail.com>
2022-07-02 12:07:53 +01:00
soggyomelette
7849b5668b Adds a test for binance key as asked for in #2006 (#2026)
* Adds a test for binance key as asked for in #2006

* Update keys_controller.py

* Update keys_controller.py

* fixing linting

* fixing tests

* fixing linting

* fix tests

* fix linting

* fix linting

* fix linting

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
2022-07-02 12:06:51 +01:00
Paul Symonds
0f0e769156 Update stocks_helper.py (#2025)
* Update stocks_helper.py

When a stock is returned:

Market: CLOSEDSENIOR PLC 10p

Fixed to show:

Market: CLOSED
Company: SENIOT PLC 10p

* Update stocks_helper.py

Added logic for US if source requires .US. without this logic Datetime is printed twice.

* Update stocks_helper.py

Updated logic to fix pyLint Error.

* Update stocks_helper.py

* Update stocks_helper.py

Further testing revealed Upper and Lower case issues, if .upper() is used it throws errors.

This function uses yfinance to return info data for tickers. 

Yahoo does not have .US suffix for US stocks but other feeds may (will) have this.

Some testing gave the following:

Stock:                                                                                                                                                            │
                                                                                                                                                              
Datetime:                                                                                                                                                         
Timezone:                                                                                                                                                         
Exchange:                                                                                                                                                         
Market:                                                                                                                                                           
Currency:                                                                                                                                                         
Company:  

or:

Datetime: 2022 Jul 01 07:51
Timezone: Europe/London
Exchange: LSE
Currency: GBp
Market:   OPENSENIOR PLC 10P


or this:

Datetime: 
Datetime: 2022 Jul 01 02:44
Timezone: America/New_York
Currency: USD
Market:   CLOSED
Company:  

Final Result is this:

Datetime: 2022 Jul 01 02:51
Timezone: America/New_York
Currency: USD
Market:   CLOSED
Company:  Apple Inc.


I don't think this function is overly complex and could do with a refactor at some point.

* Update stocks_helper.py

fixed Black error

* Simplified if statement

* Reverted poetry

Co-authored-by: colin99d <colin99delahunty@gmail.com>
Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com>
2022-07-01 11:18:56 -04:00
Colin Delahunty
282132f059 Fix yf FA quarterly issue (#2017)
* Fixed issue with yf

* Added todo
2022-06-30 00:09:37 +01:00
Paul Symonds
248deed202 New Feature Financial Analysis, checks Yahoo if no data at Alpha Advantage. (#1984)
* Added code to look at Yahoo Finance Financials (Income, Balance sheet and cashflow, if tickers not found in Alpha Vantage.  Should cover all UK (only tested with .L appended to tickers).

* Added code to look at Yahoo Finance Financials (Income, Balance sheet and cashflow, if tickers not found in Alpha Vantage.  Should cover all UK (only tested with .L appended to tickers).

* change

* refactored to keep yahoo fa financials (income, cash, balance) separate.

* refactored to keep yahoo fa financials (income, cash, balance) separate.

* refactored to keep yahoo fa financials (income, cash, balance) separate.

* refactored to keep yahoo fa financials (income, cash, balance) separate (fixed dates).

* Fixed source bug

* empty commit

* fixed header date issue

* Fixed source

* fixed bugs related to no data returned

* fixed bugs related to no data returned

* fixed bugs related to no data returned

* Added yf to av when no data returned from av

* Added support for polygon statement of cash flows

* Fixed issue I created

* fixed pylint error else after return

* fixed pylint error with disable R1732

* fixed tests relating to av

* Updated polygon model and fixed tests

* fixed load GNR in fa after SNR.L in stocks

* fixed load GNR in fa after SNR.L in stocks

* Added newline to print

* Added newlines

Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com>
Co-authored-by: colin99d <colin99delahunty@gmail.com>
2022-06-29 14:02:01 -04:00
DidierRLopes
221bfce452 Improve economy menu (#1996)
* slight improvement on the reports controller

* improve economy menu

* fix tests

Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-06-29 12:49:00 +01:00
Jeroen Bouma
8324f739b6 Add in a new GIF that better demonstrates the terminal (#2010)
* Add new GiF

* Get rid of the old gif

* Add in new GIF

* Update README.md

* Update README.md
2022-06-29 11:50:02 +01:00
soggyomelette
1fe1f8714f Fix: crypto/headlines missing Legend & wrong Chart Title (#1997)
* Update stockanalysis_model.py

* Update etf_controller.py

* Fix tests and linting

* 'Fixing #1978 by switching to check_positive_float'

* 'Fixes #1977 by switching labels'

* Fixes #1992 by modifying finbrain_crypto_view.py

* 'Changed the markers to white to avoid confusion'

Co-authored-by: didierlopes.eth <dro.lopes@campus.fct.unl.pt>
Co-authored-by: JerBouma <jer.bouma@gmail.com>
2022-06-28 16:44:50 +01:00
soggyomelette
fe96ab2dd8 Fixes stock price and metrics in #1993 (#1998) 2022-06-27 20:58:54 +01:00
minhhoang1023
67e3b3be13 Add Introduction to Cryptocurrency Guide & Fix crypto/find (#1970)
* Add Introduction to Cryptocurrency

* Add images

* Finish guides

* Add images

* Fix find not working

* Add keywords

* Update top_level_menu.md
2022-06-26 23:57:51 +01:00
Sam Kerr
b40868491e Handle errors when tickers can't be loaded (#1986)
* Add error handling for when financial statements cannot be parsed

* Formatting updates

* Remove a rogue print statement

* Fix a copy paste error

* Formatting issues with Black

* Use sentinel values rather than exception based workflow

* Remove unneeded change

* Fix formatting

* Don't use exceptions for handling error

* Fix a null check case

* Add an error print string to pass tests

* Remove exception throwers

* Update docs since we don't throw this exception
2022-06-25 16:05:06 +01:00
soggyomelette
5790f0bfa9 [Bug] ta/bbands: when value contains a decimal: error: argument -s/--std: invalid check_positive value: '4.5' (#1988)
* Update stockanalysis_model.py

* Update etf_controller.py

* Fix tests and linting

* 'Fixing #1978 by switching to check_positive_float'

* 'Fixes #1977 by switching labels'

Co-authored-by: didierlopes.eth <dro.lopes@campus.fct.unl.pt>
Co-authored-by: JerBouma <jer.bouma@gmail.com>
2022-06-25 16:04:13 +01:00
montezdesousa
8f6bd9cab6 Removes command govp from crypto/defi (#1980)
* remove govp from defi menu

* rewrites help txt

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
2022-06-25 00:54:14 +01:00
minhhoang1023
7c597befe2 Unify input arguments between Terminal and Crypto API usage (#1942)
* Refactor API to accept Crypto Symbol as an input argument

* Fix tests

* Fix tests 2
2022-06-25 00:02:07 +01:00
James Simmons
2a5fbd4cd5 Fixing default view and ascending order in cglosers and cggainers (#1923)
* Fixing default view and ascending order in cglosers and cggainers

* Fixing futurewarnings error, adding test data, and changing dollar sign issue

* Adding --rewrite-expected test to pass CI

Co-authored-by: didierlopes.eth <dro.lopes@campus.fct.unl.pt>
2022-06-25 00:01:20 +01:00
soggyomelette
0b9a81b1bd [Bug] Broken ETF functionalities (#1976)
* Update stockanalysis_model.py

* Update etf_controller.py

* Fix tests and linting

Co-authored-by: didierlopes.eth <dro.lopes@campus.fct.unl.pt>
Co-authored-by: JerBouma <jer.bouma@gmail.com>
2022-06-24 23:49:54 +01:00
montezdesousa
2386bd2da2 [Bug] crypto/defi/sratio: Remove scientific notation in Chart title (#1965)
* removes sratio from choices and help

* rewrites help test txt

Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
Co-authored-by: Chavithra <chavithra@gmail.com>
2022-06-24 14:01:13 +01:00
Colin Delahunty
e3daff2161 fixed crypto load (#1981)
* fixed crypto load

* Added fix

Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
2022-06-23 14:07:27 -04:00
montezdesousa
57b61d1b2a Display the help menu whenever users move to a different menu (#1968)
* switch auto print_help on exits

* display help when home called from home directory

* change in test to expect help cmd

* change in test to expect help cmd

* sets autoexithelp flag on conftest

* supress help string print on quit

* adapt tests to expect help

* adds help on 3 tests missing

* run black

* respect literal bool type

* second attemp to respect literal bool

Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
2022-06-22 13:45:48 +01:00
James Simmons
7ea577e142 Fixing scorr and sentiment dataframe indexing bug (#1947)
* Fixing scorr and sentiment dataframe indexing bug

* Fixing type hint and did some slight refactoring

Co-authored-by: didierlopes.eth <dro.lopes@campus.fct.unl.pt>
2022-06-20 15:07:56 -05:00
montezdesousa
ac50ab0f57 changes type_string to lowercase (#1958)
Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com>
Co-authored-by: didierlopes.eth <dro.lopes@campus.fct.unl.pt>
2022-06-20 07:26:34 -04:00
James Simmons
0c60d70cb2 Fixing fails to deliver bug and resulting NaN values in dataframe bug (#1956)
* Fixing fails to deliver bug and resulting NaN values in dataframe bug

* Taking out print statement

Co-authored-by: didierlopes.eth <dro.lopes@campus.fct.unl.pt>
2022-06-20 08:48:26 +01:00
Danglewood
aa53f4967f Adds Introduction Guide to Stock Screener (#1950)
* Adds Introduction Guide to Stock Screener

Adds Introduction Guide to Stock Screener

* adds a demo routine for the Stock Screener

* Improved Discovery Menu Demo Routine

* Improves functionality of autocomplete by changing value field to use underscore instead of dash

* black

* spelling

Co-authored-by: james <jmaslek11@gmail.com>
2022-06-18 10:38:51 +02:00
montezdesousa
99dce2457a Fix crypto/defi/vaults not showing for default and -k lp (#1957)
* fix vault sort

* rewrite tests

Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com>
2022-06-17 09:15:48 -04:00
James Simmons
f9f717774a Fixed warnings bug which does not display data if there is an inf value data point (#1948)
Co-authored-by: James Maslek <jmaslek11@gmail.com>
Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com>
2022-06-17 08:47:48 -04:00
Colin Delahunty
836d529ff0 Fixes Blank Report Bug (#1954)
* Fixed blank report bug

* Removed ipynb file
2022-06-16 16:26:24 -04:00
Colin Delahunty
b0b81c4d14 Fixed risk free bug (#1953) 2022-06-16 11:02:27 -04:00
Colin Delahunty
82e38cfdc1 Fixed cntrld issue (#1952) 2022-06-16 10:13:55 -04:00
Colin Delahunty
fd81deac20 Fix show ticker issue (#1951)
* Fix show ticker issue

* Removed print

* Removed darts logs

* Black
2022-06-15 16:27:03 -04:00
Sam Kerr
497324d75f Preferred data source for a given command and help docs for any command (#1928)
* Add a feature flag loaded from . env for preferred data source

* Update the load command to use the preferred source

* Add a test

* Black syntax checker updates

* Update test syntax

* Update load command documentation

* Add a variable to read a sources file from

* Add a default sources.json file

* Add a helper function to read the source file and get the most relevant value

* Add some comments

* Remove older preferred data source file setting

* Add a default source file for data and use it if no user preference specifies a specific file

* Remove duplicate source file and old settings values

* Update the test file

* Update documentation string

* Update tests/openbb_terminal/test_settings_controller.py

* Black syntax formatting issues

* Fix a test case

* Fix a typo

* Fix Flake8 errors

* Fix Flake8 errors

* Pyupgrade syntax fixes

* Additional linter corrections

* More pylint issues

* Improve predefined default sources

* refactor parse_known_args_and_warn for documentation

* Update openbb_terminal/helper_funcs.py

* Add a feature flag loaded from . env for preferred data source

* Update the load command to use the preferred source

* Add a test

* Black syntax checker updates

* Update test syntax

* Update load command documentation

* Add a variable to read a sources file from

* Add a default sources.json file

* Add a helper function to read the source file and get the most relevant value

* Add some comments

* Remove older preferred data source file setting

* Add a default source file for data and use it if no user preference specifies a specific file

* Remove duplicate source file and old settings values

* Update the test file

* Update documentation string

* Update tests/openbb_terminal/test_settings_controller.py

* Black syntax formatting issues

* Fix a test case

* Fix a typo

* Fix Flake8 errors

* Fix Flake8 errors

* Pyupgrade syntax fixes

* Additional linter corrections

* More pylint issues

* Improve predefined default sources

* refactor parse_known_args_and_warn for documentation

* Update openbb_terminal/helper_funcs.py

* Forex controller

* Tests : Fixing `parse_known_args_and_warn` issue

* Comparison Analysis controller

* Tests : Comparison Analysis

* Tests : Stocks/DarkPoolShorts + Stocks/Options

* Tests : fix call_load tests

* Linting : fixing line size

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
Co-authored-by: Chavithra PARANA <chavithra@gmail.com>
2022-06-14 20:23:55 +02:00
Colin Delahunty
b6300e906c Fix for DCF glitch (#1932)
* Added fixes

* Added fixes

Co-authored-by: didierlopes.eth <dro.lopes@campus.fct.unl.pt>
Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
2022-06-14 17:09:38 +03:00
James Simmons
c30f6c821b Fixing future warnings bug by switching from append to concat. (#1943) 2022-06-14 11:20:03 +08:00
Sam Kerr
a89b3dca61 Match to USA if no exchange suffix is present (#1939)
The logic on line 213 defaults to USA if there is no exchange symbol present, so the market coverage suffix should use the same logic. This enables filtering by exchange to work correctly.

Co-authored-by: didierlopes.eth <dro.lopes@campus.fct.unl.pt>
2022-06-13 23:09:58 +08:00
Chavithra
b62300f15b Update logs rotation (#1920)
* Logs : add rollover at start

* Black

* Typing

Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
2022-06-12 11:58:31 +02:00
Theodore Aptekarev
79e9275ccf Release/1.5.0 (#1926)
* Add more build assets and all notebook checkpoints to ignore

* Delete old reports that were accidentally added to the repo

* Fix portfolios not bundling

* Add mac installer image assets

* Update license

* Make the code folder hidden in macOS package

* Add folder and launcher icons programmatically during build

* Change dmg creation tool to create-dmg

* Update macOS installation docs

* Bump project version

* Update macOS installation instruction image links

* Fix macOS installation instructions styling

* Unify macOS install instructions image size

* Point download links to the website vs github

* Fix macOS launcher self-quarantine command

* Fix routines not launching in packaged apps

* Fix .openbb test mode not displaying filenames during test run

* Remove file with weird apple character in path
2022-06-10 21:32:13 +02:00
James Simmons
4ad367d2e0 Changing no data label and test files (#1922)
Co-authored-by: James Maslek <jmaslek11@gmail.com>
2022-06-10 13:17:44 -04:00
Sam Kerr
15846387a1 Use returns for correlations in hcorr (#1925)
* Use returns for correlation

* Uses returns and has lots of other print messages now

* Clean up the code some

* Remove spurious imports

* Update the help messages

* Update for black syntax errors
2022-06-10 09:06:58 -04:00