Files
OpenBB/openbb_platform/providers/imf/tests/test_table_builder.py
Danglewood bbf1ab2020 V5 (#7489)
* [Feature] OpenBB V5: Initial `openbb-core` Refactor (#7482)

* initial refactor

* ruff does not dictate style

* unresolved imports in test action

* fix general linting

* resolve pandas imports for actions run

* httpx in test workflow

* pytest-asyncio in test workflow

* pandas.Index(...)

* max version for windows CI is 3.14

* remove temp refactor files that shouldn't have been committed:

* use ruff format instead of black

* formatting and typing

* tab space helper

* test fixtures..

* ty check

* also run integration test in CI

* remove that annoying labeler action

* [V5] `openbb-core`: 100% Test Coverage (#7484)

* increase test coverage to exercise 100% of the testable code path in openbb-core

* model_fields syntax cleanup

* set the environment variable for CI runs

* run codeql on v5 branch

* more CI env setup

* cleanup redundant files

* ruff

* dedupe workflow trigger

* some windows coverage missing

* ubuntu integration test job

* more windows coverage

* test_reference_generator

* test_docstring_generator

* remove line no references from test function docstrings

* clean useless comments from test files

* fix polars type check

* fix test_obbject

* fix test_obbject

* package builder fixes

* charting pyproject version

* fix docstring generator for nested models

* missing coverage

* [V5] `openbb-core`: Add Backwards-Compatible Layered Config System (openbb.toml) (#7492)

* add backwards-compatible layered config system

* fix path reference in windows test

* need python version-aware handling in docstring generator

* update for deprecated pydantic syntax

* ruff UP007

* test_system_settings

* remove v4 platform workflow

* [V5] Refactor `openbb-oecd` for full SDMX 2 API Exposure and V5 Packaging (#7413)

* stash some changes

* add more robust testing

* mypy

* point PR at V5

* introduce spec file

* codespell

* test fix

* fix workflow environment setup

* fix workflow environment setup

* fix workflow environment setup

* add pyyaml to dependencies

* split lint jobs

* fix workflow environment setup

* fix workflow environment setup

* workflow env setup

* workflow env setup

* clean up code comments

* add auth hook entrypoints

* codespell

* add codegen feature

* codespell

* move _unpack into dispatchers for consistency with codegen packages

* surface nested models in the response

* fix missing coverage in CI

* socrata updates

* test fix

* detect plotly output

* add --include and --exclude flags from generate-extension command

* refactor openbb-platform-api for V5 operations and spec file handling

* delete poetry.lock

* add test workflow

* add temp branch id for test workflow

* add httpx to dev dependencies

* add a conftest.py

* tweak conftest

* tweak conftest

* python 3.10 issues

* more python 3.10

* more python 3.10

* more python 3.10

* more python 3.10

* fix url template resolution

* multi-spec support

* fix a windows path issue

* merge branch develop

* table builder, integration tests, and more

* linting

* merge branch develop

* bit of cleanup

* some more updates, cleanup, and apps.json

* codespell

* black

* integration test params and linting

* mypy

* pylint

* black

* more pylint

* recapture teest cassettes

* black again

* more linting

* table presentation choices

* black

* fix merge conflict

* split up metadata module and reformat cache to use msgpack

* mypy

* regenerate lock file

* use json and include dependencies to make openbb-oecd a standalone install

* pylint

* more linting

* serve metadata as dependency instead of assign and initialize

* fix integration_tests_testers to not count dependency injections as paramters

* add assets to git ignore

* ruff

* v5 refactor and publish workflow

* test coverage and ty fixes

* codespell

* update lock file

* workflow setup

* ty check

* workflow setup

* Scope PR to OECD changes only

Restore non-OECD files in the diff against v5 to their v5 state. The
branch was originally created off feature/cli-2 and inherited 186 files
of unrelated changes (cli, agent_server, mcp_server, platform_api,
core/, .github/workflows/* not oecd). Those have nothing to do with the
openbb-oecd v5 refactor and were polluting the PR diff.

* scope cleanup: include leaked v5-resident files (general-linting workflow, platform_api test fixtures)

---------

Co-authored-by: deeleeramone <>
Co-authored-by: Copilot <copilot@github.com>

* fix docstring generator and body param unwrapping

* project ty.toml file

* unpack POST parameters from params: Model

* remove comment chatter

* [V5] `openbb-oecd`: Rename `oecd_utils` as `oecd` (#7509)

* rename oecd_utils to oecd and populate all models there when openbb-economy is not installed

* linting

* bump dependencies

* fix test drift

* linter

* FieldInfo import

* [V5] `openbb-imf`: Refactor for V5 (#7508)

* refactor imf extension for V5

* codespell

* fix some python 3.10 items

* return self on copy of metadata object

* [V5] `openbb-news`: Refactor News for V5 and Add Configurable RSS Endpoint (#7507)

* refactor news for v5 and add rss endpoint

* remove poetry.lock

---------

Co-authored-by: deeleeramone <>

* [V5] `openbb-quantitative`: Refactor for V5 (#7506)

* refactor quantitative for v5

* add factors endpoint and add a few charts

---------

Co-authored-by: deeleeramone <>

* [V5] `openbb-technical`:  Refactor for V5 & Add More Quick Win Endpoints (#7502)

* refactor openbb-technical for v5

* forward refs

* linting

* no python 3.15 in test matrix

* reame

* ty

* move all params to body

---------

Co-authored-by: deeleeramone <>

* remove stockgrid provider (#7486)

* [V5] remove wsj provider and related code (#7485)

* remove wsj provider and related code

* purge from metadata

* actions

* actions

* openbb-core publish workflow

* delete biztoc (#7523)

* [V5] Remove `openbb-alpha-vantage` (#7522)

* delete alpha vantage

* more files

---------

Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>

* [V5] Remove `openbb-benzinga` (#7521)

* delete benzinga

* more references

---------

Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>

* [V5] `openbb-bls`: Refactor for V5 + Add Many Endpoints (#7518)

* refactor bls for v5, add 100 widgets

* some CI fixes

* no python 3.15

* fix missing dev group in pyproject.toml

* more pyproject fallout

* action

* refactor econometrics for v5 (#7505)

Co-authored-by: deeleeramone <>

* [V5] `openbb-famafrench`: Refactor for V5 (#7503)

* refactor famafrench for v5

* codespell

* finishing touches

---------

Co-authored-by: deeleeramone <>

* [V5] CLI 2.0 - Pluggable Backends, Non-TTY Default, HTTP Dispatcher, Spec Files + Codegen (#7433)

* stash some changes

* add more robust testing

* mypy

* point PR at V5

* introduce spec file

* codespell

* test fix

* fix workflow environment setup

* fix workflow environment setup

* fix workflow environment setup

* add pyyaml to dependencies

* split lint jobs

* fix workflow environment setup

* fix workflow environment setup

* workflow env setup

* workflow env setup

* clean up code comments

* add auth hook entrypoints

* codespell

* add codegen feature

* codespell

* move _unpack into dispatchers for consistency with codegen packages

* surface nested models in the response

* fix missing coverage in CI

* socrata updates

* test fix

* detect plotly output

* add --include and --exclude flags from generate-extension command

* cap test matrix at python 3.14

* no useless comments

* platform controller command description split

* merge URL overloads from path params

* exclude none and unset from model dump

---------

Co-authored-by: deeleeramone <>
Co-authored-by: Copilot <copilot@github.com>

* general-linting

* downgrade aiohttp in devtools for vcrpy

* some ty items and add requests-types stubs for ty in devtools

* markdown linting

* remove integration tests from extensions that were moved into the famafrench provider

* [V5] `openbb-congress-gov`: Refactor for V5 + Convert To Using Bulk Files Instead of `api.congress.gov`. (#7528)

* refactor congress-gov for v5 and use bulk files instead of API with credentials

* integration tests

* apps tab name

* convert caching to sql

* codespell

* [V5] [BugFix] Fix for Breaking Changes in FastAPI 0.137+ (#7537)

* fix route introspection for fastapi 0.137

* recapture oeccd gdp forecast test cassette

---------

Co-authored-by: deeleeramone <>

* [V5] `openbb-platform-api`: Refactor for V5 Spec, Config, Packaging, Test Coverage (#7494)

* stash some changes

* add more robust testing

* mypy

* point PR at V5

* introduce spec file

* codespell

* test fix

* fix workflow environment setup

* fix workflow environment setup

* fix workflow environment setup

* add pyyaml to dependencies

* split lint jobs

* fix workflow environment setup

* fix workflow environment setup

* workflow env setup

* workflow env setup

* clean up code comments

* add auth hook entrypoints

* codespell

* add codegen feature

* codespell

* move _unpack into dispatchers for consistency with codegen packages

* surface nested models in the response

* fix missing coverage in CI

* socrata updates

* test fix

* detect plotly output

* add --include and --exclude flags from generate-extension command

* refactor openbb-platform-api for V5 operations and spec file handling

* delete poetry.lock

* add test workflow

* add temp branch id for test workflow

* add httpx to dev dependencies

* add a conftest.py

* tweak conftest

* tweak conftest

* python 3.10 issues

* more python 3.10

* more python 3.10

* more python 3.10

* more python 3.10

* fix url template resolution

* multi-spec support

* fix a windows path issue

* cap test matrix at python 3.14

* no 3.15 runners for platform-api

* no useless comments

* platform controller command description split

* merge URL overloads from path params

* exclude none and unset from model dump

* markdown lint

* ignore get/post endpoints that are return SSE

* fix remaining fastapi 0.137 fallout

---------

Co-authored-by: deeleeramone <>
Co-authored-by: Copilot <copilot@github.com>

* add full support for AsyncIterator response type for streaming output (#7530)

* [V5] Refactor Shared Pass Through Router Extensions For Hatchling (#7524)

* refactor shared pass-through routers for hatchling and ruff + ty

* add publish workflows

* [V5] `openbb-charting`: Refactor for V5 and Decouple  (#7545)

* refactor charting for v5 patterns and decouple entirely

* coveragerc

* lint and tests

* fix tests

* configure dev group with openbb-technical

* ty

* fix cli test

* remove 3.15 from test matrix - dependencies are unstable

---------

Co-authored-by: deeleeramone <>

* fix merge widgets

* workflow cleanup"

* fixes for ty

* fogot that file

* general lint setup

* consolidate lint job

* remove seeking alpha provider (#7570)

* remove tradier provider (#7573)

* remove tiingo provider (#7574)

* remove intrinio provider (#7575)

Remove the openbb-intrinio provider extension from the repository.
Reason: proprietary vendor with no internal access to any endpoint;
cannot build, develop or maintain.

* remove yfinance provider from repo (#7576)

* fix(cli): resolve modular OpenAPI references (#7586)

Fixes #7585

* [V5] `openbb-cli`: Modular OpenAPI Refs (#7589)

* follow up to #7585

* add another codegen test

* unused ty ignore

* Update generated tests to get python parameter names instead of raw API-provider parameter names. (#7597)

* Update the record-vs-envelope heuristic in the payload processing code to not treat a record that happens to have a list datatype as an entire envelope. (#7598)

* Update class generation code to handle empty data that php-style serialization emits as []. (#7599)

* fix ty check failures exposed by newer version

* add drugs.com and brutalist as news rss feeds (#7602)

Co-authored-by: deeleeramone <>

* codespell

* missing test coverage that appeared in famafrench..

* plotly 7 handling for mapbox namespace change

* remove finviz (#7577)

* remove trading economics provider (#7578)

* remove openbb-multpl from repository (#7610)

* add httpx2 to devtools for starlette test client

* restore test coverage to 100% in openbb_core

* remove fmp provider extension from repository (#7665)

* unpin ruff

* fix charting conftest and missing coverage in 3.10

* add charting coverage

* fix new ty issues

* fix tag grouping in swagger docs

* [V5] `openbb-ecb`: Refactor for V5 and Expand Coverage (#7560)

* refactor openbb-ecb for v5 and expand coverage

* some updates

* tests

* workflow

* remove 3.15 from test matrix

* some more table schema updates

* remove some html chrome on embedded articles

---------

Co-authored-by: deeleeramone <>

* [V5] `openbb-federal-reserve`: Refactor for V5 + FFIEC & Regional Fed Routers (#7561)

* refactor for v5

* add workflows

* fix bhcpr schema

* fix pyproject.toml

* fix test

* codespell

* ty

* fix pyproject

* fix ci environment

* fix ci environment

* convert documents endpoints to use fedinprint service

* codeql fix

* fix ny publications and add ny nowcast

* [V5] `openbb-eia`: Refactor for V5 + Add Full API Implementation (#7584)

* eia refactor for v5

* add test and publish workflows

* data browser state

* fix workflows

* more workflow test items

* temp files in tests

* more fixes

* more browsers

* fix codeql issues

* fix mer state and ensure multi-user capability

* uv lock

* table bridge

* fix electricity browser state

* convert HTML widgets to iFrame

* fix recursion error in workspace mcp

* [V5] `openbb-government-us`: Refactor for V5 + Move `uscongress` (#7604)

* v5 government_us provider

* workflow files

* ty and add xlrd to pyproject

* shrink test cassettes

* dev dependencies

* wheel packaging and more tests

* python 3.10 thing..?

* fix test

* default state for multiselect dropdowns

* replace congress html widgets with iframes

* fallback to congress api for congress before 108

* ensure member passage voting count populates

* [V5] Feature: Add JODI World Oil & Gas Database (#7593)

* add the JODI oil and gas database as a provider/router extension

* lint fixes

* add grouping to apps.json

---------

Co-authored-by: deeleeramone <>

* [V5] `openbb-cftc`: Refactor for V5 + Add OIS, Forward Curve, and FX Trade Analysis (#7615)

* refactor openbb-cftc for v5

* add SHIBOR to fixings

---------

Co-authored-by: deeleeramone <>

* fix for plotly 7 breaking change to schemas

* [V5] `openbb-tmx`: Refactor extension for V5 (#7668)

* refactor tmx provider for v5

* fix tests..

* fix tests stack trace exposure

* fix workflow setup

* [V5] `openbb-nasdaq`: Refactor provider for V5. (#7670)

* refactor nasdaq provider for v5

* add workflows

* ty fix

* [V5] `openbb-fred`: Refactor as V5 extension. (#7669)

* refactor fred extension for v5

* fix markdown MD037 lint error in README

* codespell

* [V5] `openbb-cboe`: Refactor for V5 + Add Payoff Diagrams (#7617)

* refactor cboe for v5

* use zoneinfo instead

* fix test

* some fixes related to the cache access

* fix a couple of tests

* fix the test coverage

* [V5] `openbb-deribit`: Refactor provider for V5 (#7674)

* refactor openbb-deribit for v5

* restructure the optimizer around the published combos data and add integration test suites

* fix markdown lint errors

* remove openbb-econdb provider (#7675)

* codespell

* [V5] `openbb-sec`: Refactor for V5 (#7525)

* refactor openbb-sec for v5

* linting

* ty

* normalize compare_company_facts

* add workflows

* python 3.10 fix

* add more thorough url validation and tests

* ty check

* ty for python 3.10

* reconfigure with apps

* temp pyproject overrride

* pyproject

* pyproject

* pyproject

* codespell

* pyproject

* fix uk schema file links in schema_files

* test coverage

* test_cli

* port #7547 into this pr

* no hard coded prefix

* improve filing rendering capabilities

* fix xml text detection

* make codeql happy

* missed a file in the commit

* test coverage

* codespell

* fix flakey test

* some updates

* management_ownership --> management_profiles

* proxy statement markdown

* ruff

* fix test coverage

* more tests

* test coverage

* fix lint errors

* Add SEC adviser search, profile, and universe routes (#7559)

* Add SEC institutional data fetchers

* Add SEC filing index and Form D routes

* Add SEC investment adviser people data

* Expose SEC adviser and institutional routes

* fix(sec): address adviser review feedback

* refactor(sec): narrow adviser support to IAPD search

* feat(sec): add adviser firm and individual searches

* feat(sec): add adviser profile drill-down

* fix: repair pre-commit configuration

* feat(sec): add adviser universe route

* feat(sec): expose complete Form ADV data

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>

* fix test coverage

---------

Co-authored-by: deeleeramone <>
Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>

* [V5] `openbb-finra`:  Refactor for V5 (#7676)

* refactor finra provider for v5

* add workflows

* fix tests

* fix lint errors

* [V5] Update Repository License to Apache 2.0 (#7677)

* change license to Apache 2.0 for V5

* codespell

* bump devtools and repoint pyproject.toml

* Enterprise Flask Migration Toolkit (#7264)

* feat: Add Flask-to-OpenBB enterprise migration toolkit

- Implement Router.from_flask() for zero-touch legacy API conversion
- Enable 4-hour migration vs 6-month traditional rewrite (80% cost reduction)
- Generate FastAPI endpoints from Flask routes with automatic type validation
- Support enterprise consulting services and custom integration workflows

Demonstrates OpenBB's competitive advantage for institutional client migrations.
Complements existing Workspace applications like Open Portfolio suite.

* chore: Resolve .gitignore conflict and add common ignores

* refactor: implement Phase 1 Flask integration architecture- Move Flask conversion logic to openbb_core.app.utils.flask- Add Flask detection to extension_loader - Integrate with OpenBB's core extension system- Add Flask dependency validation with sys.modules checkingAddresses @deeleeramone's architectural feedback for native OpenBB integration.

* docs: add Flask direct entry point demos- demo_direct_flask_entry_point.py: shows direct Flask instance reference- example_pyproject_flask_entry.toml: demonstrates pyproject.toml configurationSupports new architecture eliminating wrapper extensions.

* Implement Phase 1 Flask adapter per code review feedback

- Minimal working implementation with Flask detection and router creation
- Removes complex code generation logic for focused Phase 1 delivery
- Establishes foundation for Phase 2 route conversion features

* Fix Flask integration: Replace missing FlaskToOpenBBAdapter with WSGIMiddleware

- Remove FlaskToOpenBBAdapter which was not implemented
- Use FastAPI's WSGIMiddleware to mount Flask apps directly
- Update extension_loader to use returned Router object
- Convert utils.py to utils/__init__.py to support flask submodule
- Addresses PR review comment about unhandled AttributeError

* Address PR review feedback: fix Flask imports and remove unused files

- Revert .gitignore to upstream/develop
- Remove AI-generated demo/example files and flask_adapter extension
- Move Flask/werkzeug imports inside conditional blocks to avoid ImportError
- Use lazy imports via __getattr__ in utils/flask/__init__.py
- Add Flask tests with @pytest.mark.skipif markers

* Force APIRouter.include_router to propagate Mount paths instead of dropping them. (#1)

This change ensures that mounted ASGI applications (such as Flask apps wrapped in WSGIMiddleware) are not dropped when `APIRouter.include_router` is called.

Previously, while the initial load in `ExtensionLoader` worked as expected, the `Mount` objects were ignored by FastAPI's default inclusion logic. This caused the mounted elements to be lost during the final application assembly, resulting in 404 errors for the Flask routes.

This fix overrides the inclusion logic to manually propagate `Mount` objects downstream.

* feat(flask): Add metadata layer for OpenAPI documentation

Enhance Flask-to-OpenBB converter with structured docstring parsing:
- Parse Google-style docstrings (summary, description, params)
- Extract parameter descriptions from Args section
- Pass metadata to Router.command() for rich OpenAPI docs

This addresses PR feedback to provide tangible benefit by generating
comprehensive API documentation for migrated Flask routes.

* feat(flask): Implement manual OpenAPI spec generation and attachment

- Add FlaskParam and FlaskRouteInfo TypedDict for type-safe metadata
- Implement OpenAPISpecGenerator for Flask→OpenAPI conversion
- Extract route metadata via FlaskIntrospector
- Attach generated spec to router.openbb_openapi_spec_ext
- Add unit tests (3/3 passing)

Addresses WSGI/mount boundary issue where Router.command metadata
cannot propagate through WSGIMiddleware. Spec attached to router
instance for downstream OpenAPI assembly.

Resolves maintainer feedback on PR #7264

* feat(flask): Implement FlaskMountRegistry for multiple mount support

- Add FlaskMountRegistry class for centralized OpenAPI spec management
- Replace router.openbb_openapi_spec_ext with registry pattern
- Support multiple Flask apps at different mount prefixes
- Automatic path rewriting in aggregated OpenAPI specs
- Add registry test case (4/4 tests passing)

Addresses @deeleeramone's feedback on PR #7264 regarding router
attribute fragility and multiple mount support. Registry provides
lifecycle-independent state management and enables enterprise
scenarios with multiple Flask apps.

Resolves: OpenBB-finance/OpenBB#7264 (partial)

* feat(core): load Flask apps as openbb_core_extension WSGI sub-apps

A Flask app referenced directly by an openbb_core_extension entry point is
mounted via WSGIMiddleware and its routes are introspected into openapi.json
(operationId/widgetId/mcp_tool, parameters, request bodies, security, widget_config
and HTML widgets) so the widget factory and MCP server can discover them.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test(core): 100% coverage for flask utils + flask dev dependency

Add branch-coverage tests for the Flask integration package (introspection,
AST analysis, docstrings, OpenAPI generation, registry, loader, detection) and
declare flask as a dev dependency so the suite runs in CI.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(flask): treat f-string returns as HTML responses

* fix(flask): mount via a2wsgi instead of deprecated starlette WSGIMiddleware

- add openbb-core[flask] extra (flask, a2wsgi); a2wsgi resolved through require_optional
- run the WSGI serve test through mount_flask_extensions; drop httpx importorskip
- core CI installs [pandas,flask] and httpx2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(flask): cover failed entry point loads; narrow optional types for ty

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
Co-authored-by: deeleeramone <>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

* perf(core): vectorize the date conversion in `basemodel_to_df` (#7622)

* perf(core): vectorize the date conversion in basemodel_to_df

basemodel_to_df ran three per-element Python passes over the date column of
every payload it converted. Series.apply(to_datetime) calls pandas.to_datetime
once per row, and because each call receives a lone scalar with no format hint,
pandas also re-runs its datetime format guesser on every row.

Parse the column in one call instead, and use vectorized comparisons for the
all-midnight test and the reduction to datetime.date.

The element-wise parse is kept as a fallback for one case that the vectorized
path cannot represent: a column mixing UTC offsets, such as a series crossing a
daylight-savings boundary. Parsing per element lets each value keep its own
offset and yields an object column of tz-aware Timestamps, whereas a single
to_datetime call over that column raises "Mixed timezones detected". That
behaviour is covered by test_to_df_daylight_savings and is preserved exactly.

Measured on a payload built through EquityHistoricalData, median of 9 under an
exclusive CPU lock:

  250 daily bars     8.92 ms -> 1.46 ms
  1,000 daily bars  32.93 ms -> 3.13 ms
  5,000 daily bars 162.25 ms -> 12.23 ms

* fix a broken test - unrelated to this PR...

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
Co-authored-by: deeleeramone <>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix lint errors

* fix oecd lint error

* [V5] `openbb-mcp-server`: Refactor for v5 - Spec, Config, Packaging, Test Coverage (#7495)

* stash some changes

* add more robust testing

* mypy

* point PR at V5

* introduce spec file

* codespell

* test fix

* fix workflow environment setup

* fix workflow environment setup

* fix workflow environment setup

* add pyyaml to dependencies

* split lint jobs

* fix workflow environment setup

* fix workflow environment setup

* workflow env setup

* workflow env setup

* clean up code comments

* add auth hook entrypoints

* codespell

* add codegen feature

* codespell

* move _unpack into dispatchers for consistency with codegen packages

* surface nested models in the response

* fix missing coverage in CI

* socrata updates

* test fix

* detect plotly output

* add --include and --exclude flags from generate-extension command

* refactor mcp server for v5

* test action

* fix tests

* tests

* test fixture name

* revert: drop unrelated provider/README changes from mcp-server refactor

Strip the changes to ``README.md`` and ``openbb_platform/providers/{imf,
tradingeconomics,yfinance}`` that snuck into 4ac3602 (refactor mcp server
for v5). Those files are out of scope for the mcp-server work and were
modified inadvertently — restore them to their pre-4ac3602 state.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* tests and workflows

* fix workflow

* tests and workflows

* tests and workflows

* tests and workflows

* tests and workflows

* beartype shim for 3.15

* muck around with beartype for 3.15

* muck around with beartype for 3.15

* no 3.15 runners for mcp-server

* update skill files

* cap test matrix at python 3.14

* merge branch v5

* no useless comments

* platform controller command description split

* merge URL overloads from path params

* exclude none and unset from model dump

* refactor for fastmcp4

* wrap markdown lines that are too long

---------

Co-authored-by: deeleeramone <>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* update pre-commit, noxfile, and uv locks

* fixes for docstring generation

* test coverage

* fix cli renderer helper with figure object JSON

* fix the figure font when rendered

* refactor cookiecutter

* bump cookiecutter packagge version

* fix sec test by adding fixture

* fix desktop environments test

* fix(cli): inherit path-item-level OpenAPI parameters (#7606)

* fix(cli): inherit path-item-level OpenAPI parameters

OpenAPI 3.x lets a Path Item Object declare `parameters` shared by every
operation under that path, with operation-level entries overriding them by
(name, in). The codegen read only `op.get("parameters")`, so inherited
parameters were dropped silently — the generated command kept the URL
template but had nothing registered to fill it.

Real-world impact: the Xero Accounting API declares its required
`xero-tenant-id` header once per path item across all 138 paths. Before this
change `build_command_spec` produced 78 commands and none carried the
header, so every generated command 403s. Nothing warned.

Adds `operation_parameters()`, which merges the two levels and dereferences
both, and routes the pre-computed spec path (`build_command_spec`) and the
interactive path (`build_command_index` -> `build_parser_from_operation`)
through it. Unresolvable refs, non-dict entries, and nameless parameters are
skipped as before. Specs without path-item parameters are unaffected.

* fix(cli): narrow path-item inheritance to path and query parameters

Per review: headers do not translate into a Python interface function, and
outbound headers are transport configuration
(SystemSettings.PythonSettings.http.headers, the CLI's -H) or a security-scheme
concern — not a per-command argument.

Path-item `in: header` and `in: cookie` entries are now dropped rather than
inherited. Operation-level parameters are untouched, so an operation that
declares its own header keeps today's behavior.

Scope is now only what cannot be supplied any other way: `in: path` and
`in: query` parameters declared on the Path Item Object.

* fix(cli): merge allOf compositions in response schemas

Response-schema $refs were already expanded by deref_schema, but a schema
whose top level is an allOf composition was left unflattened. The properties
live inside the members, so a consumer reading them off the composition finds
none. fetcher_gen._data_schema looks for `properties.results`, gets nothing,
and falls through to _unwrap_schema_envelopes, which handles oneOf and anyOf
but not allOf. The generated Data model ends up with no fields.

Codat's listBills response is `allOf: [{properties: {results}}, {properties:
{_links, pageNumber, pageSize, totalResults}}]`, which produced an empty model.

merge_allof collapses a composition of object subschemas into one object
schema: properties unioned with the first declaration winning on conflict,
required unioned, and sibling keywords on the allOf node outranking members.
A composition that is not a plain intersection of object subschemas (a member
carrying its own oneOf/anyOf, or a non-object type) is returned unchanged
rather than flattened into something the spec does not describe. Nested
compositions are merged too, so a $ref inside a merged member still resolves.

Applied to extract_response_schema and extract_response_schemas.

Measured across five specs that use the pattern, counting operations whose
response schema exposes readable properties: 244 of 588 before, 394 after
(Codat Accounting 36 to 88, Codat Banking 0 to 8, Codat Commerce 1 to 11,
Rebilly 62 to 104, Box 145 to 183).

* fix(cli): merge allOf compositions in request body schemas

Same gap as the response side. request_body_parameters needs `type: object`
or `properties` to flatten a body into parameters, and an allOf composition
carries neither, so a POST or PUT generated from one gets no body parameters
at all.

extract_request_body_schema now runs merge_allof after deref_schema, matching
extract_response_schema.

Across the same five specs, counting request bodies that produce parameters:
138 of 206 before, 177 after (Codat Accounting 1 to 26 of its 30 bodies,
Rebilly 50 to 63, Box 87 to 88).

* fix(cli): stop annotation keywords blocking an allOf merge

_mergeable_allof_members required every member's keys to come from a small
whitelist, so any unrecognized keyword disqualified the whole composition.
Codat's PagingInfo carries `definitions` next to its properties, which meant
the live Codat-Accounting.yaml never merged and its response models stayed
empty. The APIs.guru copy of the same API omits that key, which is why the
earlier measurements looked clean.

The check is now a blocklist. A member blocks the merge when it carries its
own combinator (oneOf/anyOf/allOf/not), an unresolved $ref left by a cycle,
a scalar or array constraint (enum/const/items), or a type other than object.
Annotation keywords that do not affect the intersection (title, description,
examples, definitions, additionalProperties, vendor x- keys) no longer block
it, and are dropped from the merged result along with the members.

On the live Codat spec, operations whose response schema exposes readable
properties go from 36 of 127 to 114. Across the five specs measured earlier:
244 of 588 before, 488 after (was 394 under the whitelist).

Corpus check over 2,816 response and request-body extractions in 6 specs:
567 changed, every one attributable to an allOf in the pre-merge output,
0 unexplained. Twilio declares no allOf compositions and is unchanged.

* fix(cli): emit a name once when it is both a parameter and a body property

_signature_params appended request-body properties and then operation
parameters without deduplicating, so a name declared in both places produced
two function parameters with the same name and the generated module raised
SyntaxError.

Codat's push endpoints hit this: /push/bankAccounts/{accountId}/bankTransactions
declares accountId as a path parameter and repeats it in the request body, so
connections.push.bankAccounts.bankTransactions generated `accountId: str` and
`accountId: str = None` in one signature.

The operation parameter wins, since it carries the path placeholder and its own
required flag. The request payload is unchanged: _render_body_block derives body
fields from request_body_schema rather than from this list, so accountId is
still sent in the body.

This predates the path-item and allOf work in this PR. On origin/v5 the same
spec produces the same duplicate; on this branch the Codat spec generates 91
commands with 0 duplicated signatures, down from 1.

* fix(cli): use the safe identifier for keyword-named body properties

_render_body_block already writes `{'from': from_}`, keying the payload by the
wire name and reading a safe identifier, but _signature_params declared the raw
name. A body property named after a Python keyword therefore emitted
`from: str = None` and the generated module raised SyntaxError.

This did not fire before the allOf work in this PR, because a composed request
body produced no body parameters at all. Codat's Transfer body is such a
composition and has a `from` property, so connections.push.transfers started
generating invalid syntax once the body flattened.

_signature_params now emits safe_field_name(name)[0], the same helper
fetcher_gen and pydantic_gen already use. The body/query split in
_render_body_block compares against the safe names too: it previously matched
signature names against wire names, so `from_` was not recognized as a body
field and leaked into the query string as a `from_` parameter.

End to end on Codat-Accounting.yaml, generating the full extension and byte
compiling every emitted module: 136 files, 0 failures. origin/v5 emits 1 file
that does not compile (duplicate argument 'accountId').

Known gap left alone: an operation parameter named after a keyword would still
break, since the query and path lines use the raw name as a local variable.
None of the five specs checked declares one.

* fix(cli): do not treat instance data as schema, and sanitize POST identifiers

Two defects found by generating extensions from real specs and byte compiling
every emitted module.

merge_allof and deref_schema walked every value in a schema dict, including
keywords that hold instance data rather than subschemas. A `default` of
`{"allOf": [{"a": 1}, {"b": 2}]}` was rewritten to `{"type": "object"}`, and a
`$ref` key inside an example was resolved as if it were a reference. Both now
copy `default`, `example`, `examples`, `enum`, `const` and vendor `x-` values
through untouched.

_signature_params emitted operation parameter names verbatim, so a wire name
that is not a Python identifier produced invalid syntax. Rebilly declares an
`Organization-Id` header and a `REB-APIKEY` security header, which emitted
`REB-APIKEY: str = None`. It now uses safe_field_name, matching fetcher_gen,
and _render_body_block keys the query dict by the wire name while reading the
safe identifier so the request is unchanged.

This surfaced through the allOf work rather than being caused by it: a composed
request body used to yield no properties, so `has_body` was false in
package_gen and the command was generated as a GET fetcher, where identifiers
were already sanitized. With bodies flattening, 14 of Codat's 24 POST endpoints
correctly move to the POST path, which had never been exercised by these specs.

Generating the full extension and compiling every module:

  Codat-Accounting.yaml   v5: 1 failure    branch: 0   (136 files)
  Rebilly 2.1             v5: 14 failures  branch: 1   (97 files)

The one remaining Rebilly failure is `async def 3dsecure(` in the router, which
fails identically on v5. Sanitizing that is a naming decision about the command
surface, so it is left alone here.

Known gap: a non-credential header parameter is still placed in the query
string on the POST path. Pre-existing, and unchanged by this PR.

* fix(cli): resolve signature collisions on the emitted identifier

The previous dedupe compared wire names, but the failure it prevents depends on
the sanitized identifier. Two wire names can collapse onto one (`from` and
`from_`, `Organization-Id` and `Organization_Id`), and operation_parameters
keeps a name declared twice under different `in` locations by design, so both
cases could still emit a duplicate argument.

_signature_params now tracks the identifiers it has emitted and skips anything
that would repeat one. Emission order is unchanged, so existing signatures are
byte-identical; only genuinely colliding names are dropped, and operation
parameters still win over body properties.

Neither collision occurs in Codat-Accounting.yaml or Rebilly 2.1. This closes
the class rather than the instance, since the instances are what this PR has
been finding.

Generation unchanged: Codat 136 files 0 failures, Rebilly 97 files 1 failure
(`async def 3dsecure(`, identical on v5).

* test(cli): cover the instance-data guard, and drop a redundant branch

Mutation checking the new tests (revert each fix, confirm its test fails)
found two problems with the previous commits.

The guard that stops merge_allof and deref_schema from walking into `default`,
`example`, `enum`, `const` and vendor values shipped with no test at all. It is
now covered from both directions: a default holding an `allOf` key keeps its
value, and a `$ref` inside a default stays a literal while a real reference
beside it still resolves.

The body-property loop also carried a redundant check. It tested the raw wire
name against the operation parameter names before testing the sanitized one,
but `operation_param_names` holds both forms and `safe_field_name` is idempotent
on identifiers, so the first test could never fire alone. Reverting it left
every test passing, which is what surfaced it. Removed, and the sanitized name
is now computed once.

All nine mutations are caught by the suite: both data guards, the allOf
blocklist in each direction, the response merge wiring, body/parameter
precedence, the keyword identifier, the body/query split and the
emitted-identifier dedupe.

cli/tests at 1,954 passed against the same 80 environment failures as the base.
Generation unchanged: Codat 136 files 0 failures, Rebilly 97 files 1 failure.

* fix(cli): route required path-item headers/cookies through credential handling

* fix(cli): narrow Popen.stdin/stdout for ty in run_in_obb fixture

---------

Co-authored-by: deeleeramone <>

* fix warnings raised by federal_reserve on some xlsx workbook parsing

* fix publish workflows

* test publish pipeline with openbb-core-v2.0.0rc0 (#7681)

* fix publish workflows with missing tag job, some tests and bump fastapi

* fix python 3.10 test failure in core

* actually fix python 3.10 test failure in core

* deincrement openbb-core version to allow release pattern

* bump core version (#7682)

* remove uv.sources from pyproject.toml files and point to openbb-core-2.0.0 on PyPI

* remove oecd cache asset that wasn't supposed to be commuitted

* remove poetry.lock, update pyproject.tml and uv.lock for openbb-platform-api-v2.0.0 (#7684)

Co-authored-by: deeleeramone <>

* add the missing publish-openbb-platform-api.yml workflow file

* remove poetry.lock, update pyproject.tml and uv.lock for openbb-platform-api-v2.0.0 (#7685)

Co-authored-by: deeleeramone <>

* fix the tag generation after publish

* [Release] `openbb-charting-v4.0.0` (#7686)

* up openbb-charting to 4.0.0 and fill missing test coverage in chart_style

* test coverage and format markdown files

---------

Co-authored-by: deeleeramone <>

* remove scikit-learn from dependencies, update tests, and format markdown files (#7687)

Co-authored-by: deeleeramone <>

* [Release] `openbb-cli-v2.0.0` (#7692)

* fix missing test coverage in openbb_cli

* fix conftest

---------

Co-authored-by: deeleeramone <>

* add missing publish-openbb-cli.yml workflow

* [Release] `openbb-cli-v2.0.0` (#7693)

* fix missing test coverage in openbb_cli

* fix conftest

---------

Co-authored-by: deeleeramone <>

* test fixes for cli...

* [Release] `openbb-cli-v.2.0.0` (#7694)

* fix missing test coverage in openbb_cli

* fix conftest

---------

Co-authored-by: deeleeramone <>

* fix hanging mcp server test

* [Release] `openbb-mcp-server-v2.0.0` (#7695)

Co-authored-by: deeleeramone <>

* update uv.lock (#7696)

Co-authored-by: deeleeramone <>

* release openbb-commodity-v2.0.0 (#7697)

Co-authored-by: deeleeramone <>

* update uv.lock (#7698)

Co-authored-by: deeleeramone <>

* update uv.lock (#7699)

Co-authored-by: deeleeramone <>

* update uv.lock (#7700)

Co-authored-by: deeleeramone <>

* [Release] `openbb-econometrics-v2.0.0` (#7701)

* update uv.lock

* update pyproject.toml

---------

Co-authored-by: deeleeramone <>

* update uv.lock (#7703)

Co-authored-by: deeleeramone <>

* update uv.lock (#7702)

Co-authored-by: deeleeramone <>

* update uv.lock (#7704)

Co-authored-by: deeleeramone <>

* update uv.lock (#7705)

Co-authored-by: deeleeramone <>

* update uv.lock (#7706)

Co-authored-by: deeleeramone <>

* [V5] Fix a Number of V5 Bugs (#7707)

* fix a number of v5 bugs

* fix lint error

* more lint

* fixes for quantitative, technical, charting, famafrench for version bumps

---------

Co-authored-by: deeleeramone <>

* update uv.lock (#7709)

Co-authored-by: deeleeramone <>

* update uv.lock (#7708)

Co-authored-by: deeleeramone <>

* update uv.lock (#7710)

Co-authored-by: deeleeramone <>

* update uv.lock (#7711)

Co-authored-by: deeleeramone <>

* [Release] `openbb-cboe-v2.0.0` (#7713)

Co-authored-by: deeleeramone <>

* update uv.lock (#7714)

Co-authored-by: deeleeramone <>

* update uv.lock (#7717)

Co-authored-by: deeleeramone <>

* [Release] `openbb-ecb-v2.0.0` (#7715)

* update uv.lock

* update uv.lock

---------

Co-authored-by: deeleeramone <>

* update uv.lock (#7718)

Co-authored-by: deeleeramone <>

* update uv.lock (#7719)

Co-authored-by: deeleeramone <>

* update uv.lock (#7720)

Co-authored-by: deeleeramone <>

* add missing publish-openbb-fred.yml to repo

* update uv.lock (#7723)

Co-authored-by: deeleeramone <>

* update uv.lock (#7722)

Co-authored-by: deeleeramone <>

* update uv.lock (#7716)

Co-authored-by: deeleeramone <>

* update uv.lock (#7724)

Co-authored-by: deeleeramone <>

* update uv.lock (#7726)

Co-authored-by: deeleeramone <>

* [Release] `openbb-fred-v2.0.0` (#7725)

* update uv.lock

* fix tests and dependencies

* fix test_fred_fetchers

---------

Co-authored-by: deeleeramone <>

* [Release] `openbb-imf-v3.0.0` (#7727)

* update uv.lock

* fix tests and dependencies

* fix test_fred_fetchers

* bump openbb-imf version to 3.0.0

---------

Co-authored-by: deeleeramone <>

* update uv.lock (#7729)

Co-authored-by: deeleeramone <>

* update uv.lock (#7728)

Co-authored-by: deeleeramone <>

* update uv.lock (#7730)

Co-authored-by: deeleeramone <>

* update uv.lock (#7731)

Co-authored-by: deeleeramone <>

* update uv.lock (#7732)

Co-authored-by: deeleeramone <>

* update uv.lock (#7733)

Co-authored-by: deeleeramone <>

* cookiecutter pyproject and lock

* update pyproject.toml (#7734)

Co-authored-by: deeleeramone <>

* update pyproject.toml (#7735)

Co-authored-by: deeleeramone <>

* update uv.lock (#7736)

Co-authored-by: deeleeramone <>

* fix some sec issues, allegedly (#7737)

Co-authored-by: deeleeramone <>

* update uv.lock (#7738)

Co-authored-by: deeleeramone <>

* update main pyproject.toml

* lint fixes

* update assets (#7739)

Co-authored-by: deeleeramone <>

* [Release] `openbb-v5.0.0` (#7740)

* update assets

* add missing workflow

---------

Co-authored-by: deeleeramone <>

---------

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: deeleeramone <>
Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
Co-authored-by: Dex <i@dex.moe>
Co-authored-by: Monte Hoover <monte.b.hoover@gmail.com>
Co-authored-by: Boris Li <65254053+BorisQuanLi@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Lucas Zimmermann <lucaszmayer@gmail.com>
2026-09-29 14:45:53 +00:00

3919 lines
138 KiB
Python

"""Tests for IMF Table Builder."""
# ruff: noqa: I001
from unittest.mock import MagicMock, patch
import pytest
class TestImfTableBuilder:
"""Tests for ImfTableBuilder class."""
@pytest.fixture
def mock_query_builder(self):
"""Mock ImfQueryBuilder for table builder tests."""
with patch(
"openbb_imf.utils.query_builder.ImfQueryBuilder"
) as MockQueryBuilder:
mock_instance = MockQueryBuilder.return_value
mock_instance.metadata = MagicMock()
mock_instance.dataflows = {
"BOP": {
"id": "BOP",
"name": "Balance of Payments",
"structureRef": {"id": "IMF_BOP"},
}
}
mock_instance.validate_dimension_constraints = MagicMock()
yield MockQueryBuilder
def test_table_builder_instantiation(self, mock_query_builder):
"""Test that table builder can be instantiated."""
from openbb_imf.utils.table_builder import ImfTableBuilder
builder = ImfTableBuilder()
assert builder is not None
assert builder.query_builder is not None
def test_validate_dimension_constraints_delegates(self, mock_query_builder):
"""Test that dimension validation delegates to query builder."""
from openbb_imf.utils.table_builder import ImfTableBuilder
builder = ImfTableBuilder()
builder._validate_dimension_constraints("BOP", COUNTRY="USA")
mock_query_builder.return_value.validate_dimension_constraints.assert_called_once_with(
"BOP", COUNTRY="USA"
)
class TestTableIdParsing:
"""Tests for table ID parsing logic."""
@pytest.fixture
def mock_query_builder(self):
"""Mock ImfQueryBuilder."""
with patch(
"openbb_imf.utils.query_builder.ImfQueryBuilder"
) as MockQueryBuilder:
mock_instance = MockQueryBuilder.return_value
mock_instance.metadata = MagicMock()
mock_instance.dataflows = {"BOP": {"id": "BOP"}}
mock_instance.validate_dimension_constraints = MagicMock()
yield MockQueryBuilder
def test_table_id_with_dataflow_prefix(self, mock_query_builder):
"""Test parsing table_id with dataflow::table_id format."""
from openbb_imf.utils.table_builder import ImfTableBuilder
builder = ImfTableBuilder()
assert builder.query_builder is not None
import inspect
sig = inspect.signature(builder.get_table)
assert "table_id" in sig.parameters
class TestHierarchyDetection:
"""Tests for hierarchy/table detection in symbols."""
def test_table_id_starts_with_h(self):
"""Test that H_ prefix identifies table IDs."""
table_ids = [
"H_BOP_BOP_AGG_STANDARD_PRESENTATION",
"H_IRFCL_TOTAL_RESERVES",
"H_GFS_EXPENSE",
]
for tid in table_ids:
assert tid.startswith("H_"), f"{tid} should start with H_"
def test_indicator_ids_no_h_prefix(self):
"""Test that indicator IDs don't start with H_."""
indicator_ids = [
"CD_T",
"DB_T",
"PCPI_IX",
"BM_MAI",
"GDP",
]
for ind in indicator_ids:
assert not ind.startswith("H_"), f"{ind} should not start with H_"
class TestTableDataStructure:
"""Tests for expected table data structure."""
def test_table_data_contains_hierarchy_fields(self):
"""Test that table data includes hierarchy metadata."""
expected_fields = [
"order",
"level",
"parent_id",
"series_id",
"title",
"TIME_PERIOD",
"OBS_VALUE",
]
sample_row = {
"order": 1,
"level": 0,
"parent_id": None,
"series_id": "IMF_BOP_SERIES",
"COUNTRY": "United States",
"country_code": "USA",
"title": "Current Account Balance",
"TIME_PERIOD": "2024-12-31",
"OBS_VALUE": -300000000000.0,
}
for field in expected_fields:
assert field in sample_row, f"Missing field: {field}"
class TestTableBuilderWithMockedMetadata:
"""Tests with fully mocked metadata."""
@pytest.fixture
def mock_dependencies(self):
"""Mock all dependencies for table builder."""
class FakeImfParamsBuilder:
"""Lightweight stand-in for ImfParamsBuilder used in table tests."""
def __init__(self, dataflow: str): # noqa: ARG002
self._dimensions = ["COUNTRY", "INDICATOR"]
self._selections = {d: None for d in self._dimensions}
def _get_dimensions_in_order(self):
return list(self._dimensions)
def get_options_for_dimension(self, dim_id):
if dim_id.upper() == "COUNTRY":
return [{"value": "US", "label": "United States"}]
if dim_id.upper() == "INDICATOR":
return [
{"value": "CAB", "label": "CAB"},
{"value": "GOODS", "label": "GOODS"},
{"value": "IND", "label": "IND"},
{"value": "IND_XDC", "label": "IND_XDC"},
]
return [{"value": "*", "label": "*"}]
def set_dimension(self, dim_tuple):
dim_id, value = dim_tuple
self._selections[dim_id] = value
return self._selections
def get_next_dimension_to_select(self):
for dim in self._dimensions:
if self._selections.get(dim) is None:
return dim
return None
with (
patch("openbb_imf.utils.query_builder.ImfQueryBuilder") as MockQueryBuilder,
patch(
"openbb_imf.utils.progressive_helper.ImfParamsBuilder",
FakeImfParamsBuilder,
),
):
mock_qb = MockQueryBuilder.return_value
mock_qb.metadata = MagicMock()
mock_qb.metadata.get_table_in.return_value = {
"id": "H_BOP_STANDARD",
"title": "Balance of Payments Standard",
"hierarchy": [
{
"order": 1,
"level": 0,
"id": "CAB",
"parent_id": None,
"title": "Current Account",
"series_id": "CAB_SERIES",
"dimension_values": {"INDICATOR": ["CAB"]},
},
{
"order": 2,
"level": 1,
"id": "GOODS",
"parent_id": "CAB",
"title": "Goods",
"series_id": "GOODS_SERIES",
"dimension_values": {"INDICATOR": ["GOODS"]},
},
],
}
mock_qb.validate_dimension_constraints = MagicMock()
mock_qb.dataflows = {
"BOP": {
"id": "BOP",
"name": "Balance of Payments",
"structureRef": {"id": "IMF_BOP"},
}
}
yield MockQueryBuilder
def test_get_table_returns_expected_structure(self, mock_dependencies):
"""Test that get_table method exists and has correct signature."""
import inspect
from openbb_imf.utils.table_builder import ImfTableBuilder
builder = ImfTableBuilder()
assert hasattr(builder, "get_table")
sig = inspect.signature(builder.get_table)
params = sig.parameters
assert "dataflow" in params or "table_id" in params
assert builder.query_builder is not None
assert builder.metadata is not None
def test_hierarchy_to_dimension_mapping(self, mock_dependencies):
"""Test that hierarchy codes are mapped to dimensions."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb = mock_dependencies.return_value
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_SERIES",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 100,
},
{
"series_id": "GOODS_SERIES",
"INDICATOR_code": "GOODS",
"indicator_code": "GOODS",
"TIME_PERIOD": "2020",
"OBS_VALUE": 50,
},
],
"metadata": {},
}
mock_qb.metadata.get_dataflow_table_structure.return_value = {
"hierarchy_id": "H_BOP_STANDARD",
"hierarchy_name": "Balance of Payments Standard",
"hierarchy_description": "",
"dataflow_id": "BOP",
"codelist_id": "CL_INDICATOR",
"agency_id": "IMF",
"version": "1.0",
"total_groups": 2,
"type": "presentation",
"indicators": [
{
"order": 1,
"level": 0,
"id": "CAB",
"parent_id": None,
"title": "Current Account",
"series_id": "CAB_SERIES",
"indicator_code": "CAB",
"dimension_values": {"INDICATOR": ["CAB"]},
"dimension_id": "INDICATOR",
},
{
"order": 2,
"level": 1,
"id": "GOODS",
"parent_id": "CAB",
"title": "Goods",
"series_id": "GOODS_SERIES",
"indicator_code": "GOODS",
"dimension_values": {"INDICATOR": ["GOODS"]},
"dimension_id": "INDICATOR",
},
],
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_BOP_STANDARD", COUNTRY="US")
rows_by_series = {row["series_id"]: row for row in result["data"]}
assert set(rows_by_series) == {"CAB_SERIES", "GOODS_SERIES"}
assert rows_by_series["CAB_SERIES"]["order"] == 1
assert rows_by_series["CAB_SERIES"]["level"] == 0
assert rows_by_series["GOODS_SERIES"]["order"] == 2
assert rows_by_series["GOODS_SERIES"]["level"] == 1
def test_indicator_list_truncation_and_post_filtering(self, mock_dependencies):
"""Test that long indicator lists are truncated and post-filtered."""
from openbb_core.app.model.abstract.warning import OpenBBWarning
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb = mock_dependencies.return_value
indicators = []
for i in range(100):
indicators.append(
{
"order": i,
"level": 0,
"id": f"IND_{i}",
"parent_id": None,
"title": f"Indicator {i}",
"series_id": f"SERIES_{i}",
"indicator_code": f"IND_{i}",
"dimension_values": {"INDICATOR": [f"IND_{i}"]},
"dimension_id": "INDICATOR",
}
)
mock_qb.metadata.get_dataflow_table_structure.return_value = {
"hierarchy_id": "H_LARGE",
"hierarchy_name": "Large Table",
"hierarchy_description": "",
"dataflow_id": "BOP",
"codelist_id": "CL_INDICATOR",
"agency_id": "IMF",
"version": "1.0",
"total_groups": 100,
"type": "presentation",
"indicators": indicators,
}
mock_qb.fetch_data.return_value = {"data": [], "metadata": {}}
builder = ImfTableBuilder()
with pytest.warns(OpenBBWarning, match="Progressive constraint filtering"):
builder.get_table("BOP", "H_LARGE", COUNTRY="US")
call_args = mock_qb.fetch_data.call_args
assert call_args is not None
kwargs = call_args[1]
if "INDICATOR" in kwargs:
assert len(kwargs["INDICATOR"]) < 1500
def test_prefix_matching_suffixed_indicators(self, mock_dependencies):
"""Test matching of indicators with suffixes."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb = mock_dependencies.return_value
mock_qb.metadata.get_dataflow_table_structure.return_value = {
"hierarchy_id": "H_SUFFIX",
"hierarchy_name": "Suffix Table",
"hierarchy_description": "",
"dataflow_id": "BOP",
"codelist_id": "CL_INDICATOR",
"agency_id": "IMF",
"version": "1.0",
"total_groups": 1,
"type": "presentation",
"indicators": [
{
"order": 1,
"level": 0,
"id": "IND",
"parent_id": None,
"title": "Indicator",
"series_id": "IND_SERIES",
"indicator_code": "IND",
"dimension_values": {"INDICATOR": ["IND"]}, # Base code
"dimension_id": "INDICATOR",
}
],
}
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "IND_XDC",
"INDICATOR_code": "IND_XDC",
"indicator_code": "IND_XDC",
"TIME_PERIOD": "2020",
"OBS_VALUE": 100,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_SUFFIX", COUNTRY="US")
row = result["data"][0]
assert row["series_id"] == "IND_XDC"
assert row["order"] == 1
assert row["level"] == 0
def test_time_range_validation_in_table_flow(self, mock_dependencies):
"""Test that time range validation occurs in table flow."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb = mock_dependencies.return_value
mock_qb.metadata.get_dataflow_table_structure.return_value = {
"hierarchy_id": "H_BOP_STANDARD",
"hierarchy_name": "Balance of Payments Standard",
"hierarchy_description": "",
"dataflow_id": "BOP",
"codelist_id": "CL_INDICATOR",
"agency_id": "IMF",
"version": "1.0",
"total_groups": 1,
"type": "presentation",
"indicators": [
{
"order": 1,
"level": 0,
"id": "CAB",
"parent_id": None,
"title": "Current Account",
"series_id": "CAB_SERIES",
"indicator_code": "CAB",
"dimension_values": {"INDICATOR": ["CAB"]},
"dimension_id": "INDICATOR",
}
],
}
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_SERIES",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 100,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
builder.get_table(
"BOP", "H_BOP_STANDARD", COUNTRY="US", start_date="2020", end_date="2021"
)
mock_qb.fetch_data.assert_called()
call_kwargs = mock_qb.fetch_data.call_args[1]
assert call_kwargs.get("start_date") == "2020"
assert call_kwargs.get("end_date") == "2021"
class TestBopCompositeHierarchyMatching:
"""Regression tests for BOP hierarchy matching."""
@pytest.fixture
def mock_bop_dependencies(self):
"""Mock query builder + params builder for BOP composite matching tests."""
class FakeImfParamsBuilder:
def __init__(self, dataflow: str): # noqa: ARG002
self._dimensions = ["COUNTRY", "INDICATOR", "BOP_ACCOUNTING_ENTRY"]
self._selections = {d: None for d in self._dimensions}
def _get_dimensions_in_order(self):
return list(self._dimensions)
def get_options_for_dimension(self, dim_id):
dim_id = dim_id.upper()
if dim_id == "COUNTRY":
return [{"value": "AU", "label": "Australia"}]
if dim_id == "INDICATOR":
return [
{"value": "SINCEX", "label": "SINCEX"},
{"value": "O", "label": "O"},
]
if dim_id == "BOP_ACCOUNTING_ENTRY":
return [
{"value": "NETCD_T", "label": "Net"},
{"value": "CD_T", "label": "Credit"},
{"value": "DB_T", "label": "Debit"},
{"value": "A_P", "label": "Assets"},
{"value": "L_P", "label": "Liabilities"},
]
return [{"value": "*", "label": "*"}]
def set_dimension(self, dim_tuple):
dim_id, value = dim_tuple
self._selections[dim_id] = value
return self._selections
def get_next_dimension_to_select(self):
for dim in self._dimensions:
if self._selections.get(dim) is None:
return dim
return None
with (
patch("openbb_imf.utils.query_builder.ImfQueryBuilder") as MockQueryBuilder,
patch(
"openbb_imf.utils.progressive_helper.ImfParamsBuilder",
FakeImfParamsBuilder,
),
):
mock_qb = MockQueryBuilder.return_value
mock_qb.validate_dimension_constraints = MagicMock()
mock_qb.metadata = MagicMock()
mock_qb.metadata.dataflows = {
"BOP": {
"id": "BOP",
"name": "Balance of Payments",
"structureRef": {"id": ""},
}
}
mock_qb.metadata.datastructures = {}
mock_qb.metadata._codelist_cache = {}
mock_qb.dataflows = mock_qb.metadata.dataflows
mock_qb.metadata.get_dataflow_table_structure.return_value = {
"hierarchy_id": "H_BOP_FAKE",
"hierarchy_name": "BOP Fake",
"hierarchy_description": "",
"dataflow_id": "BOP",
"codelist_id": "CL_BOP_INDICATOR",
"agency_id": "IMF",
"version": "1.0",
"total_groups": 7,
"type": "presentation",
"indicators": [
{
"order": 1,
"depth": 0,
"id": "NETCD_T",
"parent_id": None,
"label": "Net (credits less debits)",
"series_id": "",
"indicator_code": "NETCD_T",
"is_group": True,
"dimension_id": "BOP_ACCOUNTING_ENTRY",
},
{
"order": 2,
"depth": 1,
"id": "SINCEX_CD",
"parent_id": "NETCD_T",
"label": "Secondary income excluding exceptional financing",
"series_id": "",
"indicator_code": "SINCEX",
"is_group": False,
"dimension_id": "INDICATOR",
},
{
"order": 3,
"depth": 1,
"id": "SINCEX_DB",
"parent_id": "NETCD_T",
"label": "Secondary income excluding exceptional financing",
"series_id": "",
"indicator_code": "SINCEX",
"is_group": False,
"dimension_id": "INDICATOR",
},
{
"order": 4,
"depth": 0,
"id": "A_P",
"parent_id": None,
"label": "Assets, Positions",
"series_id": "",
"indicator_code": "A_P",
"is_group": True,
"dimension_id": "BOP_ACCOUNTING_ENTRY",
},
{
"order": 5,
"depth": 0,
"id": "L_P",
"parent_id": None,
"label": "Liabilities, Positions",
"series_id": "",
"indicator_code": "L_P",
"is_group": True,
"dimension_id": "BOP_ACCOUNTING_ENTRY",
},
{
"order": 6,
"depth": 1,
"id": "O_A",
"parent_id": "A_P",
"label": "Other investment",
"series_id": "",
"indicator_code": "O",
"is_group": False,
"dimension_id": "INDICATOR",
},
{
"order": 7,
"depth": 1,
"id": "O_L",
"parent_id": "L_P",
"label": "Other investment",
"series_id": "",
"indicator_code": "O",
"is_group": False,
"dimension_id": "INDICATOR",
},
],
}
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "",
"INDICATOR_code": "SINCEX",
"BOP_ACCOUNTING_ENTRY_code": "CD_T",
"REF_AREA_code": "AU",
"TIME_PERIOD": "2024-12-31",
"OBS_VALUE": 9.86,
},
{
"series_id": "",
"INDICATOR_code": "SINCEX",
"BOP_ACCOUNTING_ENTRY_code": "DB_T",
"REF_AREA_code": "AU",
"TIME_PERIOD": "2024-12-31",
"OBS_VALUE": 10.04,
},
{
"series_id": "",
"INDICATOR_code": "O",
"BOP_ACCOUNTING_ENTRY_code": "A_P",
"REF_AREA_code": "AU",
"TIME_PERIOD": "2024-12-31",
"OBS_VALUE": 1.0,
},
{
"series_id": "",
"INDICATOR_code": "O",
"BOP_ACCOUNTING_ENTRY_code": "L_P",
"REF_AREA_code": "AU",
"TIME_PERIOD": "2024-12-31",
"OBS_VALUE": 2.0,
},
],
"metadata": {},
}
yield MockQueryBuilder
def test_bop_credit_debit_resolves_under_net_parent(self, mock_bop_dependencies):
"""Credit and Debit rows must resolve under the hierarchy's Net parent."""
from openbb_imf.utils.table_builder import ImfTableBuilder
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_BOP_FAKE", COUNTRY="AU")
rows = [r for r in result["data"] if r.get("INDICATOR_code") == "SINCEX"]
assert len(rows) == 2
for row in rows:
assert row.get("parent_code") == "NETCD_T"
assert "excluding exceptional financing" in (row.get("title") or "")
titles = {r.get("title") for r in rows}
assert any(t and t.endswith(", Credit") for t in titles)
assert any(t and t.endswith(", Debit") for t in titles)
def test_bop_assets_liabilities_remain_distinct_paths(self, mock_bop_dependencies):
"""Assets and Liabilities must remain separate hierarchy paths."""
from openbb_imf.utils.table_builder import ImfTableBuilder
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_BOP_FAKE", COUNTRY="AU")
rows = [r for r in result["data"] if r.get("INDICATOR_code") == "O"]
assert len(rows) == 2
parent_codes = {r.get("parent_code") for r in rows}
assert parent_codes == {"A_P", "L_P"}
titles = {r.get("title") for r in rows}
assert any(t and t.endswith(", Assets") for t in titles)
assert any(t and t.endswith(", Liabilities") for t in titles)
class TestTableBuilderErrorHandling:
"""Tests for error handling in table builder."""
@pytest.fixture
def mock_query_builder(self):
"""Mock ImfQueryBuilder."""
with patch(
"openbb_imf.utils.query_builder.ImfQueryBuilder"
) as MockQueryBuilder:
mock_instance = MockQueryBuilder.return_value
mock_instance.metadata = MagicMock()
mock_instance.dataflows = {"BOP": {"id": "BOP"}}
mock_instance.validate_dimension_constraints = MagicMock()
yield MockQueryBuilder
def test_invalid_dataflow_raises_error(self, mock_query_builder):
"""Test that invalid dimension constraints raises appropriate error."""
from openbb_imf.utils.table_builder import ImfTableBuilder
builder = ImfTableBuilder()
mock_query_builder.return_value.validate_dimension_constraints.side_effect = (
ValueError("Invalid dataflow: INVALID_DATAFLOW")
)
with pytest.raises(ValueError) as exc_info:
builder._validate_dimension_constraints("INVALID_DATAFLOW", COUNTRY="USA")
assert "Invalid" in str(exc_info.value)
def test_dimension_constraint_validation_error(self, mock_query_builder):
"""Test that invalid dimension values raise validation error."""
from openbb_imf.utils.table_builder import ImfTableBuilder
builder = ImfTableBuilder()
mock_query_builder.return_value.validate_dimension_constraints.side_effect = (
ValueError("Invalid country: XYZ")
)
with pytest.raises(ValueError) as exc_info:
builder._validate_dimension_constraints("BOP", COUNTRY="XYZ")
assert (
"Invalid" in str(exc_info.value) or "country" in str(exc_info.value).lower()
)
class FakeImfParamsBuilder:
"""Lightweight stand-in for ``ImfParamsBuilder`` used by table-builder tests."""
def __init__(
self,
dimensions: list[str],
options: dict[str, list[dict]] | None = None,
constraints_response: dict | None = None,
):
"""Build a fake params builder over a fixed set of dimensions."""
self._dimensions = list(dimensions)
self._options = options or {}
self._selections: dict[str, str | None] = {d: None for d in dimensions}
self._last_constraints_response = constraints_response or {}
def _get_dimensions_in_order(self):
return list(self._dimensions)
def get_options_for_dimension(self, dim_id):
return self._options.get(dim_id, [{"value": "*", "label": "*"}])
def set_dimension(self, tup):
self._selections[tup[0]] = tup[1]
return self._selections
def get_next_dimension_to_select(self):
for dim in self._dimensions:
if self._selections.get(dim) is None:
return dim
return None
@pytest.fixture
def mock_qb_factory():
"""Return a factory that yields a fully patched table-builder environment."""
def factory(
*,
dimensions=("COUNTRY", "INDICATOR"),
options=None,
indicators=None,
dataflows=None,
codelist_cache=None,
fetch_return=None,
table_structure=None,
get_dataflow_hierarchies=None,
constraints_response=None,
):
if dataflows is None:
dataflows = {
"BOP": {
"id": "BOP",
"name": "Balance of Payments",
"structureRef": {"id": "DSD"},
}
}
if codelist_cache is None:
codelist_cache = {}
if options is None:
options = {}
def build_params(dataflow_id): # noqa: ARG001
return FakeImfParamsBuilder(
dimensions=list(dimensions),
options=options,
constraints_response=constraints_response,
)
ctx_qb = patch("openbb_imf.utils.query_builder.ImfQueryBuilder")
ctx_ph = patch(
"openbb_imf.utils.progressive_helper.ImfParamsBuilder",
new=build_params,
)
MockQB = ctx_qb.start()
ctx_ph.start()
mock_qb = MockQB.return_value
mock_qb.metadata = MagicMock()
mock_qb.metadata.dataflows = dataflows
mock_qb.metadata.datastructures = {
"DSD": {
"id": "DSD",
"dimensions": [
{"id": dim, "position": idx} for idx, dim in enumerate(dimensions)
],
}
}
mock_qb.metadata._codelist_cache = codelist_cache
mock_qb.metadata._resolve_codelist_id = MagicMock(
return_value="CL_BOP_INDICATOR"
)
mock_qb.metadata._get_dimension_for_codelist = MagicMock(return_value=None)
mock_qb.dataflows = dataflows
mock_qb.validate_dimension_constraints = MagicMock()
mock_qb.metadata.get_dataflow_hierarchies = MagicMock(
return_value=get_dataflow_hierarchies
if get_dataflow_hierarchies is not None
else [{"id": "H_TEST"}]
)
mock_qb.metadata.get_dataflow_table_structure = MagicMock(
return_value=table_structure
or {
"hierarchy_id": "H_TEST",
"hierarchy_name": "Test",
"hierarchy_description": "",
"dataflow_id": "BOP",
"codelist_id": "CL_INDICATOR",
"agency_id": "IMF",
"version": "1.0",
"total_groups": 0,
"type": "presentation",
"indicators": indicators or [],
}
)
mock_qb.fetch_data = MagicMock(
return_value=fetch_return or {"data": [], "metadata": {}}
)
teardown = [ctx_qb, ctx_ph]
return mock_qb, MockQB, teardown
cleanups: list = []
yielded_factories: list = []
def wrapped(**kwargs):
mock_qb, MockQB, teardown = factory(**kwargs)
cleanups.extend(teardown)
yielded_factories.append((mock_qb, MockQB))
return mock_qb, MockQB
yield wrapped
for ctx in cleanups:
ctx.stop()
class TestGetTableValidation:
"""Validation/error-path tests for ``ImfTableBuilder.get_table``."""
def test_combined_table_id_with_mismatched_dataflow_raises(self, mock_qb_factory):
"""Passing ``dataflow`` that conflicts with the table_id prefix raises."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb_factory()
builder = ImfTableBuilder()
with pytest.raises(ValueError, match="Dataflow mismatch"):
builder.get_table(dataflow="OTHER", table_id="BOP::H_X")
def test_combined_table_id_parsed(self, mock_qb_factory):
"""Combined ``dataflow::table_id`` is parsed when only ``table_id`` is given."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "Current Account",
"series_id": "CAB_SERIES",
"indicator_code": "CAB",
"is_group": False,
"dimension_id": "INDICATOR",
}
],
options={"INDICATOR": [{"value": "CAB", "label": "CAB"}]},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_SERIES",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table(table_id="BOP::H_TEST")
assert result["table_metadata"]["hierarchy_id"] == "H_TEST"
def test_missing_dataflow_raises(self, mock_qb_factory):
"""Calling without ``dataflow`` or ``table_id`` raises."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb_factory()
builder = ImfTableBuilder()
with pytest.raises(ValueError, match="dataflow is required"):
builder.get_table()
def test_no_table_id_single_available(self, mock_qb_factory):
"""A single available table is auto-selected when ``table_id`` is None."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_SERIES",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={"INDICATOR": [{"value": "CAB", "label": "CAB"}]},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_SERIES",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP")
assert result["table_metadata"]["hierarchy_id"] == "H_TEST"
def test_no_available_tables_raises(self, mock_qb_factory):
"""No available tables raises a clear error."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb_factory(get_dataflow_hierarchies=[])
builder = ImfTableBuilder()
with pytest.raises(ValueError, match="No tables/hierarchies found"):
builder.get_table("BOP")
def test_no_matching_indicators_after_filter_raises(self, mock_qb_factory):
"""Filtering with ``indicators=`` that matches nothing raises."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "A",
"parent_id": None,
"label": "A",
"series_id": "",
"indicator_code": "A",
"dimension_id": "INDICATOR",
}
],
)
builder = ImfTableBuilder()
with pytest.raises(ValueError, match="No indicators match"):
builder.get_table("BOP", "H_TEST", indicators="MISSING")
class TestDimensionMapping:
"""Tests for the dimension-mapping branches in ``get_table``."""
def test_code_urn_codelist_label_skipped(self, mock_qb_factory):
"""Codelists ending in ``_LABELS`` are skipped without raising."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "X",
"parent_id": None,
"label": "X",
"series_id": "",
"indicator_code": "X",
"code_urn": "urn:sdmx:org.sdmx.infomodel.codelist.Code=IMF.STA:CL_X_LABELS(1.0).X",
},
],
)
builder = ImfTableBuilder()
with pytest.raises(ValueError, match="No valid indicator codes"):
builder.get_table("BOP", "H_TEST")
def test_code_urn_unparsable_warns_and_skips(self, mock_qb_factory):
"""A bad ``code_urn`` emits an ``OpenBBWarning`` and skips the entry."""
from openbb_core.app.model.abstract.warning import OpenBBWarning
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "X",
"parent_id": None,
"label": "X",
"series_id": "",
"indicator_code": "X",
"code_urn": "garbage",
}
],
)
builder = ImfTableBuilder()
with pytest.warns(OpenBBWarning, match="Could not parse codelist"):
with pytest.raises(ValueError):
builder.get_table("BOP", "H_TEST")
def test_dimension_pattern_fallback(self, mock_qb_factory):
"""Pattern fallback resolves ``CL_BOP_INDICATOR`` to ``INDICATOR``."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_SERIES",
"indicator_code": "CAB",
"code_urn": "urn:sdmx:org.sdmx.infomodel.codelist.Code=IMF.STA:CL_BOP_INDICATOR(1.0).CAB",
}
],
options={"INDICATOR": [{"value": "CAB", "label": "CAB"}]},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_SERIES",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST")
assert len(result["data"]) >= 1
def test_unresolvable_codelist_warns_and_skips(self, mock_qb_factory):
"""An unresolvable codelist warns and skips."""
from openbb_core.app.model.abstract.warning import OpenBBWarning
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "X",
"parent_id": None,
"label": "X",
"series_id": "",
"indicator_code": "X",
"code_urn": "urn:sdmx:org.sdmx.infomodel.codelist.Code=IMF.STA:CL_RANDOM_THING(1.0).X",
}
],
)
builder = ImfTableBuilder()
with pytest.warns(OpenBBWarning, match="Could not map codelist"):
with pytest.raises(ValueError):
builder.get_table("BOP", "H_TEST")
class TestKwargsNormalization:
"""Tests for the case-insensitive kwargs handling."""
def test_lowercase_country_normalized(self, mock_qb_factory):
"""Lower-case ``country=`` matches the ``COUNTRY`` dimension."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
dimensions=("REF_AREA", "INDICATOR"),
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_SERIES",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"REF_AREA": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_SERIES",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
builder.get_table("BOP", "H_TEST", country="USA")
kwargs = mock_qb.fetch_data.call_args[1]
assert kwargs["REF_AREA"] == "USA"
def test_invalid_user_value_raises(self, mock_qb_factory):
"""An invalid user-supplied dimension value raises ``ValueError``."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb_factory(
dimensions=("COUNTRY", "INDICATOR"),
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
builder = ImfTableBuilder()
with pytest.raises(ValueError, match="Invalid value"):
builder.get_table("BOP", "H_TEST", COUNTRY="XYZ")
def test_unknown_dim_in_dimension_codes(self, mock_qb_factory):
"""A dim outside ``dims_in_order`` populates ``fetch_kwargs`` via fallback."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
dimensions=("COUNTRY",),
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_SERIES",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_SERIES",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
builder.get_table("BOP", "H_TEST", COUNTRY="USA")
class TestPostFiltering:
"""Tests for the post-fetch filtering path."""
def test_oversized_indicator_list_uses_wildcard_and_post_filters(
self, mock_qb_factory
):
"""Joined-codes longer than 850 chars uses ``*`` then post-filters rows."""
from openbb_imf.utils.table_builder import ImfTableBuilder
indicators = [
{
"order": i,
"depth": 0,
"id": f"IND{i}",
"parent_id": None,
"label": f"Indicator {i}",
"series_id": f"S{i}",
"indicator_code": f"IND_THIS_IS_A_LONG_NAME_{i}",
"dimension_id": "INDICATOR",
}
for i in range(80)
]
options = {
"INDICATOR": [
{"value": ind["indicator_code"], "label": ind["indicator_code"]}
for ind in indicators
],
"COUNTRY": [{"value": "USA", "label": "USA"}],
}
mock_qb, _ = mock_qb_factory(
indicators=indicators,
options=options,
)
# Return rows for only 2 of the 80 indicators -> exercises post-filter
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": f"S{i}",
"INDICATOR_code": indicators[i]["indicator_code"],
"indicator_code": indicators[i]["indicator_code"],
"TIME_PERIOD": "2020",
"OBS_VALUE": i,
}
for i in range(80)
]
+ [
{
"series_id": "EXTRA",
"INDICATOR_code": "NOT_IN_HIERARCHY",
"indicator_code": "NOT_IN_HIERARCHY",
"TIME_PERIOD": "2020",
"OBS_VALUE": 999,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
# post-filter drops "NOT_IN_HIERARCHY"
codes = {r.get("INDICATOR_code") for r in result["data"]}
assert "NOT_IN_HIERARCHY" not in codes
fetch_kwargs = mock_qb.fetch_data.call_args[1]
# Because joined codes > 850, the dim is reduced to ``*``
assert fetch_kwargs["INDICATOR"] == "*"
class TestTitleAndUnitInference:
"""Tests for the title / unit-inference branches."""
def test_gfs_indicator_with_unit_suffix(self, mock_qb_factory):
"""GFS-flavoured indicators infer ``unit`` from the code suffix."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
dataflows={
"GFS": {
"id": "GFS",
"name": "GFS",
"structureRef": {"id": "DSD"},
}
},
indicators=[
{
"order": 1,
"depth": 0,
"id": "REV",
"parent_id": None,
"label": "Revenue",
"series_id": "S1",
"indicator_code": "REV_USD",
"dimension_id": "INDICATOR",
}
],
options={
"INDICATOR": [{"value": "REV_USD", "label": "REV_USD"}],
"COUNTRY": [{"value": "USA", "label": "USA"}],
},
codelist_cache={"CL_UNIT": {"USD": "US dollar"}},
)
mock_qb.metadata._resolve_codelist_id = MagicMock(return_value="CL_GFS_REV")
mock_qb.metadata._codelist_cache["CL_GFS_REV"] = {
"REV_USD": "Revenue, US dollar"
}
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "S1",
"INDICATOR_code": "REV_USD",
"indicator_code": "REV_USD",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("GFS", "H_TEST", COUNTRY="USA")
row = next(r for r in result["data"] if r.get("INDICATOR_code") == "REV_USD")
assert row["unit"] == "US dollar"
def test_path_label_dataflow_uses_label(self, mock_qb_factory):
"""``CL_DIP_INDICATOR`` indicator codelist forces title from ``label``."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "GDP",
"parent_id": None,
"label": "Gross Domestic Product",
"series_id": "S1",
"indicator_code": "GDP",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "GDP", "label": "GDP"}],
},
)
mock_qb.metadata._resolve_codelist_id = MagicMock(
return_value="CL_DIP_INDICATOR"
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "S1",
"INDICATOR_code": "GDP",
"indicator_code": "GDP",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
row = result["data"][0]
assert row["title"] == "Gross Domestic Product"
def test_indicator_label_unit_suffix_trimmed(self, mock_qb_factory):
"""A unit suffix is trimmed from the indicator name."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "GDP",
"parent_id": None,
"label": "GDP",
"series_id": "S1",
"indicator_code": "GDP",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "GDP", "label": "GDP"}],
},
codelist_cache={
"CL_BOP_INDICATOR": {"GDP": "Gross Domestic Product, US dollar"},
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "S1",
"INDICATOR_code": "GDP",
"indicator_code": "GDP",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
row = next(r for r in result["data"] if r.get("INDICATOR_code") == "GDP")
assert row["title"] == "Gross Domestic Product"
def test_cpi_index_type_appended(self, mock_qb_factory):
"""CPI dataflow with a non-``CPI`` INDEX_TYPE appends it to the title."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
dataflows={
"CPI": {
"id": "CPI",
"name": "CPI",
"structureRef": {"id": "DSD"},
}
},
indicators=[
{
"order": 1,
"depth": 0,
"id": "PCPI",
"parent_id": None,
"label": "Consumer Prices",
"series_id": "S1",
"indicator_code": "PCPI",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "PCPI", "label": "PCPI"}],
},
codelist_cache={"CL_BOP_INDICATOR": {"PCPI": "Headline CPI"}},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "S1",
"INDICATOR_code": "PCPI",
"indicator_code": "PCPI",
"INDEX_TYPE_code": "FOOD",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("CPI", "H_TEST", COUNTRY="USA")
row = next(r for r in result["data"] if r.get("INDICATOR_code") == "PCPI")
assert row["title"].endswith("(FOOD)")
def test_currency_label_appended(self, mock_qb_factory):
"""A CURRENCY label distinct from the unit is appended to the title."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "GDP",
"parent_id": None,
"label": "GDP",
"series_id": "S1",
"indicator_code": "GDP",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "GDP", "label": "GDP"}],
},
codelist_cache={"CL_BOP_INDICATOR": {"GDP": "Gross Domestic Product"}},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "S1",
"INDICATOR_code": "GDP",
"indicator_code": "GDP",
"CURRENCY_code": "EUR",
"CURRENCY": "Euro",
"unit_code": "USD",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
row = next(r for r in result["data"] if r.get("INDICATOR_code") == "GDP")
assert "(Euro)" in row["title"]
def test_iip_assets_suffix_added(self, mock_qb_factory):
"""IIP-style series IDs get an ``(Assets)`` suffix when missing context."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "O",
"parent_id": None,
"label": "Other Investment",
"series_id": "BOP_IIP_A_P_O",
"indicator_code": "O",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "O", "label": "O"}],
},
codelist_cache={"CL_BOP_INDICATOR": {"O": "Other Investment"}},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "BOP_IIP_A_P_O",
"INDICATOR_code": "O",
"indicator_code": "O",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
row = next(r for r in result["data"] if r.get("INDICATOR_code") == "O")
assert "(Assets)" in row["title"]
def test_iip_liabilities_suffix_added(self, mock_qb_factory):
"""IIP-style series IDs get an ``(Liabilities)`` suffix when needed."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "O",
"parent_id": None,
"label": "Other Investment",
"series_id": "BOP_IIP_L_P_O",
"indicator_code": "O",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "O", "label": "O"}],
},
codelist_cache={"CL_BOP_INDICATOR": {"O": "Other Investment"}},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "BOP_IIP_L_P_O",
"INDICATOR_code": "O",
"indicator_code": "O",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
row = next(r for r in result["data"] if r.get("INDICATOR_code") == "O")
assert "(Liabilities)" in row["title"]
class TestHeaderRows:
"""Tests for the category-header row injection."""
def test_unmatched_order_creates_header_row(self, mock_qb_factory):
"""A hierarchy order not present in data is added as a category header."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "PARENT",
"parent_id": None,
"label": "Header Title",
"series_id": "",
"indicator_code": "PARENT",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "CHILD",
"parent_id": "PARENT",
"label": "Child",
"series_id": "CHILD_SERIES",
"indicator_code": "CHILD",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "PARENT", "label": "PARENT"},
{"value": "CHILD", "label": "CHILD"},
],
},
codelist_cache={
"CL_BOP_INDICATOR": {"CHILD": "Child indicator"},
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CHILD_SERIES",
"INDICATOR_code": "CHILD",
"indicator_code": "CHILD",
"scale": "Units",
"unit": "US dollar",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
headers = [r for r in result["data"] if r.get("is_category_header")]
assert any("Header Title" in (h.get("title") or "") for h in headers)
def test_header_with_gfs_unit_inference(self, mock_qb_factory):
"""A GFS dataflow infers header units from the child's code suffix."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
dataflows={
"GFS": {
"id": "GFS",
"name": "GFS",
"structureRef": {"id": "DSD"},
}
},
indicators=[
{
"order": 1,
"depth": 0,
"id": "REV",
"parent_id": None,
"label": "Revenue",
"series_id": "",
"indicator_code": "REV",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "REV_USD",
"parent_id": "REV",
"label": "Revenue USD",
"series_id": "REV_USD_S",
"indicator_code": "REV_USD",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "REV", "label": "REV"},
{"value": "REV_USD", "label": "REV_USD"},
],
},
codelist_cache={
"CL_GFS_REV": {"REV_USD": "Revenue, US dollar"},
"CL_UNIT": {"USD": "US dollar"},
},
)
mock_qb.metadata._resolve_codelist_id = MagicMock(return_value="CL_GFS_REV")
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "REV_USD_S",
"INDICATOR_code": "REV_USD",
"indicator_code": "REV_USD",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("GFS", "H_TEST", COUNTRY="USA")
headers = [r for r in result["data"] if r.get("is_category_header")]
assert headers
assert any("US dollar" in (h.get("title") or "") for h in headers)
class TestDatasetMetadataMerge:
"""Tests for dataset-metadata merging into ``table_metadata``."""
def test_dataset_metadata_merged(self, mock_qb_factory):
"""``dataset`` metadata is popped and merged into ``table_metadata``."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_SERIES",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_SERIES",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {
"dataset": {
"dataflow_name": "Balance of Payments",
"dataflow_description": "BOP statistics",
"publisher": "IMF",
"license": "CC",
}
},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
meta = result["table_metadata"]
assert meta["dataflow_name"] == "Balance of Payments"
assert meta["publisher"] == "IMF"
assert meta["license"] == "CC"
class TestTimeRangeValidation:
"""Tests for the time-range validation in ``get_table``."""
def test_no_overlap_raises(self, mock_qb_factory):
"""Request whose dates fall outside the available range raises."""
from openbb_imf.utils.table_builder import ImfTableBuilder
constraints = {
"full_response": {
"data": {
"dataConstraints": [
{
"annotations": [
{"id": "time_period_start", "title": "2010"},
{"id": "time_period_end", "title": "2020"},
]
}
]
}
}
}
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
constraints_response=constraints,
)
builder = ImfTableBuilder()
with pytest.raises(
ValueError, match="No data available for the requested time"
):
builder.get_table(
"BOP", "H_TEST", COUNTRY="USA", start_date="2025", end_date="2026"
)
def test_end_date_before_available_raises(self, mock_qb_factory):
"""A request whose end_date is before the available start raises."""
from openbb_imf.utils.table_builder import ImfTableBuilder
constraints = {
"full_response": {
"data": {
"dataConstraints": [
{
"annotations": [
{"id": "time_period_start", "title": "2015-01-01"},
{"id": "time_period_end", "title": "2020-12-31"},
]
}
]
}
}
}
mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
constraints_response=constraints,
)
builder = ImfTableBuilder()
with pytest.raises(ValueError, match="No data available for the requested"):
builder.get_table(
"BOP", "H_TEST", COUNTRY="USA", start_date="2000-01", end_date="2010-12"
)
def test_date_parse_error_breaks_out(self, mock_qb_factory):
"""A malformed time-period annotation breaks out of validation without raising."""
from openbb_imf.utils.table_builder import ImfTableBuilder
constraints = {
"full_response": {
"data": {
"dataConstraints": [
{
"annotations": [
{"id": "time_period_start", "title": "not-a-date"},
{"id": "time_period_end", "title": "2020-12-31"},
]
}
]
}
}
}
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_S",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
constraints_response=constraints,
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_S",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
# Should not raise — parse failure breaks the validation loop
builder.get_table(
"BOP", "H_TEST", COUNTRY="USA", start_date="2020-01", end_date="2020-12"
)
def test_quarterly_range_parses(self, mock_qb_factory):
"""Quarterly date strings (``YYYY-Q1``) parse without raising."""
from openbb_imf.utils.table_builder import ImfTableBuilder
constraints = {
"full_response": {
"data": {
"dataConstraints": [
{
"annotations": [
{"id": "time_period_start", "title": "2010-Q1"},
{"id": "time_period_end", "title": "2020-Q4"},
]
}
]
}
}
}
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_S",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
constraints_response=constraints,
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_S",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2015-Q1",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
builder.get_table(
"BOP", "H_TEST", COUNTRY="USA", start_date="2015-Q1", end_date="2018-Q2"
)
class TestIndicatorFilters:
"""Tests exercising the ``parent_id`` / ``depth`` / ``indicators`` filters."""
@pytest.fixture
def indicators(self):
"""Build a small three-level hierarchy."""
return [
{
"order": 1,
"depth": 0,
"id": "P1",
"parent_id": None,
"label": "P1",
"series_id": "P1_S",
"indicator_code": "P1",
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "C1",
"parent_id": "P1",
"label": "C1",
"series_id": "C1_S",
"indicator_code": "C1",
"dimension_id": "INDICATOR",
},
{
"order": 3,
"depth": 1,
"id": "C2",
"parent_id": "P1",
"label": "C2",
"series_id": "C2_S",
"indicator_code": "C2",
"dimension_id": "INDICATOR",
},
]
def test_parent_id_filter(self, mock_qb_factory, indicators):
"""``parent_id`` selects only direct children."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=indicators,
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "C1", "label": "C1"},
{"value": "C2", "label": "C2"},
],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "C1_S",
"INDICATOR_code": "C1",
"indicator_code": "C1",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", parent_id="P1", COUNTRY="USA")
codes = {
r["INDICATOR_code"]
for r in result["data"]
if not r.get("is_category_header")
}
assert "C1" in codes
def test_depth_filter(self, mock_qb_factory, indicators):
"""``depth=0`` selects only top-level indicators."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=indicators,
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "P1", "label": "P1"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "P1_S",
"INDICATOR_code": "P1",
"indicator_code": "P1",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", depth=0, COUNTRY="USA")
assert result["data"]
def test_indicators_list_filter(self, mock_qb_factory, indicators):
"""A list of indicator codes restricts the hierarchy."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=indicators,
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "C1", "label": "C1"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "C1_S",
"INDICATOR_code": "C1",
"indicator_code": "C1",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", indicators=["C1"], COUNTRY="USA")
assert result["data"]
class TestWildcardFallback:
"""Tests for the >1500-character indicator-list fallback branch."""
def test_extra_dim_huge_codes_falls_back_to_wildcard(self, mock_qb_factory):
"""A non-``INDICATOR`` dim with >1500 joined codes collapses to ``*``."""
from openbb_imf.utils.table_builder import ImfTableBuilder
codes = [f"VERY_LONG_CODE_{i:04d}" for i in range(120)]
indicators = [
{
"order": i,
"depth": 0,
"id": code,
"parent_id": None,
"label": code,
"series_id": "",
"indicator_code": code,
"dimension_id": "EXTRA",
}
for i, code in enumerate(codes)
]
mock_qb, _ = mock_qb_factory(
dimensions=("COUNTRY",),
indicators=indicators,
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"EXTRA": [{"value": c, "label": c} for c in codes],
},
)
mock_qb.fetch_data.return_value = {"data": [], "metadata": {}}
builder = ImfTableBuilder()
builder.get_table("BOP", "H_TEST", COUNTRY="USA")
kwargs = mock_qb.fetch_data.call_args[1]
assert kwargs["EXTRA"] == "*"
def test_extra_dim_no_match_warns_and_falls_through(self, mock_qb_factory):
"""A non-``INDICATOR`` dim with no matching codes emits a warning and proceeds."""
from openbb_core.app.model.abstract.warning import OpenBBWarning
from openbb_imf.utils.table_builder import ImfTableBuilder
indicators = [
{
"order": 1,
"depth": 0,
"id": "X",
"parent_id": None,
"label": "X",
"series_id": "",
"indicator_code": "ZZZ",
"dimension_id": "EXTRA",
}
]
mock_qb, _ = mock_qb_factory(
dimensions=("COUNTRY",),
indicators=indicators,
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"EXTRA": [{"value": "OTHER", "label": "OTHER"}],
},
)
mock_qb.fetch_data.return_value = {"data": [], "metadata": {}}
builder = ImfTableBuilder()
with pytest.warns(OpenBBWarning, match="Progressive constraint"):
builder.get_table("BOP", "H_TEST", COUNTRY="USA")
class TestProgressiveExceptionFallback:
"""Tests for the warning-fallback when progressive filtering raises."""
def test_keyerror_warning_fallback(self, mock_qb_factory):
"""A non-validation ``KeyError`` from the builder triggers the unfiltered fallback."""
from openbb_core.app.model.abstract.warning import OpenBBWarning
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_S",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_S",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
class BoomBuilder(FakeImfParamsBuilder):
def __init__(self): # noqa: D107
super().__init__(["COUNTRY", "INDICATOR"])
self._first_call = True
def get_options_for_dimension(self, dim_id):
if self._first_call:
self._first_call = False
raise KeyError("boom")
return [{"value": "USA", "label": "USA"}]
with patch(
"openbb_imf.utils.progressive_helper.ImfParamsBuilder",
lambda _df: BoomBuilder(),
):
builder = ImfTableBuilder()
with pytest.warns(OpenBBWarning, match="Progressive constraint"):
builder.get_table("BOP", "H_TEST", COUNTRY="USA")
class TestHeaderLabelFromCodelist:
"""Tests for header-label resolution via the indicator codelist."""
def test_label_matches_code_resolved_from_codelist(self, mock_qb_factory):
"""When the hierarchy label equals the code, the codelist supplies the name."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "PARENT",
"parent_id": None,
"label": "PARENT", # Same as indicator_code
"series_id": "",
"indicator_code": "PARENT",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "CHILD",
"parent_id": "PARENT",
"label": "Child",
"series_id": "CHILD_S",
"indicator_code": "CHILD",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "PARENT", "label": "PARENT"},
{"value": "CHILD", "label": "CHILD"},
],
},
codelist_cache={
"CL_BOP_INDICATOR": {
"PARENT": "Parent Group, US dollar, (Core FSI)",
"CHILD": "Child indicator",
}
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CHILD_S",
"INDICATOR_code": "CHILD",
"indicator_code": "CHILD",
"unit": "US dollar",
"scale": "Millions",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
headers = [r for r in result["data"] if r.get("is_category_header")]
assert any("Parent Group" in (h.get("title") or "") for h in headers)
def test_label_matches_code_resolved_via_suffix_match(self, mock_qb_factory):
"""An exact codelist match falls back to a prefix scan when missing."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "REV",
"parent_id": None,
"label": "REV",
"series_id": "",
"indicator_code": "REV",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "REV_USD",
"parent_id": "REV",
"label": "Rev USD",
"series_id": "REV_USD_S",
"indicator_code": "REV_USD",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "REV", "label": "REV"},
{"value": "REV_USD", "label": "REV_USD"},
],
},
codelist_cache={
"CL_BOP_INDICATOR": {"REV_USD": "Revenue series"}, # only suffix exists
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "REV_USD_S",
"INDICATOR_code": "REV_USD",
"indicator_code": "REV_USD",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
headers = [r for r in result["data"] if r.get("is_category_header")]
assert any("Revenue series" in (h.get("title") or "") for h in headers)
class TestSeriesIdParsing:
"""Tests for the data-row hierarchy matching via series_id forms."""
def test_series_id_with_dataflow_marker(self, mock_qb_factory):
"""Series IDs like ``A_BOP_X_Y`` match via the dataflow marker path."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "PREFIX_BOP_CAB",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "BOP::CAB",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
assert result["data"]
class TestGfsHeaderUnitInference:
"""Tests for GFS header unit inference and sector-prefix application."""
def test_gfs_header_unit_from_child_code(self, mock_qb_factory):
"""A GFS header borrows the unit from its child's code suffix."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
dataflows={
"GFS": {
"id": "GFS",
"name": "GFS",
"structureRef": {"id": "DSD"},
}
},
indicators=[
{
"order": 1,
"depth": 0,
"id": "REV",
"parent_id": None,
"label": "Revenue",
"series_id": "",
"indicator_code": "REV",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "REV_TAX_USD",
"parent_id": "REV",
"label": "Tax Revenue",
"series_id": "REV_TAX_USD_S",
"indicator_code": "REV_TAX_USD",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "REV", "label": "REV"},
{"value": "REV_TAX_USD", "label": "REV_TAX_USD"},
],
},
codelist_cache={
"CL_GFS_REV": {"REV_TAX_USD": "Tax Revenue, US dollar"},
"CL_UNIT": {"USD": "US dollar"},
},
)
mock_qb.metadata._resolve_codelist_id = MagicMock(return_value="CL_GFS_REV")
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "REV_TAX_USD_S",
"INDICATOR_code": "REV_TAX_USD",
"indicator_code": "REV_TAX_USD",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("GFS", "H_TEST", COUNTRY="USA")
headers = [r for r in result["data"] if r.get("is_category_header")]
assert any("US dollar" in (h.get("title") or "") for h in headers)
class TestSectorPrefixHeader:
"""Tests for sector-prefix decoration in category headers."""
def test_sector_prefix_added_to_header(self, mock_qb_factory):
"""A header whose indicator starts with a CL_SECTOR code gets a sector prefix."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "S13_REV",
"parent_id": None,
"label": "Revenue header",
"series_id": "",
"indicator_code": "S13_REV",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "S13_REV_TAX",
"parent_id": "S13_REV",
"label": "Tax",
"series_id": "S13_REV_TAX_S",
"indicator_code": "S13_REV_TAX",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "S13_REV", "label": "S13_REV"},
{"value": "S13_REV_TAX", "label": "S13_REV_TAX"},
],
},
codelist_cache={
"CL_SECTOR": {"S13": "General Government"},
"CL_BOP_INDICATOR": {"S13_REV_TAX": "Tax Revenue"},
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "S13_REV_TAX_S",
"INDICATOR_code": "S13_REV_TAX",
"indicator_code": "S13_REV_TAX",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
headers = [r for r in result["data"] if r.get("is_category_header")]
assert any("General Government" in (h.get("title") or "") for h in headers)
class TestEmptyDimensionRaises:
"""Tests for the ``no data available`` warning path in the indicator-dim handling."""
def test_indicator_codes_dont_match_available(self, mock_qb_factory):
"""Indicator codes that don't match available options trigger a warning fallback."""
from openbb_core.app.model.abstract.warning import OpenBBWarning
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "X",
"parent_id": None,
"label": "X",
"series_id": "",
"indicator_code": "Z_NOT_IN_OPTIONS",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "REAL_INDICATOR", "label": "Real"}],
},
)
mock_qb.fetch_data.return_value = {"data": [], "metadata": {}}
builder = ImfTableBuilder()
with pytest.warns(OpenBBWarning, match="Progressive constraint"):
builder.get_table("BOP", "H_TEST", COUNTRY="USA")
class TestOrderSubIndex:
"""Tests for sub-indexing when multiple series share the same hierarchy order."""
def test_duplicate_orders_get_sub_indexed(self, mock_qb_factory):
"""Multiple series at the same order get offset by 0.001 increments."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "A",
"parent_id": None,
"label": "A",
"series_id": "A_S",
"indicator_code": "A",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "A", "label": "A"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "A_S",
"INDICATOR_code": "A",
"indicator_code": "A",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
},
{
"series_id": "A_S_v2", # Different series_id, same hierarchy order via prefix
"INDICATOR_code": "A",
"indicator_code": "A",
"TIME_PERIOD": "2021",
"OBS_VALUE": 2,
},
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
orders = sorted(r["order"] for r in result["data"])
# At least two distinct orders (1 and 1.001) when more than one series sub-indexed
assert any(isinstance(o, float) and o != int(o) for o in orders)
class TestRowMatchingViaCompositeKey:
"""Tests for row hierarchy matching when ``series_id`` is empty."""
def test_row_with_series_id_carrying_double_colon(self, mock_qb_factory):
"""A row with ``series_id`` containing ``::`` matches via sorted codes."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "X",
"parent_id": None,
"label": "X",
"series_id": "BOP::X",
"indicator_code": "X",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "X", "label": "X"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "BOP::X",
"INDICATOR_code": "X",
"indicator_code": "X",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
assert result["data"]
def test_row_without_indicator_code_skipped(self, mock_qb_factory):
"""Rows missing every indicator-code field are skipped."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_S",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_S",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
},
{
"series_id": "ORPHAN",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
},
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
assert all(r.get("INDICATOR_code") in {"CAB", None, ""} for r in result["data"])
class TestCachedCodelistDimensionLookup:
"""Tests for the cached codelist→dimension resolution."""
def test_repeated_codelist_uses_cache(self, mock_qb_factory):
"""A second indicator with the same codelist hits the in-method cache."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "A",
"parent_id": None,
"label": "A",
"series_id": "A_S",
"indicator_code": "A",
"code_urn": "urn:sdmx:org.sdmx.infomodel.codelist.Code=IMF.STA:CL_BOP_INDICATOR(1.0).A",
},
{
"order": 2,
"depth": 0,
"id": "B",
"parent_id": None,
"label": "B",
"series_id": "B_S",
"indicator_code": "B",
"code_urn": "urn:sdmx:org.sdmx.infomodel.codelist.Code=IMF.STA:CL_BOP_INDICATOR(1.0).B",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "A", "label": "A"},
{"value": "B", "label": "B"},
],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "A_S",
"INDICATOR_code": "A",
"indicator_code": "A",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
},
{
"series_id": "B_S",
"INDICATOR_code": "B",
"indicator_code": "B",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
},
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
codes = {r.get("INDICATOR_code") for r in result["data"]}
assert {"A", "B"}.issubset(codes)
class TestGfsRowSectorPrefix:
"""Tests for GFS-row sector handling."""
def test_gfs_row_sector_prefix_from_sector_code(self, mock_qb_factory):
"""GFS rows pick up the sector via the ``SECTOR_code`` field."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
dataflows={
"GFS": {
"id": "GFS",
"name": "GFS",
"structureRef": {"id": "DSD"},
}
},
indicators=[
{
"order": 1,
"depth": 0,
"id": "REV",
"parent_id": None,
"label": "Revenue",
"series_id": "REV_S",
"indicator_code": "REV",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "REV", "label": "REV"}],
},
codelist_cache={
"CL_SECTOR": {"S13": "General Government"},
"CL_GFS_REV": {"REV": "Revenue"},
},
)
mock_qb.metadata._resolve_codelist_id = MagicMock(return_value="CL_GFS_REV")
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "REV_S",
"INDICATOR_code": "REV",
"indicator_code": "REV",
"SECTOR_code": "S13",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("GFS", "H_TEST", COUNTRY="USA")
row = next(r for r in result["data"] if r.get("INDICATOR_code") == "REV")
assert "General Government" in (row.get("title") or "")
class TestExistingNetBaseLabels:
"""Tests for the ``, Net`` base-label skip logic in header creation."""
def test_existing_net_title_prevents_duplicate_header(self, mock_qb_factory):
"""A header sharing the same prefix as an existing ``, Net`` row is suppressed."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "OVERVIEW",
"parent_id": None,
"label": "Account Overview",
"series_id": "",
"indicator_code": "OVERVIEW",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "OVERVIEW_NET",
"parent_id": "OVERVIEW",
"label": "Account Overview, Net",
"series_id": "OV_NET_S",
"indicator_code": "OVERVIEW_NET",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "OVERVIEW", "label": "OVERVIEW"},
{"value": "OVERVIEW_NET", "label": "OVERVIEW_NET"},
],
},
codelist_cache={
"CL_BOP_INDICATOR": {
"OVERVIEW_NET": "Account Overview, Net",
"OVERVIEW": "Account Overview",
}
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "OV_NET_S",
"INDICATOR_code": "OVERVIEW_NET",
"indicator_code": "OVERVIEW_NET",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
# The "OVERVIEW" header should be skipped because "Account Overview" matches
# a base of an existing ", Net" title.
header_titles = [
r.get("title")
for r in result["data"]
if r.get("is_category_header") and r.get("indicator_code") == "OVERVIEW"
]
assert header_titles == []
class TestNameWithGfsSuffix:
"""Tests for indicator-name suffix stripping."""
def test_gfs_suffix_stripped_from_indicator_name(self, mock_qb_factory):
"""A ``Stock positions`` suffix on the codelist name is trimmed."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "X",
"parent_id": None,
"label": "X",
"series_id": "X_S",
"indicator_code": "X",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "X", "label": "X"}],
},
codelist_cache={
"CL_BOP_INDICATOR": {"X": "Asset, Sub-category, Stock positions"}
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "X_S",
"INDICATOR_code": "X",
"indicator_code": "X",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
row = next(r for r in result["data"] if r.get("INDICATOR_code") == "X")
# ``Stock positions`` is trimmed by the GFS-suffix loop
assert "Stock positions" not in (row.get("title") or "")
class TestGfsHeaderUnitFromParent:
"""Tests for GFS header unit inference via parent_id suffix."""
def test_header_unit_from_parent_id_suffix(self, mock_qb_factory):
"""When children carry no unit, header inherits unit from parent_id suffix."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
dataflows={
"GFS": {
"id": "GFS",
"name": "GFS",
"structureRef": {"id": "DSD"},
}
},
indicators=[
{
"order": 1,
"depth": 0,
"id": "REV_USD",
"parent_id": None,
"label": "Revenue Group",
"series_id": "",
"indicator_code": "REV_USD",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "REV_TAX_X",
"parent_id": "REV_USD",
"label": "Tax",
"series_id": "TX_S",
"indicator_code": "REV_TAX_X",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "REV_USD", "label": "REV_USD"},
{"value": "REV_TAX_X", "label": "REV_TAX_X"},
],
},
codelist_cache={
"CL_GFS_REV": {"REV_TAX_X": "Tax"},
"CL_UNIT": {"USD": "US dollar"},
},
)
mock_qb.metadata._resolve_codelist_id = MagicMock(return_value="CL_GFS_REV")
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "TX_S",
"INDICATOR_code": "REV_TAX_X",
"indicator_code": "REV_TAX_X",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("GFS", "H_TEST", COUNTRY="USA")
headers = [r for r in result["data"] if r.get("is_category_header")]
assert any("US dollar" in (h.get("title") or "") for h in headers)
class TestHierarchyEdgeEntries:
"""Edge-case hierarchy entries."""
def test_entry_without_indicator_code_in_full_indicators(self, mock_qb_factory):
"""An entry without ``indicator_code`` in the full list is skipped."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "A",
"parent_id": None,
"label": "A",
"series_id": "A_S",
"indicator_code": "A",
"dimension_id": "INDICATOR",
},
{ # No indicator_code -> skipped by line 351
"order": 99,
"depth": 0,
"id": "NOCODE",
"parent_id": None,
"label": "",
"series_id": "",
"indicator_code": "",
"dimension_id": "INDICATOR",
},
{ # order=None -> skipped by line 356
"order": None,
"depth": 0,
"id": "NOORDER",
"parent_id": None,
"label": "X",
"series_id": "",
"indicator_code": "NOORDER",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "A", "label": "A"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "A_S",
"INDICATOR_code": "A",
"indicator_code": "A",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
assert result["data"]
def test_dim_with_empty_id_skipped(self, mock_qb_factory):
"""A DSD dimension with an empty ID is skipped during indicator-order build."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, MockQB = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "A",
"parent_id": None,
"label": "A",
"series_id": "A_S",
"indicator_code": "A",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "A", "label": "A"}],
},
)
# Add a DSD dimension with empty ID
mock_qb.metadata.datastructures["DSD"]["dimensions"].append(
{"id": "", "position": 99}
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "A_S",
"INDICATOR_code": "A",
"indicator_code": "A",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
assert result["data"]
class TestCalculateDepth:
"""Tests for the module-level ``_calculate_depth`` helper."""
def test_depth_traces_parent_chain(self):
"""The depth equals the number of ancestors in the chain."""
from openbb_imf.utils.table_builder import _calculate_depth
indicators = {
"A": {"indicator_code": "A", "parent_id": None},
"B": {"indicator_code": "B", "parent_id": "A"},
"C": {"indicator_code": "C", "parent_id": "B"},
}
assert _calculate_depth(indicators["A"], indicators) == 0
assert _calculate_depth(indicators["B"], indicators) == 1
assert _calculate_depth(indicators["C"], indicators) == 2
def test_depth_short_circuits_on_cycle(self):
"""A cycle in parent links returns 0 instead of looping forever."""
from openbb_imf.utils.table_builder import _calculate_depth
indicators = {
"A": {"indicator_code": "A", "parent_id": "B"},
"B": {"indicator_code": "B", "parent_id": "A"},
}
assert _calculate_depth(indicators["A"], indicators) <= 2
def test_depth_without_code_returns_zero(self):
"""An indicator without a code returns depth 0."""
from openbb_imf.utils.table_builder import _calculate_depth
assert _calculate_depth({}, {}) == 0
class TestUnmappedKwarg:
"""Tests for kwargs whose lowercase key matches no dimension."""
def test_unknown_kwarg_passed_through(self, mock_qb_factory):
"""A kwarg whose lower-case key is not a dimension is forwarded as-is."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_S",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_S",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
builder.get_table("BOP", "H_TEST", COUNTRY="USA", EXTRA_KWARG="passthrough")
kwargs = mock_qb.fetch_data.call_args[1]
assert kwargs["EXTRA_KWARG"] == "passthrough"
class TestUnmappedIndicatorDim:
"""Tests for the unmapped-indicator-dim error path."""
def test_indicator_dim_not_in_hierarchy_raises(self, mock_qb_factory):
"""An indicator dimension absent from both hierarchy and kwargs raises."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb_factory(
dimensions=("COUNTRY", "INDICATOR"),
indicators=[
{
"order": 1,
"depth": 0,
"id": "USA",
"parent_id": None,
"label": "USA",
"series_id": "USA_S",
"indicator_code": "USA",
"dimension_id": "COUNTRY",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
builder = ImfTableBuilder()
with pytest.raises(ValueError, match="could not be mapped"):
builder.get_table("BOP", "H_TEST")
class TestShallowAvailableEmptyTruncation:
"""Tests for the truncation branch when shallow_codes is empty."""
def test_deep_only_long_codes_truncated(self, mock_qb_factory):
"""All indicators at depth>1 with joined length>850 triggers truncation."""
from openbb_imf.utils.table_builder import ImfTableBuilder
long_codes = [f"INDICATOR_VERY_VERY_LONG_NAME_{i:04d}" for i in range(60)]
indicators = [
{
"order": 1,
"depth": 0,
"id": "ROOT",
"parent_id": None,
"label": "ROOT",
"series_id": "ROOT_S",
"indicator_code": "ROOT",
"dimension_id": "INDICATOR",
}
]
for i, code in enumerate(long_codes, start=2):
indicators.append(
{
"order": i,
"depth": 3,
"id": code,
"parent_id": "ROOT",
"label": code,
"series_id": f"{code}_S",
"indicator_code": code,
"dimension_id": "INDICATOR",
}
)
options = {
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": c, "label": c} for c in ["ROOT"] + long_codes],
}
mock_qb, _ = mock_qb_factory(indicators=indicators, options=options)
mock_qb.fetch_data.return_value = {"data": [], "metadata": {}}
builder = ImfTableBuilder()
builder.get_table("BOP", "H_TEST", parent_id="ROOT", COUNTRY="USA")
kwargs = mock_qb.fetch_data.call_args[1]
assert kwargs["INDICATOR"] == "*"
class TestProgressiveFallbackLargeCodes:
"""Tests for the unfiltered-fallback wildcard when joined codes>1500."""
def test_progressive_failure_long_codes_uses_wildcard(self, mock_qb_factory):
"""When the progressive builder errors and joined codes>1500, falls back to ``*``."""
from openbb_core.app.model.abstract.warning import OpenBBWarning
from openbb_imf.utils.table_builder import ImfTableBuilder
long_codes = [f"REALLY_LONG_INDICATOR_NAME_{i:05d}" for i in range(120)]
indicators = [
{
"order": i,
"depth": 0,
"id": code,
"parent_id": None,
"label": code,
"series_id": f"{code}_S",
"indicator_code": code,
"dimension_id": "INDICATOR",
}
for i, code in enumerate(long_codes)
]
mock_qb, _ = mock_qb_factory(
indicators=indicators,
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": c, "label": c} for c in long_codes],
},
)
mock_qb.fetch_data.return_value = {"data": [], "metadata": {}}
class BoomBuilder(FakeImfParamsBuilder):
def __init__(self):
super().__init__(["COUNTRY", "INDICATOR"])
self._first_call = True
def get_options_for_dimension(self, dim_id):
if self._first_call:
self._first_call = False
raise KeyError("boom")
return [{"value": c, "label": c} for c in long_codes]
with patch(
"openbb_imf.utils.progressive_helper.ImfParamsBuilder",
lambda _df: BoomBuilder(),
):
builder = ImfTableBuilder()
with pytest.warns(OpenBBWarning, match="Progressive constraint"):
builder.get_table("BOP", "H_TEST", COUNTRY="USA")
kwargs = mock_qb.fetch_data.call_args[1]
assert kwargs["INDICATOR"] == "*"
class TestSeriesIdDoubleColonFallback:
"""Tests for row matching via sorted-codes when series_id has ``::``."""
def test_row_series_id_double_colon_falls_through_to_sorted_codes(
self, mock_qb_factory
):
"""A row series_id containing ``::`` not in hierarchy_by_series_id falls through."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "X",
"parent_id": None,
"label": "X",
"series_id": "PREFIX_BOP_X",
"indicator_code": "X",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "X", "label": "X"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "OTHERPREFIX::X",
"INDICATOR_code": "X",
"indicator_code": "X",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
assert result["data"]
class TestBopCompositeMarkerHandling:
"""Tests for the BOP A_P / L_P composite marker selection."""
@pytest.fixture
def bop_options(self):
"""Return the BOP options used by the composite tests."""
return {
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "X", "label": "X"}],
"BOP_ACCOUNTING_ENTRY": [
{"value": "A_P", "label": "Assets"},
{"value": "L_P", "label": "Liabilities"},
],
}
def test_a_p_marker_chooses_asset_candidate(self, mock_qb_factory, bop_options):
"""A_P marker picks the candidate whose haystack mentions ASSET."""
from openbb_imf.utils.table_builder import ImfTableBuilder
indicators = [
{
"order": 1,
"depth": 0,
"id": "A_P",
"parent_id": None,
"label": "Assets",
"series_id": "AP_S",
"indicator_code": "A_P",
"is_group": True,
"dimension_id": "BOP_ACCOUNTING_ENTRY",
},
{
"order": 2,
"depth": 1,
"id": "X_GENERIC_ONE",
"parent_id": "A_P",
"label": "X variant 1",
"series_id": "",
"indicator_code": "X",
"dimension_id": "INDICATOR",
},
{
"order": 3,
"depth": 1,
"id": "X_ASSETS_VARIANT",
"parent_id": "A_P",
"label": "X assets variant",
"series_id": "",
"indicator_code": "X",
"dimension_id": "INDICATOR",
},
]
mock_qb, _ = mock_qb_factory(
dimensions=("COUNTRY", "INDICATOR", "BOP_ACCOUNTING_ENTRY"),
indicators=indicators,
options=bop_options,
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "",
"INDICATOR_code": "X",
"BOP_ACCOUNTING_ENTRY_code": "A_P",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
rows = [r for r in result["data"] if r.get("INDICATOR_code") == "X"]
assert any(r.get("hierarchy_node_id") == "X_ASSETS_VARIANT" for r in rows)
def test_l_p_marker_chooses_liability_candidate(self, mock_qb_factory, bop_options):
"""L_P marker picks the candidate whose haystack mentions LIAB."""
from openbb_imf.utils.table_builder import ImfTableBuilder
indicators = [
{
"order": 1,
"depth": 0,
"id": "L_P",
"parent_id": None,
"label": "Liabilities",
"series_id": "LP_S",
"indicator_code": "L_P",
"is_group": True,
"dimension_id": "BOP_ACCOUNTING_ENTRY",
},
{
"order": 2,
"depth": 1,
"id": "X_GENERIC_VARIANT",
"parent_id": "L_P",
"label": "X generic variant",
"series_id": "",
"indicator_code": "X",
"dimension_id": "INDICATOR",
},
{
"order": 3,
"depth": 1,
"id": "X_LIABILITIES_NODE",
"parent_id": "L_P",
"label": "X liability variant",
"series_id": "",
"indicator_code": "X",
"dimension_id": "INDICATOR",
},
]
mock_qb, _ = mock_qb_factory(
dimensions=("COUNTRY", "INDICATOR", "BOP_ACCOUNTING_ENTRY"),
indicators=indicators,
options=bop_options,
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "",
"INDICATOR_code": "X",
"BOP_ACCOUNTING_ENTRY_code": "L_P",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
rows = [r for r in result["data"] if r.get("INDICATOR_code") == "X"]
assert any(r.get("hierarchy_node_id") == "X_LIABILITIES_NODE" for r in rows)
def test_no_marker_match_falls_back_to_first_candidate(self, mock_qb_factory):
"""When no candidate carries the marker, the first candidate is returned."""
from openbb_imf.utils.table_builder import ImfTableBuilder
options = {
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "X", "label": "X"}],
"BOP_ACCOUNTING_ENTRY": [
{"value": "A_T", "label": "A_T"},
],
}
indicators = [
{
"order": 1,
"depth": 0,
"id": "A_T",
"parent_id": None,
"label": "Combined",
"series_id": "",
"indicator_code": "A_T",
"is_group": True,
"dimension_id": "BOP_ACCOUNTING_ENTRY",
},
{
"order": 2,
"depth": 1,
"id": "PLAIN_NODE_ONE",
"parent_id": "A_T",
"label": "X variant 1",
"series_id": "PLAIN_SERIES_1",
"indicator_code": "X",
"dimension_id": "INDICATOR",
},
{
"order": 3,
"depth": 1,
"id": "PLAIN_NODE_TWO",
"parent_id": "A_T",
"label": "X variant 2",
"series_id": "PLAIN_SERIES_2",
"indicator_code": "X",
"dimension_id": "INDICATOR",
},
]
mock_qb, _ = mock_qb_factory(
dimensions=("COUNTRY", "INDICATOR", "BOP_ACCOUNTING_ENTRY"),
indicators=indicators,
options=options,
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "",
"INDICATOR_code": "X",
"BOP_ACCOUNTING_ENTRY_code": "A_T",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
rows = [r for r in result["data"] if r.get("INDICATOR_code") == "X"]
assert rows
class TestNetLikeParentFallback:
"""Tests for the NET-like parent fallback when NETCD_T is absent."""
def test_net_like_parent_used_when_netcd_t_missing(self, mock_qb_factory):
"""A parent whose name starts with NET resolves CD_T/DB_T rows when NETCD_T missing."""
from openbb_imf.utils.table_builder import ImfTableBuilder
options = {
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "Y", "label": "Y"}],
"BOP_ACCOUNTING_ENTRY": [
{"value": "NETPLUS", "label": "Net Plus"},
{"value": "CD_T", "label": "Credit"},
{"value": "DB_T", "label": "Debit"},
],
}
indicators = [
{
"order": 1,
"depth": 0,
"id": "NETPLUS",
"parent_id": None,
"label": "Net Plus",
"series_id": "",
"indicator_code": "NETPLUS",
"is_group": True,
"dimension_id": "BOP_ACCOUNTING_ENTRY",
},
{
"order": 2,
"depth": 1,
"id": "Y_UNDER_NETPLUS",
"parent_id": "NETPLUS",
"label": "Y composite",
"series_id": "",
"indicator_code": "Y",
"dimension_id": "INDICATOR",
},
]
mock_qb, _ = mock_qb_factory(
dimensions=("COUNTRY", "INDICATOR", "BOP_ACCOUNTING_ENTRY"),
indicators=indicators,
options=options,
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "",
"INDICATOR_code": "Y",
"BOP_ACCOUNTING_ENTRY_code": "CD_T",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
rows = [r for r in result["data"] if r.get("INDICATOR_code") == "Y"]
assert any(r.get("parent_code") == "NETPLUS" for r in rows)
class TestRowWithoutHierMatch:
"""Tests for rows that fail every hierarchy-matching strategy."""
def test_unmatched_row_dropped(self, mock_qb_factory):
"""A row whose indicator_code doesn't appear in the hierarchy is dropped."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "CAB",
"parent_id": None,
"label": "CAB",
"series_id": "CAB_S",
"indicator_code": "CAB",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "CAB", "label": "CAB"}],
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CAB_S",
"INDICATOR_code": "CAB",
"indicator_code": "CAB",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
},
{
"series_id": "OTHER_SERIES",
"INDICATOR_code": "TOTALLY_UNRELATED",
"indicator_code": "TOTALLY_UNRELATED",
"TIME_PERIOD": "2020",
"OBS_VALUE": 99,
},
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
codes = {r.get("INDICATOR_code") for r in result["data"]}
assert "TOTALLY_UNRELATED" not in codes
class TestSectorPrefixEmptyName:
"""Tests for the sector_prefix present but sector name empty branch."""
def test_sector_prefix_with_empty_name_falls_through(self, mock_qb_factory):
"""A sector_prefix mapped to an empty name skips the sector decoration."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "S99_X",
"parent_id": None,
"label": "S99_X",
"series_id": "S99_X_S",
"indicator_code": "S99_X",
"dimension_id": "INDICATOR",
}
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [{"value": "S99_X", "label": "S99_X"}],
},
codelist_cache={
"CL_SECTOR": {"S99": ""},
"CL_BOP_INDICATOR": {"S99_X": "Indicator Name"},
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "S99_X_S",
"INDICATOR_code": "S99_X",
"indicator_code": "S99_X",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
row = next(r for r in result["data"] if r.get("INDICATOR_code") == "S99_X")
assert row["title"] == "Indicator Name"
class TestHeaderLabelUnitSuffixTrim:
"""Tests for header-row codelist-name unit-suffix trimming."""
def test_header_codelist_unit_suffix_trimmed(self, mock_qb_factory):
"""A unit-pattern suffix on the codelist name is trimmed for headers."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "PARENT",
"parent_id": None,
"label": "PARENT",
"series_id": "",
"indicator_code": "PARENT",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "CHILD",
"parent_id": "PARENT",
"label": "Child",
"series_id": "CHILD_S",
"indicator_code": "CHILD",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "PARENT", "label": "PARENT"},
{"value": "CHILD", "label": "CHILD"},
],
},
codelist_cache={
"CL_BOP_INDICATOR": {
"PARENT": "Parent Group Name, US dollar",
"CHILD": "Child indicator",
}
},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CHILD_S",
"INDICATOR_code": "CHILD",
"indicator_code": "CHILD",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
headers = [
r
for r in result["data"]
if r.get("is_category_header") and r.get("indicator_code") == "PARENT"
]
assert headers
title = headers[0]["title"]
assert "US dollar" not in title
assert "Parent Group Name" in title
class TestHeaderGfsSuffixTrim:
"""Tests for the GFS-suffix trim in the header-label loop."""
def test_header_gfs_suffix_trimmed(self, mock_qb_factory):
"""GFS suffixes on the base_label are trimmed."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "PARENT",
"parent_id": None,
"label": "Revenue Items, Stock positions",
"series_id": "",
"indicator_code": "PARENT",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "CHILD",
"parent_id": "PARENT",
"label": "Child",
"series_id": "CHILD_S",
"indicator_code": "CHILD",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "PARENT", "label": "PARENT"},
{"value": "CHILD", "label": "CHILD"},
],
},
codelist_cache={"CL_BOP_INDICATOR": {"CHILD": "Child indicator"}},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CHILD_S",
"INDICATOR_code": "CHILD",
"indicator_code": "CHILD",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
headers = [
r
for r in result["data"]
if r.get("is_category_header") and r.get("indicator_code") == "PARENT"
]
assert headers
assert "Stock positions" not in headers[0]["title"]
assert "Revenue Items" in headers[0]["title"]
class TestHeaderScaleOnly:
"""Tests for the header title with valid scale only."""
def test_header_with_only_scale_renders_scale(self, mock_qb_factory):
"""A header with a scale but no unit renders ``Label (Scale)``."""
from openbb_imf.utils.table_builder import ImfTableBuilder
mock_qb, _ = mock_qb_factory(
indicators=[
{
"order": 1,
"depth": 0,
"id": "PARENT",
"parent_id": None,
"label": "Parent Header",
"series_id": "",
"indicator_code": "PARENT",
"is_group": True,
"dimension_id": "INDICATOR",
},
{
"order": 2,
"depth": 1,
"id": "CHILD",
"parent_id": "PARENT",
"label": "Child",
"series_id": "CHILD_S",
"indicator_code": "CHILD",
"dimension_id": "INDICATOR",
},
],
options={
"COUNTRY": [{"value": "USA", "label": "USA"}],
"INDICATOR": [
{"value": "PARENT", "label": "PARENT"},
{"value": "CHILD", "label": "CHILD"},
],
},
codelist_cache={"CL_BOP_INDICATOR": {"CHILD": "Child indicator"}},
)
mock_qb.fetch_data.return_value = {
"data": [
{
"series_id": "CHILD_S",
"INDICATOR_code": "CHILD",
"indicator_code": "CHILD",
"scale": "Millions",
"TIME_PERIOD": "2020",
"OBS_VALUE": 1,
}
],
"metadata": {},
}
builder = ImfTableBuilder()
result = builder.get_table("BOP", "H_TEST", COUNTRY="USA")
headers = [
r
for r in result["data"]
if r.get("is_category_header") and r.get("indicator_code") == "PARENT"
]
assert headers
assert headers[0]["title"] == "Parent Header (Millions)"