Files
OpenBB/.github/workflows/general-linting.yml
Theodore Aptekarev c63b3c8bab Security updates (#6531)
* Bump website deps to patched versions

* Drop support for python 3.8

* Bump scikit-learn to a patched version

* Run urllib3 update on lock files

* Bump ipykernel that brings in tornado to devtools

* Apply braces patch in frontend-components

* Drop python 3.8 from devtools support

* Bump dev environment to python >=3.10 to get rid of ullib3 v1 in lock files

* Downgrade and pin numpy to 1.x until pandas-ta supports 2.x

* Bump runners checkout and cache actions and python version

* Fix platform hub integration test

* Update dev install script to allow python 3.9

* Bump actions to versions that use node 20 vs node 16

* Bump exchange calendars package to resolve deprecation warnings

* Resolve bugs highlighted by the tests (#6538)

* Fix FMP currency snapshot model after a security update

* fixes

* add to the commit

* lint

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>

* Bump finviz

* Remove website folder that was added by merge conflict resolution

* update test cassettes

* biztoc test

* fix most of test_charting

* bump yfinance

* reference.json

* Fix some tests

* Enable 3.12 support

* Have 2 sets of cassettes for 2 versions of urlib3

* Allow 3.12 for sec provider

* add json_schema_extra choices to compare groups

* sorted choices

* test fixing: cassetes

* fix charting test

* black

* headers in sec download zip file

* Delete yaml

* lint

* lint

* Record https test_sec_compare_company_facts_fetcher

* Record https test_sec_compare_company_facts_fetcher, new params

* Record test in 3.9 and 3.10

* Record yfinance tests

* Record 310 with us vpn

* Record tests individually

* record without cache

* record without cache

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
Co-authored-by: hjoaquim <henriquecjoaquim@gmail.com>
Co-authored-by: Igor Radovanovic <74266147+IgorWounds@users.noreply.github.com>
Co-authored-by: Diogo Sousa <montezdesousa@gmail.com>
2024-07-01 13:05:59 +00:00

94 lines
3.2 KiB
YAML
Vendored

name: 🧹 General Linting
env:
PIP_DEFAULT_TIMEOUT: 100
on:
pull_request:
types: [opened, synchronize, edited]
# push:
# branches:
# - "feature/*"
# - "hotfix/*"
# - "release/*"
merge_group:
types: [checks_requested]
# Cancel previous runs that are not yet completed.
concurrency:
group: ${{ github.event_name }}-${{ github.repository }}-${{ github.ref }}
cancel-in-progress: true
jobs:
code-linting:
name: General Code Linting
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v4.1.1 # actions/checkout v3.0.2
with:
ref: ${{ github.event.pull_request.head.ref || github.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }}
fetch-depth: 20
token: ${{ secrets.GITHUB_TOKEN }}
- name: Fetch base branch
run: git fetch --no-tags --depth=20 origin ${{ github.base_ref }}
- name: Setup Python 3.10
uses: actions/setup-python@v5
with:
python-version: "3.10"
architecture: x64
- name: Get changed files in openbb_platform for PR
if: github.event_name == 'pull_request'
run: |
# "Checking PR diff"
echo "diff_files=$(git diff --diff-filter=d --name-only origin/${{ github.base_ref }}...${{ github.head_ref }} | grep -E '^(openbb_platform|cli)/.*\.py$' | grep -v 'openbb_platform/openbb/package' | grep -v 'integration' | grep -v 'tests' | xargs)" >> $GITHUB_ENV
echo $diff_files
- uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ${{ runner.os }}-linting-${{ hashFiles('**/poetry.lock') }}
restore-keys: ${{ runner.os }}-linting-${{ hashFiles('**/poetry.lock') }}
- run: |
pip install openbb-devtools
pip install types-pytz types-requests types-termcolor types-tabulate types-PyYAML types-python-dateutil types-setuptools types-six
- run: bandit -x ./tests -r . || true
- run: codespell --ignore-words=.codespell.ignore --skip="$(tr '\n' ',' < .codespell.skip | sed 's/,$//')" --quiet-level=2
- run: |
# Run linters for openbb_platform | cli
if [ -n "${{ env.diff_files }}" ]; then
black --diff --check ${{ env.diff_files }}
mypy ${{ env.diff_files }} --ignore-missing-imports --scripts-are-modules --check-untyped-defs
pydocstyle ${{ env.diff_files }}
pylint ${{ env.diff_files }}
ruff check ${{ env.diff_files }}
else
echo "No Python files changed in openbb_platform | cli"
fi
markdown-link-check:
name: Markdown Linting
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
name: Check out the code
- name: Lint Code Base
uses: docker://avtodev/markdown-lint:v1
with:
args: "./*.md ./changelogs/*.md ./openbb_terminal/**/*.md ./discordbot/**/*.md"
json-yaml-validate:
name: JSON Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: json-yaml-validate
id: json-yaml-validate
uses: GrantBirki/json-yaml-validate@v2.0.0