From ec3962aa602b17d9e7035e00e2404b91a8564b49 Mon Sep 17 00:00:00 2001 From: FilipBl4gojevic <84703395+FilipBl4gojevic@users.noreply.github.com> Date: Wed, 29 Jul 2026 20:08:56 +0200 Subject: [PATCH] docs: correct tier-1 registry coverage claim; qualify the full-migration tool count MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit README.md Testing section claimed registry-keyless.test.ts (tier-1) builds "all five agent-registry build_* tools" - false. Verified directly against the test source: it successfully builds and CBOR-checks only register and message; update appears solely on its non-owner-rejection path (no CBOR extracted); transfer and deregister don't appear in the file at all - both are covered by the gated E2E suite and the legacy suite instead. Reworded to state exactly what tier-1 covers and point the full lifecycle claim at the E2E suite, where it's actually true. docs/architecture/non-custodial-split.md:137 ("Builder — 24 tools, zero keys") is the doc's original full-migration target table, easy to misread as current-state next to README's "23" today. Added "at full migration" so it can't be read as stale. Checked pr7-body.md for the same all-five-tier-1 claim per the reviewer's note - it does not repeat it (the Tier-1 bullet only states the 6/6 pass count, no per-tool breakdown), so no change needed there. --- README.md | 2 +- docs/architecture/non-custodial-split.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 89292b4..96a0e42 100644 --- a/README.md +++ b/README.md @@ -244,7 +244,7 @@ echo "your mnemonic words here" > packages/builder/mnemonic.txt npm run test:integration ``` -Requires `mnemonic.txt` in `packages/builder/` containing a **funded Vector testnet** mnemonic. Covers the core tools end-to-end against Vector testnet, including the full agent lifecycle: register, discover, profile, update, transfer, message, and deregister (all keyless now: build → sign → submit → await per step). Also runs `keyless-build.test.ts` and `registry-keyless.test.ts`, which need no mnemonic at all - they build unsigned transactions (four of the five wallet/tx `build_*` tools, and all five agent-registry `build_*` tools) against live public data only (`vector_build_send_tokens` is covered offline, by unit tests and the legacy suite above, not by either live suite). Set `VECTOR_E2E_SUBMIT=1` to additionally run the full non-custodial pipeline end-to-end, on-chain: `keyless-e2e.test.ts` lands one real self-send (~0.16 AP3X fee), and `registry-e2e.test.ts` runs a full register → update → deregister agent lifecycle (the 10 AP3X deposit round-tripped exactly, fees only as net cost). Never runs in CI. +Requires `mnemonic.txt` in `packages/builder/` containing a **funded Vector testnet** mnemonic. Covers the core tools end-to-end against Vector testnet, including the full agent lifecycle: register, discover, profile, update, transfer, message, and deregister (all keyless now: build → sign → submit → await per step). Also runs `keyless-build.test.ts` and `registry-keyless.test.ts`, which need no mnemonic at all - they build unsigned transactions (four of the five wallet/tx `build_*` tools, and the registry's register + message builds, plus a non-owner rejection path on update) against live public data only (`vector_build_send_tokens` is covered offline, by unit tests and the legacy suite above, not by either live suite). The full registry lifecycle (register → update → deregister) is exercised by the gated E2E suite. Set `VECTOR_E2E_SUBMIT=1` to additionally run the full non-custodial pipeline end-to-end, on-chain: `keyless-e2e.test.ts` lands one real self-send (~0.16 AP3X fee), and `registry-e2e.test.ts` runs a full register → update → deregister agent lifecycle (the 10 AP3X deposit round-tripped exactly, fees only as net cost). Never runs in CI. ```bash npm run test:smoke:signer diff --git a/docs/architecture/non-custodial-split.md b/docs/architecture/non-custodial-split.md index 413a462..4439894 100644 --- a/docs/architecture/non-custodial-split.md +++ b/docs/architecture/non-custodial-split.md @@ -134,7 +134,7 @@ This is why governance is the last family: the LLM must drive a stateful, multi- ## 7. Tool inventory -**Builder — 24 tools, zero keys.** +**Builder — 24 tools at full migration, zero keys.** | Group | Tools | |---|---|