From 2d7e8798ff5f5b10b8469d6737b70d59d3bdecf0 Mon Sep 17 00:00:00 2001 From: Thomas Petersen Date: Tue, 16 Jun 2026 23:37:43 -0400 Subject: [PATCH] Preserve docked channel panel close behavior Co-authored-by: Cursor --- desktop/src/features/channels/ui/ChannelManagementSheet.tsx | 1 + desktop/tests/e2e/channel-controls-screenshots.spec.ts | 2 +- desktop/tests/e2e/integration.spec.ts | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/desktop/src/features/channels/ui/ChannelManagementSheet.tsx b/desktop/src/features/channels/ui/ChannelManagementSheet.tsx index cc4c6fac04..7c4652072e 100644 --- a/desktop/src/features/channels/ui/ChannelManagementSheet.tsx +++ b/desktop/src/features/channels/ui/ChannelManagementSheet.tsx @@ -319,6 +319,7 @@ export function ChannelManagementSheet({ : "bg-background", )} data-testid="channel-management-sheet" + onEscapeKeyDown={(event) => event.preventDefault()} onInteractOutside={(event) => event.preventDefault()} onPointerDownOutside={(event) => event.preventDefault()} > diff --git a/desktop/tests/e2e/channel-controls-screenshots.spec.ts b/desktop/tests/e2e/channel-controls-screenshots.spec.ts index 6a8e741c9b..7c6fea59f2 100644 --- a/desktop/tests/e2e/channel-controls-screenshots.spec.ts +++ b/desktop/tests/e2e/channel-controls-screenshots.spec.ts @@ -171,7 +171,7 @@ test.describe("channel controls screenshots", () => { page.getByRole("dialog", { name: "Edit channel" }), ).toHaveCount(0); - await page.keyboard.press("Escape"); + await page.getByTestId("channel-management-close").click(); await expect( page.getByTestId("channel-management-sheet"), ).not.toBeVisible(); diff --git a/desktop/tests/e2e/integration.spec.ts b/desktop/tests/e2e/integration.spec.ts index ef54f1941d..3e021cffba 100644 --- a/desktop/tests/e2e/integration.spec.ts +++ b/desktop/tests/e2e/integration.spec.ts @@ -36,7 +36,7 @@ async function openChannelEditDialog(page: import("@playwright/test").Page) { } async function closeChannelManagement(page: import("@playwright/test").Page) { - await page.keyboard.press("Escape"); + await page.getByTestId("channel-management-close").click(); await expect(page.getByTestId("channel-management-sheet")).not.toBeVisible(); }