From 42b1825ada5c3a54ca9d8699c5dea7bdc1f49da1 Mon Sep 17 00:00:00 2001 From: Thomas Petersen Date: Sun, 23 Aug 2026 22:25:59 -0400 Subject: [PATCH] fix(projects): remove drawer container focus outline Suppress the browser-default outline on the programmatically focused drawer while retaining focus indicators on its interactive controls. Signed-off-by: Thomas Petersen Co-authored-by: Thomas Petersen --- desktop/src/features/channels/ui/FocusThreadDrawer.tsx | 2 +- desktop/tests/e2e/project-commit-detail.spec.ts | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/desktop/src/features/channels/ui/FocusThreadDrawer.tsx b/desktop/src/features/channels/ui/FocusThreadDrawer.tsx index 7966ccda9b..b00b612648 100644 --- a/desktop/src/features/channels/ui/FocusThreadDrawer.tsx +++ b/desktop/src/features/channels/ui/FocusThreadDrawer.tsx @@ -221,7 +221,7 @@ export function FocusThreadDrawer({ // share a radius — a smaller one here would put two radii on one // element. `shadow-panel-left` draws the left edge and its corners; // see the token for why a `border-l` cannot. - "absolute inset-y-0 right-0 flex flex-col overflow-hidden rounded-l-2xl bg-background shadow-panel-left", + "absolute inset-y-0 right-0 flex flex-col overflow-hidden rounded-l-2xl bg-background shadow-panel-left outline-hidden", )} aria-label={label} data-testid="focus-thread-drawer" diff --git a/desktop/tests/e2e/project-commit-detail.spec.ts b/desktop/tests/e2e/project-commit-detail.spec.ts index dd5501dbf2..5de32311e7 100644 --- a/desktop/tests/e2e/project-commit-detail.spec.ts +++ b/desktop/tests/e2e/project-commit-detail.spec.ts @@ -801,6 +801,10 @@ test("commit detail opens from the commits feed with a diff", async ({ await expect(page.getByTestId("focus-thread-drawer")).toBeVisible(); await page.getByTestId("project-home-context-tasks").click(); await expect(page.getByTestId("project-home-workspace-sheet")).toBeVisible(); + await expect(page.getByTestId("focus-thread-drawer")).toHaveCSS( + "outline-style", + "none", + ); const workspaceSheet = page.getByTestId("project-home-workspace-sheet"); await expect(workspaceSheet).toHaveAttribute("data-tab", "issues"); await expect(