From 73085c8ce6985cbb4312a7b7ddd8368952a0d2ef Mon Sep 17 00:00:00 2001 From: Arjun Mahanti Date: Fri, 28 Aug 2026 12:19:07 -0400 Subject: [PATCH] fix(desktop): keep Bestie experiment default off Signed-off-by: Arjun Mahanti Co-authored-by: Codex --- desktop/src/protectedFeatures/internal.ts | 1 - desktop/src/protectedFeatures/protectedFeatures.test.mjs | 7 +++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/desktop/src/protectedFeatures/internal.ts b/desktop/src/protectedFeatures/internal.ts index d5f2133af6..7f9f6b551e 100644 --- a/desktop/src/protectedFeatures/internal.ts +++ b/desktop/src/protectedFeatures/internal.ts @@ -6,7 +6,6 @@ export const protectedFeatureDefinitions: FeatureDefinition[] = [ id: "bestie", name: "Bestie", description: "Try a personal agent that is always close at hand", - defaultEnabled: true, platforms: ["desktop"], }, ]; diff --git a/desktop/src/protectedFeatures/protectedFeatures.test.mjs b/desktop/src/protectedFeatures/protectedFeatures.test.mjs index 1c584d6a2f..20a6d469fa 100644 --- a/desktop/src/protectedFeatures/protectedFeatures.test.mjs +++ b/desktop/src/protectedFeatures/protectedFeatures.test.mjs @@ -1,6 +1,7 @@ import assert from "node:assert/strict"; import { describe, it } from "node:test"; +import { resolveEnabled } from "../shared/features/resolveEnabled.ts"; import { protectedFeatureDefinitions as internalDefinitions } from "./internal.ts"; import { protectedFeatureDefinitions as publicDefinitions } from "./public.ts"; @@ -9,11 +10,13 @@ describe("protected feature build variants", () => { assert.deepEqual(publicDefinitions, []); }); - it("adds Bestie only through the internal module", () => { + it("adds Bestie as a default-off experiment only through the internal module", () => { assert.deepEqual( internalDefinitions.map((feature) => feature.id), ["bestie"], ); - assert.equal(internalDefinitions[0]?.defaultEnabled, true); + const bestie = internalDefinitions[0]; + assert.ok(bestie); + assert.equal(resolveEnabled(bestie.id, {}, bestie.defaultEnabled), false); }); });