From 9891e64f6b8358d78aa85f2ba248310d58b51ec0 Mon Sep 17 00:00:00 2001 From: Matt Toohey Date: Fri, 21 Aug 2026 21:07:36 +1000 Subject: [PATCH] fix(desktop): clarify add agents channel action (#6374) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "Create agent" button takes you to a UI to **invite** your existing agents to a channel. Rewording the button to make this clear. Before Screenshot 2026-08-21 at 1 58 40 pm After (Sorry about different elements being in hover state in the screenshots) Screenshot 2026-08-21 at 1 58 16 pm ## Summary - Clarify that the empty-channel intro action adds existing agents to the channel. - Assert the exact action title and description in the existing E2E coverage while preserving the separate Welcome create-agent flow. ### Related issue None found. ### Testing - `../node_modules/.bin/biome check src/features/channels/ui/useChannelIntro.tsx tests/e2e/channels.spec.ts` passed. - `./node_modules/.bin/tsc && ./node_modules/.bin/vite build --mode e2e` passed. - The isolated Playwright smoke case `empty channel shows intro actions` passed (1/1) after installing the repo-pinned Chromium. - `env -u BUZZ_AGENT_PROVIDER just ci` passed. - Screenshots not captured; this is a copy-only UI change. --------- Signed-off-by: Matt Toohey --- desktop/src/features/channels/ui/useChannelIntro.tsx | 4 ++-- desktop/tests/e2e/channels.spec.ts | 11 +++++++++-- desktop/tests/e2e/tooltip-semantics.spec.ts | 2 +- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/desktop/src/features/channels/ui/useChannelIntro.tsx b/desktop/src/features/channels/ui/useChannelIntro.tsx index c22bbff2c2..19f2da0edb 100644 --- a/desktop/src/features/channels/ui/useChannelIntro.tsx +++ b/desktop/src/features/channels/ui/useChannelIntro.tsx @@ -91,9 +91,9 @@ export function useChannelIntro({ if (!activeChannel.archivedAt && activeChannel.isMember) { if (onAddAgent) { actions.push({ - description: "Add an agent here.", + description: "Bring them in.", icon: , - label: "Create agent", + label: "Add agents", onClick: onAddAgent, testId: "channel-intro-action-create-agent", }); diff --git a/desktop/tests/e2e/channels.spec.ts b/desktop/tests/e2e/channels.spec.ts index 8a32a436c3..52d91dea3e 100644 --- a/desktop/tests/e2e/channels.spec.ts +++ b/desktop/tests/e2e/channels.spec.ts @@ -1746,8 +1746,15 @@ test("empty channel shows intro actions", async ({ page }) => { await expect( page.getByTestId("channel-intro-action-create-channel"), ).toHaveCount(0); + const addAgentsAction = page.getByTestId("channel-intro-action-create-agent"); + await expect(addAgentsAction).toBeVisible(); await expect( - page.getByTestId("channel-intro-action-create-agent"), + addAgentsAction.getByText("Add agents", { exact: true }), + ).toBeVisible(); + await expect( + addAgentsAction.getByText("Bring them in.", { + exact: true, + }), ).toBeVisible(); await expect( page.getByTestId("channel-intro-action-add-people"), @@ -1767,7 +1774,7 @@ test("empty channel shows intro actions", async ({ page }) => { await page.keyboard.press("Escape"); await expect(page.getByTestId("members-sidebar")).not.toBeVisible(); - await page.getByTestId("channel-intro-action-create-agent").click(); + await addAgentsAction.click(); await expect(page.getByRole("heading", { name: "Add agents" })).toBeVisible(); await page.keyboard.press("Escape"); diff --git a/desktop/tests/e2e/tooltip-semantics.spec.ts b/desktop/tests/e2e/tooltip-semantics.spec.ts index 73306f025c..90ccd061bf 100644 --- a/desktop/tests/e2e/tooltip-semantics.spec.ts +++ b/desktop/tests/e2e/tooltip-semantics.spec.ts @@ -142,7 +142,7 @@ for (const theme of THEMES) { await expect(row).toBeVisible(); await expectMutedSupportingText( row.getByRole("button", { name: "Open channel general" }), - /Public channel · Active \d+[mhdw] ago/, + /Public channel · Active (just now|\d+[mhdw] ago)/, ); await page.mouse.move(0, 0); await expectMutedSupportingText(