From b25d074a557642ea40d3923d8fe68e5c9af9b9c3 Mon Sep 17 00:00:00 2001
From: klopez4212 <klopez4212@gmail.com>
Date: Sun, 21 Jun 2026 12:19:43 +0100
Subject: [PATCH] Preserve imported persona model on provider select

---
 desktop/src/features/agents/ui/PersonaDialog.tsx | 11 ++++++++++-
 .../agents/ui/personaRuntimeModel.test.mjs       | 16 ++++++++++++++++
 .../features/agents/ui/personaRuntimeModel.ts    |  9 +++++++++
 3 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 desktop/src/features/agents/ui/personaRuntimeModel.test.mjs
 create mode 100644 desktop/src/features/agents/ui/personaRuntimeModel.ts

diff --git a/desktop/src/features/agents/ui/PersonaDialog.tsx b/desktop/src/features/agents/ui/PersonaDialog.tsx
index 09f93c23ed..dcbc340cc4 100644
--- a/desktop/src/features/agents/ui/PersonaDialog.tsx
+++ b/desktop/src/features/agents/ui/PersonaDialog.tsx
@@ -32,6 +32,7 @@ import {
   getImportErrorLabel,
   IMPORT_ERROR_VISIBILITY_MS,
 } from "./personaDialogImportState";
+import { shouldClearModelForRuntimeChange } from "./personaRuntimeModel";
 
 type PersonaDialogProps = {
   open: boolean;
@@ -543,8 +544,16 @@ export function PersonaDialog({
               <Select
                 disabled={isPending || runtimesLoading}
                 onValueChange={(nextRuntime) => {
+                  const previousRuntime = runtime;
                   setRuntime(nextRuntime);
-                  setModel("");
+                  if (
+                    shouldClearModelForRuntimeChange(
+                      previousRuntime,
+                      nextRuntime,
+                    )
+                  ) {
+                    setModel("");
+                  }
                 }}
                 value={runtime}
               >
diff --git a/desktop/src/features/agents/ui/personaRuntimeModel.test.mjs b/desktop/src/features/agents/ui/personaRuntimeModel.test.mjs
new file mode 100644
index 0000000000..00efab5b4b
--- /dev/null
+++ b/desktop/src/features/agents/ui/personaRuntimeModel.test.mjs
@@ -0,0 +1,16 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import { shouldClearModelForRuntimeChange } from "./personaRuntimeModel.ts";
+
+test("shouldClearModelForRuntimeChange preserves model for first runtime selection", () => {
+  assert.equal(shouldClearModelForRuntimeChange("", "goose"), false);
+});
+
+test("shouldClearModelForRuntimeChange clears model when switching runtimes", () => {
+  assert.equal(shouldClearModelForRuntimeChange("goose", "claude"), true);
+});
+
+test("shouldClearModelForRuntimeChange keeps model for unchanged runtime", () => {
+  assert.equal(shouldClearModelForRuntimeChange("goose", "goose"), false);
+});
diff --git a/desktop/src/features/agents/ui/personaRuntimeModel.ts b/desktop/src/features/agents/ui/personaRuntimeModel.ts
new file mode 100644
index 0000000000..54ca6f7416
--- /dev/null
+++ b/desktop/src/features/agents/ui/personaRuntimeModel.ts
@@ -0,0 +1,9 @@
+export function shouldClearModelForRuntimeChange(
+  previousRuntime: string,
+  nextRuntime: string,
+): boolean {
+  const previous = previousRuntime.trim();
+  const next = nextRuntime.trim();
+
+  return previous.length > 0 && next.length > 0 && previous !== next;
+}