From bd540d0e87bc1951589f4d8691263fc4b1cc0ebe Mon Sep 17 00:00:00 2001 From: Thomas Petersen Date: Thu, 20 Aug 2026 16:19:04 -0400 Subject: [PATCH] fix(ci): align Projects smoke specs with context chrome Keep git authors in commit Details instead of the header, and point the smoke tests at the section Create review control and the reading-column width so they stop matching the duplicate context action and the full-bleed files pane. Signed-off-by: Thomas Petersen --- .../src/features/projects/ui/ProjectCommitDetailPanel.tsx | 5 ----- desktop/tests/e2e/project-commit-detail.spec.ts | 7 +++++-- desktop/tests/e2e/project-pr-review.spec.ts | 5 ++++- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/desktop/src/features/projects/ui/ProjectCommitDetailPanel.tsx b/desktop/src/features/projects/ui/ProjectCommitDetailPanel.tsx index eab88695eb..96773a0820 100644 --- a/desktop/src/features/projects/ui/ProjectCommitDetailPanel.tsx +++ b/desktop/src/features/projects/ui/ProjectCommitDetailPanel.tsx @@ -76,11 +76,6 @@ export function ProjectCommitDetailPanel({ {commitDateLabel(commit.timestamp)} ) : null} - {commit?.authorName ? ( - - by {commit.authorName} - - ) : null} div").first()).toHaveCSS( + "max-width", + "768px", + ); await expect( commitDetail.getByRole("heading", { name: "Add Trello board workflow details", @@ -867,7 +870,7 @@ test("pull request and issue feeds use compact work item rows", async ({ page.getByTestId("project-work-item-group-header").first(), ).toBeVisible(); await expect( - prRows.first().locator("button").filter({ hasText: /.+/ }).nth(1), + prRows.first().locator("[data-projects-text-priority='primary']"), ).toHaveCSS("font-weight", "400"); await waitForAnimations(page); await page.screenshot({ fullPage: false, path: `${SHOTS}/03-prs-feed.png` }); diff --git a/desktop/tests/e2e/project-pr-review.spec.ts b/desktop/tests/e2e/project-pr-review.spec.ts index 798d0ac17e..8b74d9ab26 100644 --- a/desktop/tests/e2e/project-pr-review.spec.ts +++ b/desktop/tests/e2e/project-pr-review.spec.ts @@ -3140,7 +3140,10 @@ test("pushed local branch can open a pull request", async ({ page }) => { .getByRole("menuitemradio", { name: "feature/projects-workflow" }) .click(); await page.getByRole("tab", { name: "Review", exact: true }).click(); - await page.getByRole("button", { name: "Create review" }).click(); + await page + .getByTestId("project-section-header") + .getByRole("button", { name: "Create review" }) + .click(); await expect(page.getByTestId("create-pull-request-repository")).toHaveValue( /:buzz$/, );