Refine app loading skeletons (#1001)

desktop/src/shared/ui/ViewLoadingFallback.tsx

@@ -1,9 +1,12 @@
+import * as React from "react";
+
+import { useAppShell } from "@/app/AppShellContext";
 import { Card } from "@/shared/ui/card";
-import { useSidebar } from "@/shared/ui/sidebar";
 import { Skeleton } from "@/shared/ui/skeleton";
 import { cn } from "@/shared/lib/cn";
 import { channelChrome } from "@/shared/layout/chromeLayout";
 import { TopChromeInsetHeader } from "@/shared/layout/TopChromeInsetHeader";
+import { TopChromeBackdrop } from "@/shared/ui/TopChromeBackdrop";
 
 type ViewLoadingFallbackKind =
   | "agents"
@@ -19,26 +22,18 @@ type ViewLoadingFallbackProps = {
 };
 
 function LoadingHeaderSkeleton() {
-  const { state: sidebarState } = useSidebar();
-
   return (
     <TopChromeInsetHeader data-tauri-drag-region>
-      <header
-        className={cn(
-          "flex min-h-[44px] min-w-0 cursor-default select-none items-center gap-[10px] py-[6px] pl-[16px] pr-[8px] transition-[padding] duration-200 ease-linear sm:pl-[24px] sm:pr-[12px]",
-          sidebarState === "collapsed" && "md:pl-[160px]",
-        )}
-      >
+      <header className="flex min-h-8 min-w-0 cursor-default select-none items-center gap-2.5 py-1.5 pl-4 pr-2 sm:pr-3">
         <div className="min-w-0 flex-1">
-          <div className="flex min-w-0 items-center gap-[6px]">
-            <Skeleton className="h-3.5 w-3.5 rounded-xs" />
+          <div className="flex min-w-0 items-center gap-1 overflow-hidden">
+            <Skeleton className="h-4 w-4 shrink-0 rounded-sm" />
             <Skeleton className="h-4 w-28 max-w-[50vw]" />
           </div>
-          <Skeleton className="mt-2 h-4 w-full max-w-2xl" />
         </div>
-        <div className="hidden shrink-0 items-center gap-2 sm:flex">
-          <Skeleton className="h-6 w-6 rounded-lg" />
-          <Skeleton className="h-6 w-6 rounded-lg" />
+        <div className="hidden shrink-0 items-center gap-1 sm:flex">
+          <Skeleton className="h-8 w-16 rounded-lg" />
+          <Skeleton className="h-8 w-8 rounded-lg" />
         </div>
       </header>
     </TopChromeInsetHeader>
@@ -48,93 +43,232 @@ function LoadingHeaderSkeleton() {
 function MessageRowsSkeleton() {
   return (
     <>
-      {["first", "second", "third", "fourth", "fifth"].map((row, index) => (
-        <div className="flex gap-3" key={row}>
+      {["first", "second", "third", "fourth"].map((row, index) => (
+        <article
+          className="relative flex items-start gap-2.5 rounded-2xl px-3 py-2"
+          key={row}
+        >
           <Skeleton className="h-9 w-9 shrink-0 rounded-full" />
-          <div className="min-w-0 flex-1 space-y-1 pt-0.5">
-            <div className="flex items-baseline gap-2">
-              <Skeleton className="h-3.5 w-28" />
-              <Skeleton className="h-3 w-12" />
+          <div className="-mt-1 min-w-0 flex-1">
+            <div className="flex min-w-0 flex-wrap items-baseline gap-x-2 gap-y-0">
+              <Skeleton className="h-[15px] w-28" />
+              <Skeleton className="h-3 w-10" />
+            </div>
+            <div className="mt-1 space-y-1.5 pb-2">
+              <Skeleton className="h-4 w-full" />
+              <Skeleton
+                className={index % 2 === 0 ? "h-4 w-4/5" : "h-4 w-2/3"}
+              />
+            </div>
+            <div className="flex items-center gap-4">
+              <Skeleton className="h-4 w-8 rounded-full" />
+              <Skeleton className="h-4 w-8 rounded-full" />
+              <Skeleton className="h-4 w-8 rounded-full" />
             </div>
-            <Skeleton className="h-4 w-full" />
-            <Skeleton className={index % 2 === 0 ? "h-4 w-4/5" : "h-4 w-2/3"} />
           </div>
-        </div>
+        </article>
       ))}
     </>
   );
 }
 
+const agentLoadingGroups = [
+  {
+    badgeWidth: "w-14",
+    instanceWidth: "w-20",
+    key: "persona-one",
+    rows: ["one-a", "one-b"],
+    titleWidth: "w-32",
+  },
+  {
+    badgeWidth: "w-16",
+    instanceWidth: "w-24",
+    key: "persona-two",
+    rows: ["two-a"],
+    titleWidth: "w-28",
+  },
+  {
+    badgeWidth: "w-12",
+    instanceWidth: "w-20",
+    key: "custom-agents",
+    rows: ["custom-a"],
+    titleWidth: "w-36",
+  },
+] as const;
+
+function AgentRowSkeleton({ variant = 0 }: { variant?: number }) {
+  return (
+    <div className="flex items-start gap-3 px-4 py-3">
+      <div className="min-w-0 flex-1">
+        <div className="grid gap-3 lg:grid-cols-[minmax(0,1.8fr)_minmax(120px,0.8fr)_minmax(0,1.1fr)] lg:gap-4">
+          <div className="min-w-0">
+            <div className="flex items-start gap-3">
+              <Skeleton className="mt-0.5 h-4 w-4 shrink-0 rounded-sm" />
+              <Skeleton className="mt-1 h-2 w-2 shrink-0 rounded-full" />
+              <div className="min-w-0 flex-1">
+                <div className="flex flex-wrap items-center gap-2">
+                  <Skeleton
+                    className={cn("h-4", variant % 2 === 0 ? "w-36" : "w-28")}
+                  />
+                  <Skeleton className="h-5 w-16 rounded-full" />
+                </div>
+                <div className="mt-1 flex flex-wrap items-center gap-x-3 gap-y-1">
+                  <Skeleton className="h-3 w-20" />
+                  <Skeleton className="h-3 w-24" />
+                </div>
+                {variant === 0 ? (
+                  <div className="mt-1.5 flex flex-wrap items-center gap-1.5">
+                    <Skeleton className="h-5 w-20 rounded-full" />
+                    <Skeleton className="h-5 w-24 rounded-full" />
+                  </div>
+                ) : null}
+              </div>
+            </div>
+          </div>
+
+          <div className="space-y-1 lg:pt-0.5">
+            <Skeleton className="h-5 w-20 rounded-full" />
+            <Skeleton
+              className={cn("h-3", variant % 2 === 0 ? "w-24" : "w-28")}
+            />
+          </div>
+
+          <div className="space-y-1 lg:pt-0.5">
+            <Skeleton className="h-3 w-28" />
+            <div className="flex flex-wrap items-center gap-x-3 gap-y-1">
+              <Skeleton className="h-3 w-20" />
+              {variant === 0 ? <Skeleton className="h-3 w-24" /> : null}
+            </div>
+          </div>
+        </div>
+      </div>
+
+      <div className="flex shrink-0 items-start gap-2 lg:pt-0.5">
+        <Skeleton className="h-7 w-24 rounded-md" />
+        <Skeleton className="h-7 w-7 rounded-md" />
+      </div>
+    </div>
+  );
+}
+
+function AgentGroupSkeleton({
+  badgeWidth,
+  instanceWidth,
+  rows,
+  titleWidth,
+}: {
+  badgeWidth: string;
+  instanceWidth: string;
+  rows: readonly string[];
+  titleWidth: string;
+}) {
+  return (
+    <div className="overflow-hidden rounded-xl border border-border/70 bg-card/40">
+      <div className="flex items-center gap-2 px-3 py-2">
+        <div className="flex min-w-0 flex-1 items-center gap-2 py-1">
+          <Skeleton className="h-4 w-4 shrink-0 rounded-sm" />
+          <Skeleton className="h-8 w-8 shrink-0 rounded-lg" />
+          <div className="flex min-w-0 items-center gap-2">
+            <Skeleton className={cn("h-4", titleWidth)} />
+            <Skeleton className={cn("h-5 rounded-full", badgeWidth)} />
+          </div>
+          <Skeleton className={cn("ml-1 h-3 shrink-0", instanceWidth)} />
+        </div>
+        <Skeleton className="h-7 w-7 shrink-0 rounded-md" />
+      </div>
+
+      <div className="divide-y divide-border/50 border-t border-border/50">
+        {rows.map((row, index) => (
+          <AgentRowSkeleton key={row} variant={index} />
+        ))}
+      </div>
+    </div>
+  );
+}
+
+function AgentsLibrarySkeleton() {
+  return (
+    <section className="space-y-4">
+      <div className="flex items-center justify-between gap-3">
+        <div>
+          <Skeleton className="h-4 w-24" />
+          <Skeleton className="mt-2 h-4 w-80 max-w-full" />
+        </div>
+        <div className="flex items-center gap-2">
+          <Skeleton className="h-7 w-7 rounded-md" />
+          <Skeleton className="h-8 w-16 rounded-lg" />
+        </div>
+      </div>
+
+      <div className="space-y-3">
+        {agentLoadingGroups.map((group) => (
+          <AgentGroupSkeleton
+            badgeWidth={group.badgeWidth}
+            instanceWidth={group.instanceWidth}
+            key={group.key}
+            rows={group.rows}
+            titleWidth={group.titleWidth}
+          />
+        ))}
+      </div>
+    </section>
+  );
+}
+
+function AgentTeamsSkeleton() {
+  return (
+    <section className="space-y-4">
+      <div className="flex items-center justify-between gap-3">
+        <div>
+          <Skeleton className="h-4 w-20" />
+          <Skeleton className="mt-2 h-4 w-96 max-w-full" />
+        </div>
+        <div className="flex items-center gap-2">
+          <Skeleton className="hidden h-8 w-40 rounded-md sm:block" />
+          <Skeleton className="h-8 w-20 rounded-lg" />
+        </div>
+      </div>
+
+      <div className="grid gap-3 md:grid-cols-2 xl:grid-cols-3">
+        {["team-one", "team-two", "team-three"].map((key, index) => (
+          <Card className="p-3" key={key}>
+            <div className="flex items-start justify-between gap-2.5">
+              <div className="min-w-0 flex-1">
+                <div className="flex items-center gap-2">
+                  <Skeleton className="h-4 w-4 shrink-0 rounded-sm" />
+                  <Skeleton
+                    className={cn("h-4", index === 0 ? "w-28" : "w-36")}
+                  />
+                  {index === 1 ? (
+                    <Skeleton className="h-4 w-8 rounded-full" />
+                  ) : null}
+                </div>
+                <div className="mt-2 flex items-center gap-2">
+                  <div className="flex -space-x-1.5">
+                    <Skeleton className="h-6 w-6 rounded-full border-2 border-card" />
+                    <Skeleton className="h-6 w-6 rounded-full border-2 border-card" />
+                    <Skeleton className="h-6 w-6 rounded-full border-2 border-card" />
+                  </div>
+                  <Skeleton className="h-3 w-20" />
+                </div>
+              </div>
+              <Skeleton className="h-6 w-6 rounded-md" />
+            </div>
+          </Card>
+        ))}
+      </div>
+    </section>
+  );
+}
+
 function AgentsLoadingBody() {
   return (
-    <div className="flex min-h-0 min-w-0 flex-1 flex-col overflow-y-auto px-4 pb-4 pt-14 sm:px-6">
-      <div className="space-y-6">
-        <section className="space-y-4">
-          <div className="flex items-center justify-between gap-3">
-            <div className="space-y-2">
-              <Skeleton className="h-5 w-28" />
-              <Skeleton className="h-4 w-72 max-w-full" />
-            </div>
-            <Skeleton className="h-8 w-8 rounded-lg" />
-          </div>
-          <div className="grid gap-3 md:grid-cols-3 xl:grid-cols-4">
-            {["first", "second", "third", "fourth"].map((card) => (
-              <Card className="p-3" key={card}>
-                <div className="flex items-center gap-2.5">
-                  <Skeleton className="h-8 w-8 rounded-lg" />
-                  <div className="min-w-0 flex-1 space-y-2">
-                    <Skeleton className="h-4 w-24" />
-                    <Skeleton className="h-3 w-16 rounded-full" />
-                  </div>
-                </div>
-              </Card>
-            ))}
-          </div>
-        </section>
-
-        <section className="space-y-4">
-          <div className="space-y-2">
-            <Skeleton className="h-5 w-24" />
-            <Skeleton className="h-4 w-80 max-w-full" />
-          </div>
-          <div className="grid gap-3 md:grid-cols-2 xl:grid-cols-3">
-            {["alpha", "beta", "gamma"].map((card) => (
-              <Card className="p-4" key={card}>
-                <div className="space-y-3">
-                  <div className="flex items-center justify-between gap-3">
-                    <div className="space-y-2">
-                      <Skeleton className="h-4 w-28" />
-                      <Skeleton className="h-3 w-20 rounded-full" />
-                    </div>
-                    <Skeleton className="h-7 w-16 rounded-full" />
-                  </div>
-                  <Skeleton className="h-4 w-full" />
-                  <Skeleton className="h-4 w-4/5" />
-                </div>
-              </Card>
-            ))}
-          </div>
-        </section>
-
-        <section className="space-y-4">
-          <div className="space-y-2">
-            <Skeleton className="h-5 w-36" />
-            <Skeleton className="h-4 w-72 max-w-full" />
-          </div>
-          <Card className="overflow-hidden">
-            {["one", "two", "three"].map((row) => (
-              <div
-                className="flex items-center gap-4 border-b border-border/60 px-4 py-3 last:border-b-0"
-                key={row}
-              >
-                <Skeleton className="h-4 w-28" />
-                <Skeleton className="h-5 w-16 rounded-full" />
-                <Skeleton className="h-4 w-24" />
-                <Skeleton className="ml-auto h-8 w-24 rounded-lg" />
-              </div>
-            ))}
-          </Card>
-        </section>
+    <div className="flex min-h-0 min-w-0 flex-1 flex-col overflow-y-auto overflow-x-hidden overscroll-contain px-4 pb-4 pt-14 sm:px-6">
+      <div className="mx-auto flex w-full max-w-6xl flex-col gap-6">
+        <div className="flex flex-col gap-6">
+          <AgentsLibrarySkeleton />
+          <AgentTeamsSkeleton />
+        </div>
       </div>
     </div>
   );
@@ -181,8 +315,8 @@ function CardListLoadingBody() {
 
 function ChannelLoadingBody({ hasHeader = false }: { hasHeader?: boolean }) {
   return (
-    <div className="flex min-h-0 min-w-0 flex-1 flex-col overflow-hidden">
-      <div className="flex-1 overflow-y-auto px-4 pt-1 sm:px-6">
+    <div className="relative flex min-h-0 min-w-0 flex-1 flex-col overflow-hidden">
+      <div className="flex-1 overflow-y-auto px-4 pb-32 pt-1 sm:px-6">
         <div
           className={cn(
             "flex w-full flex-col gap-4",
@@ -195,13 +329,25 @@ function ChannelLoadingBody({ hasHeader = false }: { hasHeader?: boolean }) {
         </div>
       </div>
 
-      <div className="border-t border-border/60 bg-background px-4 py-4 sm:px-6">
-        <div className="w-full space-y-3">
-          <Skeleton className="h-10 w-full rounded-2xl" />
-          <div className="flex items-center gap-2">
-            <Skeleton className="h-8 w-20 rounded-lg" />
-            <Skeleton className="h-8 w-16 rounded-lg" />
-            <Skeleton className="ml-auto h-8 w-24 rounded-lg" />
+      <div className="pointer-events-none absolute inset-x-0 bottom-0 z-10">
+        <div className="pointer-events-auto">
+          <div className="relative z-10 shrink-0 bg-transparent px-4 pb-2 pt-0">
+            <div
+              aria-hidden="true"
+              className="absolute inset-x-0 bottom-0 h-5 bg-background"
+            />
+            <div className="relative isolate rounded-2xl border border-border/50 bg-background/80 px-3 pb-2 pt-3 shadow-none backdrop-blur-md supports-[backdrop-filter]:bg-background/70 dark:bg-background/70 dark:backdrop-blur-xl dark:supports-[backdrop-filter]:bg-background/55 sm:px-4">
+              <Skeleton className="h-5 w-56 max-w-full" />
+              <div className="mt-4 flex items-center gap-2">
+                <Skeleton className="h-8 w-8 rounded-lg" />
+                <Skeleton className="h-8 w-8 rounded-lg" />
+                <Skeleton className="h-8 w-8 rounded-lg" />
+                <Skeleton className="ml-auto h-8 w-8 rounded-full" />
+              </div>
+            </div>
+          </div>
+          <div className="h-7 bg-background px-4 pb-1 pt-0 sm:px-6">
+            <div className="flex h-full w-full items-center gap-2" />
           </div>
         </div>
       </div>
@@ -250,18 +396,37 @@ export function ViewLoadingFallback({
   includeHeader = false,
   kind,
 }: ViewLoadingFallbackProps) {
+  const { setTopbarSearchLoading } = useAppShell();
+  const shouldShowChannelHeader =
+    includeHeader && (kind === "channel" || kind === "forum");
+
+  React.useLayoutEffect(() => {
+    if (!includeHeader) return;
+
+    setTopbarSearchLoading(true);
+    return () => {
+      setTopbarSearchLoading(false);
+    };
+  }, [includeHeader, setTopbarSearchLoading]);
+
   return (
-    <div className="flex min-h-0 min-w-0 flex-1 flex-col overflow-hidden">
-      {includeHeader ? <LoadingHeaderSkeleton /> : null}
+    <div className="relative flex min-h-0 min-w-0 flex-1 flex-col overflow-hidden">
+      {shouldShowChannelHeader ? (
+        <LoadingHeaderSkeleton />
+      ) : includeHeader ? (
+        <TopChromeBackdrop />
+      ) : null}
       {kind === "agents" ? <AgentsLoadingBody /> : null}
       {kind === "workflows" ? <CardListLoadingBody /> : null}
       {kind === "projects" ? <CardListLoadingBody /> : null}
       {kind === "channel" ? (
-        <ChannelLoadingBody hasHeader={includeHeader} />
+        <ChannelLoadingBody hasHeader={shouldShowChannelHeader} />
+      ) : null}
+      {kind === "forum" ? (
+        <ForumLoadingBody hasHeader={shouldShowChannelHeader} />
       ) : null}
-      {kind === "forum" ? <ForumLoadingBody hasHeader={includeHeader} /> : null}
       {kind === "pulse" ? (
-        <ChannelLoadingBody hasHeader={includeHeader} />
+        <ChannelLoadingBody hasHeader={shouldShowChannelHeader} />
       ) : null}
     </div>
   );