From df3ff104ef801194f5ce0b4ec1b720bf275862d9 Mon Sep 17 00:00:00 2001
From: Elrond
 <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz>
Date: Fri, 16 Oct 2026 15:44:42 -0400
Subject: [PATCH] test(push-gateway): take pgschema password from resolved
 connect options

Will's review at 5107ebab: a ?password= query parameter reached SQLx but
not pgschema, since the test reparsed the URL itself. Read the password
from PgConnectOptions (userinfo, ?password=, PGPASSWORD and .pgpass,
in SQLx's precedence) and document pgschema 1.7.4's unquoted keyword-DSN
limit for whitespace, quotes, '=' and backslashes.

Signed-off-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz>
---
 .../postgres/desired_schema_postgres_tests.rs | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/crates/buzz-push-gateway/src/postgres/desired_schema_postgres_tests.rs b/crates/buzz-push-gateway/src/postgres/desired_schema_postgres_tests.rs
index 74b36d194c..c01d322ce5 100644
--- a/crates/buzz-push-gateway/src/postgres/desired_schema_postgres_tests.rs
+++ b/crates/buzz-push-gateway/src/postgres/desired_schema_postgres_tests.rs
@@ -3,6 +3,7 @@
 //! applies at startup. These tests keep the two from drifting apart.
 use super::*;
 use sqlx::postgres::PgConnectOptions;
+use sqlx::ConnectOptions;
 use std::collections::BTreeSet;
 use std::path::{Path, PathBuf};
 
@@ -192,23 +193,22 @@ async fn desired_state_schema_matches_migrations() {
     // pgschema takes discrete connection flags. `PgConnectOptions` decodes the
     // URL the way the gateway does, including a Unix-socket host, which
     // pgschema accepts as a socket directory in `--host` like libpq does.
+    // The password comes from the resolved options, so the userinfo,
+    // `?password=`, `PGPASSWORD` and `.pgpass` precedence matches SQLx's.
+    // pgschema 1.7.4 joins these flags into an unquoted keyword DSN, so a
+    // password or socket path containing whitespace, a quote, `=` or a
+    // backslash is not supported here.
     let base_url = std::env::var("BUZZ_TEST_DATABASE_URL").expect("test database URL");
     let options: PgConnectOptions = base_url.parse().expect("parse test database URL");
     let host = match options.get_socket() {
         Some(dir) => dir.to_str().expect("socket directory utf-8").to_owned(),
         None => options.get_host().to_owned(),
     };
-    let password = url::Url::parse(&base_url)
-        .expect("parse test database URL")
-        .password()
-        .map(|encoded| {
-            percent_encoding::percent_decode_str(encoded)
-                .decode_utf8()
-                .expect("database password utf-8")
-                .into_owned()
-        })
-        .or_else(|| std::env::var("PGPASSWORD").ok())
-        .unwrap_or_default();
+    let password =
+        percent_encoding::percent_decode_str(options.to_url_lossy().password().unwrap_or_default())
+            .decode_utf8()
+            .expect("database password utf-8")
+            .into_owned();
     let connection = PgschemaConnection {
         host,
         port: options.get_port().to_string(),