From ea25c1b38a57b31c09e04e9b0ee4e75343eec409 Mon Sep 17 00:00:00 2001 From: Logan Johnson Date: Tue, 25 Aug 2026 10:04:37 -0400 Subject: [PATCH] refactor(desktop): drop dead revision helper superseded by /revision endpoint The current_workflow_revision helper in desktop trigger_workflow was referenced only from #[cfg(test)] workflows_tests.rs after the exact signed-revision binding moved server-side behind the authenticated /workflows/{id}/revision endpoint, leaving a dead-code lint risk in non-test desktop builds. Remove the helper and its unit test. Co-authored-by: Wakko <0999168a3b1a4dabdf398cf43ba2893bb29b74dc06d0b31c2d3b51dbebea1612@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson --- desktop/src-tauri/src/commands/workflows.rs | 7 ------- desktop/src-tauri/src/commands/workflows_tests.rs | 14 -------------- 2 files changed, 21 deletions(-) diff --git a/desktop/src-tauri/src/commands/workflows.rs b/desktop/src-tauri/src/commands/workflows.rs index f2f99d76f4..31aa948b93 100644 --- a/desktop/src-tauri/src/commands/workflows.rs +++ b/desktop/src-tauri/src/commands/workflows.rs @@ -377,13 +377,6 @@ pub async fn deny_approval( // ── Helpers (pure, unit-tested in workflows_tests.rs) ───────────────────────── -fn current_workflow_revision(events: &[nostr::Event]) -> Result { - events - .first() - .map(|event| event.id.to_hex()) - .ok_or_else(|| "workflow not found".to_string()) -} - fn trigger_wire_from_message( workflow_id: String, message: &str, diff --git a/desktop/src-tauri/src/commands/workflows_tests.rs b/desktop/src-tauri/src/commands/workflows_tests.rs index 4df97831f7..6523d45862 100644 --- a/desktop/src-tauri/src/commands/workflows_tests.rs +++ b/desktop/src-tauri/src/commands/workflows_tests.rs @@ -273,20 +273,6 @@ fn channel_workflow_filters_accepts_empty_input() { ); } -#[test] -fn trigger_command_uses_current_definition_event_id() { - let event = wf_event(WF, CHAN, YAML); - let revision = event.id.to_hex(); - assert_eq!( - current_workflow_revision(std::slice::from_ref(&event)).as_deref(), - Ok(revision.as_str()) - ); - assert_eq!( - current_workflow_revision(&[]).expect_err("empty result must fail"), - "workflow not found" - ); -} - #[test] fn trigger_response_uses_persisted_run_id_contract() { let wire = trigger_wire_from_message(