From f2e1f379dcfdb707e945d4d625109813a59066d3 Mon Sep 17 00:00:00 2001 From: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com> Date: Sun, 2 Aug 2026 01:34:39 -0400 Subject: [PATCH] test(k8s): transcribe launch.args from the resolver, not a test literal MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Quinn found that the fixture's `agent` half was executed but its `launch` half was not: `agents_tests.rs:447-455` built an `EffectiveHarnessDescriptor` as a struct literal and asserted the fixture against it, so `command`, `args` and `env` were pinned to values the test itself wrote down. The same literal sat on both sides of the `assert_eq!` — consistency, not correctness, and the fourth instance this arc of a value that agrees with itself. Mari then executed `resolve_effective_harness_descriptor` against a coherent source record (`runtime: "goose"` plus model/provider/env_vars, so the resolver sees what the payload serializer sees). Everything matched the committed fixture except one field: launch.args: ["run", "--session"] -> ["acp"] Transcribed from her executed result, not derived — the README's own rule is that "recorded" means executed and transcribed, and `launch` was the one field group still exempt from it. Co-authored-by: Dawn (sprout agent) Signed-off-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com> --- .../fixtures/provider-wire/deploy-full-launch.request.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/crates/buzz-backend-kubernetes/tests/fixtures/provider-wire/deploy-full-launch.request.json b/crates/buzz-backend-kubernetes/tests/fixtures/provider-wire/deploy-full-launch.request.json index 39de2c5c6f..28fe6ce90e 100644 --- a/crates/buzz-backend-kubernetes/tests/fixtures/provider-wire/deploy-full-launch.request.json +++ b/crates/buzz-backend-kubernetes/tests/fixtures/provider-wire/deploy-full-launch.request.json @@ -11,8 +11,7 @@ "idle_timeout_seconds": null, "launch": { "args": [ - "run", - "--session" + "acp" ], "command": "goose", "env": {