mirror of
https://github.com/block/buzz.git
synced 2026-11-12 12:22:06 +00:00
## Summary Deletes mobile code that no longer has a user-reachable path and has no counterpart in buzz-app, so it is unlikely to come back for parity. Net: 104 files, about 5,500 lines removed. No intended behavior change. - **iOS native message menu and action surface:** `NativeMessageMenu.swift` and `NativeMessageActionSurface.swift`, the `message`/`supportsMessage` coordinator branches, and the Dart selection hook. Dart stopped creating this view in [#8280](https://github.com/block/buzz/pull/8280). The native reactions sheet in the same coordinator is kept. - **Old home quick-actions launcher and `ComposeMorphIcon`:** only instantiated in tests since the nav-bar creation actions replaced them. - **Retired local theme stack:** `ThemeNotifier`, `AccentNotifier`, `SchemeNotifier`, `adaptive_theme.dart`, `AccentPickerPage`, the appearance-mode sheet and their helpers. These predate per-community theme sync. The legacy prefs migration in `community_theme_preference.dart` is kept. - **Unused widgets:** `ProfileAvatar` and `MaskedAvatarBadge`. - **Push permission-status plumbing:** the iOS `notificationAuthorizationStatus`/`openNotificationSettings` handlers, plus the uncalled strict age-gate snapshot registration and its Swift `syncAgeGatePushSnapshot` path. - **Orphaned files** with no importer: `profile_text_edit_sheet`, `editor_option_button`, `retained_page_transition`, `tappable_flapping_bee`, `agent_model_info`, `community_bot_profiles`, `sheet_divider`, `success_haptic`. - **Uncalled helpers:** the `pickAndUpload*`/camera helpers in `media_upload.dart`, unused `NostrFilters` builders, `mediaGetHeadersFor*`, and about 20 other uncalled functions, providers and styles. - **Removed-UI leftovers:** the never-wired invite directory providers, `AuthNotifier.signOut` and `removeActiveCommunityForSignOut` (the Sign out row is gone), `renameCommunity`, `HomePage.profilePageBuilder`/`SettingsPage.embedded`, and the create-forum branches of the create-channel sheet. Forum viewing is unchanged. Tests that only covered deleted code are removed. Tests of surviving code that used deleted helpers as drivers were repointed to the surviving API. An audit of `mobile/android` found no dead Kotlin, resources, manifest entries or Gradle dependencies, so Android code is unchanged. ## Validation - `flutter analyze`: no issues. - After rebasing onto main ([93b8b8f](https://github.com/block/buzz/commit/93b8b8febc)), `just mobile-check` is clean (format and analyze), and `just mobile-test` passes (4,070 passed, 35 skipped, 0 failed, plus the push-unconfigured and secp256k1 suites). - `dart format`: clean. - Android: `just mobile-build-android` builds the debug APK, and `./gradlew :app:testDebugUnitTest` passes. - iOS: `build-for-testing` succeeds and BuzzPushKit `swift test` passes (65 tests). In RunnerTests, 97 of 98 pass. `testNativeNavigationTitleExpandsAgainAtTop` fails, but it fails the same way on unmodified `main` (acf56fff6f) on the same machine (Xcode 27, iPhone 17 Pro simulator), so it is not caused by this change. - Agent review of the diff ran. Its one blocker (stale `project.pbxproj` entries for the deleted Swift files) is fixed. - In-app smoke run at [66141c1](66141c10b9): a debug build on a fresh iPhone 17 Pro simulator (iOS 27), signed in to the internal community. The following flows all worked with no errors: - Home: the New menu (channel, DM, workspace, chat) and the create-channel sheet, including its channel-type options. - A chat, with the message action sheet (reactions row, Reply, Copy link, Remind me, Mark unread, Copy text, Edit and Delete). - Appearance: the previews, and cycling the System and Light modes. - Settings: the profile header, the display name editor, and Edit photo (Image and Emoji tabs). - The Agents directory. - Search, including the Channels filter, plus opening a team channel from the results. - Tapping a reaction summary, which opens the native iOS Reactions sheet. - The recording isn't attached here because it shows internal channels and messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Tom Brow <tomb@squareup.com> Co-authored-by: Tom Brow <tomb@squareup.com> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
156 lines
4.0 KiB
Dart
156 lines
4.0 KiB
Dart
import 'package:flutter/foundation.dart';
|
|
|
|
/// Media presentation selected for a message attachment URL.
|
|
enum MessageMediaKind { image, video, audio }
|
|
|
|
/// Parsed metadata from a NIP-92 `imeta` tag.
|
|
@immutable
|
|
class ImetaEntry {
|
|
final String url;
|
|
final String? mimeType;
|
|
final String? dimensions;
|
|
final String? thumb;
|
|
final String? image;
|
|
final String? alt;
|
|
final double? duration;
|
|
final String? filename;
|
|
final int? size;
|
|
|
|
const ImetaEntry({
|
|
required this.url,
|
|
this.mimeType,
|
|
this.dimensions,
|
|
this.thumb,
|
|
this.image,
|
|
this.alt,
|
|
this.duration,
|
|
this.filename,
|
|
this.size,
|
|
});
|
|
|
|
bool get isVideo => mimeType?.startsWith('video/') == true;
|
|
|
|
String? get posterUrl => image ?? thumb;
|
|
|
|
double? get aspectRatio {
|
|
final parts = dimensions?.split('x');
|
|
if (parts == null || parts.length != 2) return null;
|
|
final width = double.tryParse(parts[0]);
|
|
final height = double.tryParse(parts[1]);
|
|
if (width == null || height == null || width <= 0 || height <= 0) {
|
|
return null;
|
|
}
|
|
return width / height;
|
|
}
|
|
}
|
|
|
|
/// Parses NIP-92 `imeta` tags into entries keyed by their attachment URL.
|
|
Map<String, ImetaEntry> parseImetaTags(List<List<String>> tags) {
|
|
final byUrl = <String, ImetaEntry>{};
|
|
for (final tag in tags) {
|
|
if (tag.isEmpty || tag.first != 'imeta') continue;
|
|
|
|
String? url;
|
|
String? mimeType;
|
|
String? dimensions;
|
|
String? thumb;
|
|
String? image;
|
|
String? alt;
|
|
double? duration;
|
|
String? filename;
|
|
int? size;
|
|
|
|
for (final part in tag.skip(1)) {
|
|
final separator = part.indexOf(' ');
|
|
if (separator <= 0) continue;
|
|
final key = part.substring(0, separator);
|
|
final value = part.substring(separator + 1);
|
|
switch (key) {
|
|
case 'url':
|
|
url = value;
|
|
case 'm':
|
|
mimeType = value;
|
|
case 'dim':
|
|
dimensions = value;
|
|
case 'thumb':
|
|
thumb = value;
|
|
case 'image':
|
|
image = value;
|
|
case 'alt':
|
|
alt = value;
|
|
case 'duration':
|
|
final parsedDuration = double.tryParse(value);
|
|
duration =
|
|
parsedDuration != null &&
|
|
parsedDuration.isFinite &&
|
|
parsedDuration >= 0
|
|
? parsedDuration
|
|
: null;
|
|
case 'filename':
|
|
filename = value;
|
|
case 'size':
|
|
size = int.tryParse(value);
|
|
}
|
|
}
|
|
|
|
if (url == null || url.isEmpty) continue;
|
|
byUrl[url] = ImetaEntry(
|
|
url: url,
|
|
mimeType: mimeType,
|
|
dimensions: dimensions,
|
|
thumb: thumb,
|
|
image: image,
|
|
alt: alt,
|
|
duration: duration,
|
|
filename: filename,
|
|
size: size,
|
|
);
|
|
}
|
|
return byUrl;
|
|
}
|
|
|
|
/// Classifies [url] using authoritative [imeta] before extension fallback.
|
|
MessageMediaKind? classifyMediaUrl(String url, {ImetaEntry? imeta}) {
|
|
final mimeType = imeta?.mimeType;
|
|
if (mimeType != null) {
|
|
final filename = imeta?.filename?.toLowerCase();
|
|
if (mimeType == 'video/mp4' &&
|
|
filename != null &&
|
|
filename.startsWith('voice-note-') &&
|
|
filename.endsWith('.mp4')) {
|
|
return MessageMediaKind.audio;
|
|
}
|
|
// An imeta MIME type is authoritative. The native video player chooses
|
|
// whether the device can decode the specific codec/container; rejecting
|
|
// every non-MP4 video here prevents it from even trying.
|
|
if (mimeType.startsWith('video/')) return MessageMediaKind.video;
|
|
if (mimeType.startsWith('image/')) return MessageMediaKind.image;
|
|
if (mimeType.startsWith('audio/')) return MessageMediaKind.audio;
|
|
}
|
|
|
|
final path = (Uri.tryParse(url)?.path ?? url).toLowerCase();
|
|
if (path.endsWith(_mp4Extension)) {
|
|
return MessageMediaKind.video;
|
|
}
|
|
if (_imageExtensions.any(path.endsWith)) {
|
|
return MessageMediaKind.image;
|
|
}
|
|
if (path.endsWith('.m4a') || path.endsWith('.aac')) {
|
|
return MessageMediaKind.audio;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
const _imageExtensions = {
|
|
'.jpg',
|
|
'.jpeg',
|
|
'.png',
|
|
'.webp',
|
|
'.bmp',
|
|
'.heic',
|
|
'.heif',
|
|
'.avif',
|
|
};
|
|
|
|
const _mp4Extension = '.mp4';
|