mirror of
https://github.com/block/buzz.git
synced 2026-11-04 16:31:38 +00:00
## Summary Deletes mobile code that no longer has a user-reachable path and has no counterpart in buzz-app, so it is unlikely to come back for parity. Net: 104 files, about 5,500 lines removed. No intended behavior change. - **iOS native message menu and action surface:** `NativeMessageMenu.swift` and `NativeMessageActionSurface.swift`, the `message`/`supportsMessage` coordinator branches, and the Dart selection hook. Dart stopped creating this view in [#8280](https://github.com/block/buzz/pull/8280). The native reactions sheet in the same coordinator is kept. - **Old home quick-actions launcher and `ComposeMorphIcon`:** only instantiated in tests since the nav-bar creation actions replaced them. - **Retired local theme stack:** `ThemeNotifier`, `AccentNotifier`, `SchemeNotifier`, `adaptive_theme.dart`, `AccentPickerPage`, the appearance-mode sheet and their helpers. These predate per-community theme sync. The legacy prefs migration in `community_theme_preference.dart` is kept. - **Unused widgets:** `ProfileAvatar` and `MaskedAvatarBadge`. - **Push permission-status plumbing:** the iOS `notificationAuthorizationStatus`/`openNotificationSettings` handlers, plus the uncalled strict age-gate snapshot registration and its Swift `syncAgeGatePushSnapshot` path. - **Orphaned files** with no importer: `profile_text_edit_sheet`, `editor_option_button`, `retained_page_transition`, `tappable_flapping_bee`, `agent_model_info`, `community_bot_profiles`, `sheet_divider`, `success_haptic`. - **Uncalled helpers:** the `pickAndUpload*`/camera helpers in `media_upload.dart`, unused `NostrFilters` builders, `mediaGetHeadersFor*`, and about 20 other uncalled functions, providers and styles. - **Removed-UI leftovers:** the never-wired invite directory providers, `AuthNotifier.signOut` and `removeActiveCommunityForSignOut` (the Sign out row is gone), `renameCommunity`, `HomePage.profilePageBuilder`/`SettingsPage.embedded`, and the create-forum branches of the create-channel sheet. Forum viewing is unchanged. Tests that only covered deleted code are removed. Tests of surviving code that used deleted helpers as drivers were repointed to the surviving API. An audit of `mobile/android` found no dead Kotlin, resources, manifest entries or Gradle dependencies, so Android code is unchanged. ## Validation - `flutter analyze`: no issues. - After rebasing onto main ([93b8b8f](https://github.com/block/buzz/commit/93b8b8febc)), `just mobile-check` is clean (format and analyze), and `just mobile-test` passes (4,070 passed, 35 skipped, 0 failed, plus the push-unconfigured and secp256k1 suites). - `dart format`: clean. - Android: `just mobile-build-android` builds the debug APK, and `./gradlew :app:testDebugUnitTest` passes. - iOS: `build-for-testing` succeeds and BuzzPushKit `swift test` passes (65 tests). In RunnerTests, 97 of 98 pass. `testNativeNavigationTitleExpandsAgainAtTop` fails, but it fails the same way on unmodified `main` (acf56fff6f) on the same machine (Xcode 27, iPhone 17 Pro simulator), so it is not caused by this change. - Agent review of the diff ran. Its one blocker (stale `project.pbxproj` entries for the deleted Swift files) is fixed. - In-app smoke run at [66141c1](66141c10b9): a debug build on a fresh iPhone 17 Pro simulator (iOS 27), signed in to the internal community. The following flows all worked with no errors: - Home: the New menu (channel, DM, workspace, chat) and the create-channel sheet, including its channel-type options. - A chat, with the message action sheet (reactions row, Reply, Copy link, Remind me, Mark unread, Copy text, Edit and Delete). - Appearance: the previews, and cycling the System and Light modes. - Settings: the profile header, the display name editor, and Edit photo (Image and Emoji tabs). - The Agents directory. - Search, including the Channels filter, plus opening a team channel from the results. - Tapping a reaction summary, which opens the native iOS Reactions sheet. - The recording isn't attached here because it shows internal channels and messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Tom Brow <tomb@squareup.com> Co-authored-by: Tom Brow <tomb@squareup.com> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
362 lines
12 KiB
Dart
362 lines
12 KiB
Dart
import 'dart:convert';
|
|
import 'dart:ui' show Rect;
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:http/http.dart' as http;
|
|
import 'package:hooks_riverpod/hooks_riverpod.dart';
|
|
import 'package:nostr/nostr.dart' as nostr;
|
|
import 'package:share_plus/share_plus.dart';
|
|
|
|
import '../../shared/hosted/hosted_relay_auth.dart';
|
|
import '../../shared/community/community_membership_provider.dart';
|
|
import '../../shared/utils/string_utils.dart';
|
|
import '../../shared/relay/relay.dart';
|
|
|
|
/// The default lifetime of a newly minted community invite link.
|
|
const defaultCommunityInviteTtlSeconds = 3 * 24 * 60 * 60;
|
|
|
|
/// A labeled value shown in a community invite settings sheet.
|
|
@immutable
|
|
class CommunityInviteOption<T> {
|
|
/// Creates an option with its user-facing [label] and submitted [value].
|
|
const CommunityInviteOption({required this.label, required this.value});
|
|
|
|
/// The text presented for this option.
|
|
final String label;
|
|
|
|
/// The value applied when this option is selected.
|
|
final T value;
|
|
}
|
|
|
|
/// Supported community invite-link lifetimes.
|
|
const communityInviteTtlOptions = [
|
|
CommunityInviteOption(label: '1 day', value: 24 * 60 * 60),
|
|
CommunityInviteOption(label: '3 days', value: 3 * 24 * 60 * 60),
|
|
CommunityInviteOption(label: '7 days', value: 7 * 24 * 60 * 60),
|
|
CommunityInviteOption(label: '30 days', value: 30 * 24 * 60 * 60),
|
|
];
|
|
|
|
/// Supported usage limits for a community invite link.
|
|
const communityInviteMaxUseOptions = <CommunityInviteOption<int?>>[
|
|
CommunityInviteOption(label: 'No limit', value: null),
|
|
CommunityInviteOption(label: '1 use', value: 1),
|
|
CommunityInviteOption(label: '3 uses', value: 3),
|
|
CommunityInviteOption(label: '5 uses', value: 5),
|
|
CommunityInviteOption(label: '10 uses', value: 10),
|
|
CommunityInviteOption(label: '25 uses', value: 25),
|
|
];
|
|
|
|
/// A community invite link minted by the active relay.
|
|
@immutable
|
|
class MintedCommunityInvite {
|
|
/// Creates a parsed invite-link response.
|
|
const MintedCommunityInvite({
|
|
required this.code,
|
|
required this.expiresAt,
|
|
required this.url,
|
|
required this.maxUses,
|
|
required this.usesRemaining,
|
|
});
|
|
|
|
/// The relay-issued invite code.
|
|
final String code;
|
|
|
|
/// The invite's expiration time in Unix seconds.
|
|
final int expiresAt;
|
|
|
|
/// The complete URL that recipients can open.
|
|
final String url;
|
|
|
|
/// The total permitted uses, or null when unlimited.
|
|
final int? maxUses;
|
|
|
|
/// The number of uses still available, or null when unlimited.
|
|
final int? usesRemaining;
|
|
|
|
/// Parses a relay invite response.
|
|
factory MintedCommunityInvite.fromJson(Map<String, dynamic> json) {
|
|
return MintedCommunityInvite(
|
|
code: json['code'] as String,
|
|
expiresAt: json['expires_at'] as int,
|
|
url: json['url'] as String,
|
|
maxUses: json['max_uses'] as int?,
|
|
usesRemaining: json['uses_remaining'] as int?,
|
|
);
|
|
}
|
|
}
|
|
|
|
/// A relay directory identity that can be invited to a community.
|
|
@immutable
|
|
class CommunityInviteDirectoryUser {
|
|
/// Creates a directory identity for [pubkey] and optional profile metadata.
|
|
const CommunityInviteDirectoryUser({
|
|
required this.pubkey,
|
|
this.displayName,
|
|
this.avatarUrl,
|
|
this.nip05Handle,
|
|
});
|
|
|
|
/// The identity's lowercase hexadecimal Nostr public key.
|
|
final String pubkey;
|
|
|
|
/// The profile's preferred display name, when published.
|
|
final String? displayName;
|
|
|
|
/// The profile image URL, when published.
|
|
final String? avatarUrl;
|
|
|
|
/// The profile's NIP-05 identifier, when published.
|
|
final String? nip05Handle;
|
|
|
|
/// The best available human-readable identity label.
|
|
String get label {
|
|
final display = displayName?.trim();
|
|
if (display != null && display.isNotEmpty) return display;
|
|
final nip05 = nip05Handle?.trim();
|
|
if (nip05 != null && nip05.isNotEmpty) return nip05;
|
|
return shortPubkey(pubkey);
|
|
}
|
|
|
|
/// A supporting identity label distinct from [label].
|
|
String get secondaryLabel {
|
|
final nip05 = nip05Handle?.trim();
|
|
if (nip05 != null && nip05.isNotEmpty && nip05 != label) return nip05;
|
|
// The primary label is already the compact key when no name or NIP-05
|
|
// exists; a second key-shaped line would only duplicate it.
|
|
final display = displayName?.trim();
|
|
return display != null && display.isNotEmpty ? shortPubkey(pubkey) : '';
|
|
}
|
|
|
|
/// Avatar initial — name-derived when available, otherwise keyed to the
|
|
/// hex public key so unnamed identities keep distinct initials (a compact
|
|
/// npub would render `N` for everyone).
|
|
String get initial {
|
|
final display = displayName?.trim();
|
|
if (display != null && display.isNotEmpty) return display[0].toUpperCase();
|
|
final nip05 = nip05Handle?.trim();
|
|
if (nip05 != null && nip05.isNotEmpty) return nip05[0].toUpperCase();
|
|
return pubkey.isNotEmpty ? pubkey[0].toUpperCase() : '?';
|
|
}
|
|
}
|
|
|
|
/// Parses a hexadecimal public key or npub, returning lowercase hex.
|
|
String? parseCommunityInvitePubkey(String value) {
|
|
final normalized = value.trim();
|
|
final hexPattern = RegExp(r'^[0-9a-fA-F]{64}$');
|
|
if (hexPattern.hasMatch(normalized)) return normalized.toLowerCase();
|
|
try {
|
|
final decoded = nostr.Nip19.decode(payload: normalized);
|
|
if (decoded.prefix != nostr.Nip19Prefix.npub ||
|
|
!hexPattern.hasMatch(decoded.data)) {
|
|
return null;
|
|
}
|
|
return decoded.data.toLowerCase();
|
|
} catch (_) {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
/// Builds the Nostr tags for a kind:9030 community member invitation.
|
|
@visibleForTesting
|
|
List<List<String>> buildCommunityMemberInviteTags({
|
|
required String pubkey,
|
|
required CommunityMemberRole role,
|
|
}) => [
|
|
['p', pubkey.trim().toLowerCase()],
|
|
['role', role.name],
|
|
];
|
|
|
|
/// Creates invite links and submits direct community member invitations.
|
|
abstract class CommunityInviteActions {
|
|
/// Mints a community invite link with the requested limits.
|
|
Future<MintedCommunityInvite> mintInvite({
|
|
required int ttlSeconds,
|
|
required int? maxUses,
|
|
});
|
|
|
|
/// Invites each public key to the active community with [role].
|
|
Future<void> inviteMembers({
|
|
required Iterable<String> pubkeys,
|
|
required CommunityMemberRole role,
|
|
});
|
|
}
|
|
|
|
/// Relay-backed implementation of [CommunityInviteActions].
|
|
class RelayCommunityInviteActions implements CommunityInviteActions {
|
|
/// Creates invite actions bound to the active relay and signing session.
|
|
RelayCommunityInviteActions({
|
|
required http.Client httpClient,
|
|
required String baseUrl,
|
|
required String? nsec,
|
|
required SignedEventRelay signedEventRelay,
|
|
required bool Function() isCommunityActive,
|
|
}) : _httpClient = httpClient,
|
|
_baseUrl = baseUrl,
|
|
_nsec = nsec,
|
|
_signedEventRelay = signedEventRelay,
|
|
_isCommunityActive = isCommunityActive;
|
|
|
|
final http.Client _httpClient;
|
|
final String _baseUrl;
|
|
final String? _nsec;
|
|
final SignedEventRelay _signedEventRelay;
|
|
final bool Function() _isCommunityActive;
|
|
|
|
void _ensureCommunityActive() {
|
|
if (!_isCommunityActive()) {
|
|
throw StateError('Invite cancelled because the active community changed');
|
|
}
|
|
}
|
|
|
|
@override
|
|
Future<MintedCommunityInvite> mintInvite({
|
|
required int ttlSeconds,
|
|
required int? maxUses,
|
|
}) async {
|
|
_ensureCommunityActive();
|
|
final url = Uri.parse(_baseUrl).resolve('/api/invites').toString();
|
|
final body = <String, Object>{'ttl_secs': ttlSeconds};
|
|
if (maxUses != null) body['max_uses'] = maxUses;
|
|
final bodyBytes = utf8.encode(jsonEncode(body));
|
|
final response = await _httpClient
|
|
.post(
|
|
Uri.parse(url),
|
|
headers: {
|
|
'Authorization': buildNip98AuthHeader(
|
|
method: 'POST',
|
|
url: url,
|
|
bodyBytes: bodyBytes,
|
|
nsec: _nsec,
|
|
),
|
|
'Content-Type': 'application/json',
|
|
},
|
|
body: bodyBytes,
|
|
)
|
|
.timeout(const Duration(seconds: 15));
|
|
_ensureCommunityActive();
|
|
|
|
final dynamic decoded;
|
|
try {
|
|
decoded = jsonDecode(response.body);
|
|
} on FormatException {
|
|
throw Exception('Relay returned an invalid invite response');
|
|
}
|
|
if (response.statusCode < 200 || response.statusCode >= 300) {
|
|
final rawMessage = decoded is Map<String, dynamic>
|
|
? decoded['error']
|
|
: null;
|
|
final message = rawMessage is String ? rawMessage : null;
|
|
throw Exception(message ?? 'HTTP ${response.statusCode}');
|
|
}
|
|
if (decoded is! Map<String, dynamic>) {
|
|
throw Exception('Relay returned an invalid invite response');
|
|
}
|
|
return MintedCommunityInvite.fromJson(decoded);
|
|
}
|
|
|
|
@override
|
|
Future<void> inviteMembers({
|
|
required Iterable<String> pubkeys,
|
|
required CommunityMemberRole role,
|
|
}) async {
|
|
final normalizedPubkeys = <String>{};
|
|
for (final pubkey in pubkeys) {
|
|
final parsed = parseCommunityInvitePubkey(pubkey);
|
|
if (parsed != null) normalizedPubkeys.add(parsed);
|
|
}
|
|
for (final pubkey in normalizedPubkeys) {
|
|
_ensureCommunityActive();
|
|
await _signedEventRelay.submit(
|
|
kind: EventKind.relayAdminAddMember,
|
|
content: '',
|
|
tags: buildCommunityMemberInviteTags(pubkey: pubkey, role: role),
|
|
);
|
|
}
|
|
_ensureCommunityActive();
|
|
}
|
|
}
|
|
|
|
/// Supplies the HTTP client used to mint community invite links.
|
|
final communityInviteHttpClientProvider = Provider<http.Client>((ref) {
|
|
final client = ref.watch(hostedHttpClientFactoryProvider)();
|
|
ref.onDispose(client.close);
|
|
return client;
|
|
});
|
|
|
|
/// Supplies invite operations bound to the current community session.
|
|
final communityInviteActionsProvider = Provider<CommunityInviteActions>((ref) {
|
|
final config = ref.watch(relayConfigProvider);
|
|
final session = ref.read(relaySessionProvider.notifier);
|
|
return RelayCommunityInviteActions(
|
|
httpClient: ref.watch(communityInviteHttpClientProvider),
|
|
baseUrl: config.baseUrl,
|
|
nsec: config.nsec,
|
|
signedEventRelay: SignedEventRelay(session: session, nsec: config.nsec),
|
|
isCommunityActive: () {
|
|
final current = ref.read(relayConfigProvider);
|
|
return current.baseUrl == config.baseUrl && current.nsec == config.nsec;
|
|
},
|
|
);
|
|
});
|
|
|
|
List<CommunityInviteDirectoryUser> _directoryUsersFromEvents(
|
|
List<NostrEvent> events,
|
|
) {
|
|
final latestByPubkey = <String, NostrEvent>{};
|
|
for (final event in events) {
|
|
if (event.kind != 0) continue;
|
|
final pubkey = event.pubkey.toLowerCase();
|
|
final current = latestByPubkey[pubkey];
|
|
if (current == null || event.createdAt > current.createdAt) {
|
|
latestByPubkey[pubkey] = event;
|
|
}
|
|
}
|
|
final users = [
|
|
for (final event in latestByPubkey.values)
|
|
if (ProfileData.fromEvent(event) case final profile)
|
|
CommunityInviteDirectoryUser(
|
|
pubkey: profile.pubkey.toLowerCase(),
|
|
displayName: profile.displayName,
|
|
avatarUrl: profile.avatarUrl,
|
|
nip05Handle: profile.nip05,
|
|
),
|
|
];
|
|
users.sort((a, b) {
|
|
final byLabel = a.label.toLowerCase().compareTo(b.label.toLowerCase());
|
|
return byLabel != 0 ? byLabel : a.pubkey.compareTo(b.pubkey);
|
|
});
|
|
return users;
|
|
}
|
|
|
|
/// Resolves a pasted pubkey to its published profile on the active relay.
|
|
///
|
|
/// A valid npub already identifies an exact public key, so missing kind:0
|
|
/// metadata falls back to a pubkey-only person instead of blocking the invite.
|
|
/// Relay failures still surface as errors and malformed inputs return null.
|
|
final communityInviteProfileProvider = FutureProvider.autoDispose
|
|
.family<CommunityInviteDirectoryUser?, String>((ref, pubkey) async {
|
|
final normalized = parseCommunityInvitePubkey(pubkey);
|
|
if (normalized == null) return null;
|
|
ref.watch(relayConfigProvider);
|
|
final events = await ref.watch(relaySessionProvider.notifier).queryRelay([
|
|
NostrFilters.profile(normalized),
|
|
]);
|
|
for (final user in _directoryUsersFromEvents(events)) {
|
|
if (user.pubkey == normalized) return user;
|
|
}
|
|
return CommunityInviteDirectoryUser(pubkey: normalized);
|
|
});
|
|
|
|
/// Shares [inviteUrl] from an optional platform anchor rectangle.
|
|
typedef ShareCommunityInvite =
|
|
Future<void> Function(String inviteUrl, Rect? sharePositionOrigin);
|
|
|
|
/// Supplies the native share-sheet action for community invite links.
|
|
final shareCommunityInviteProvider = Provider<ShareCommunityInvite>((ref) {
|
|
return (inviteUrl, sharePositionOrigin) async {
|
|
await SharePlus.instance.share(
|
|
ShareParams(text: inviteUrl, sharePositionOrigin: sharePositionOrigin),
|
|
);
|
|
};
|
|
});
|