mirror of
https://github.com/block/buzz.git
synced 2026-10-31 06:21:34 +00:00
## Summary - add one strict `BUZZ_S3_ADDRESSING_STYLE=path|virtual` setting shared by media and Git/CAS storage - preserve path-style defaults for bundled Compose/Helm MinIO while supporting Railway's virtual-hosted bucket contract - fail startup on invalid or non-Unicode values before dependency connection, and validate the Helm value with the same two choices - document operator mappings and why endpoint and bucket remain separate for routing and SigV4 signing ## Best-practice rationale AWS documents both URL forms and favors virtual-hosted addressing for S3, while compatibility endpoints such as the bundled MinIO deployment can require path style. `rust-s3` defaults to virtual/subdomain addressing and provides `with_path_style()` for the explicit compatibility case. Some providers buckets only support as virtual-hosted bucket styles. This PR therefore uses one explicit, provider-neutral switch rather than endpoint heuristics or fallback behavior, while retaining `path` as Buzz's backward-compatible default. Sources: - https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html - https://docs.rs/rust-s3/0.37.0/s3/bucket/struct.Bucket.html - https://docs.railway.com/storage-buckets#url-style - https://github.com/minio/minio/blob/master/docs/config/README.md#domain ## Validation - `cargo fmt --all` - `cargo check --workspace --all-targets` - targeted `buzz-media` and `buzz-relay` parsing/client-construction tests for defaults, strict errors, and both URL styles - Helm unittest: 45/45 passed - Compose config/render validation passed - local MinIO path-mode relay startup passed the Git A3 conformance probe and became ready - unreachable object storage failed startup and readiness never opened - push hooks completed the broader Rust and desktop suites successfully --------- Signed-off-by: npub122y0pqkertljmedu303rl0aqrj3w8pvu43t6jxm6875lzg6f2pwqegc3xc <5288f082d91aff2de5bc8be23fbfa01ca2e3859cac57a91b7a3fa9f12349505c@buzz.block.builderlab.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz> Co-authored-by: npub122y0pqkertljmedu303rl0aqrj3w8pvu43t6jxm6875lzg6f2pwqegc3xc <5288f082d91aff2de5bc8be23fbfa01ca2e3859cac57a91b7a3fa9f12349505c@buzz.block.builderlab.xyz>
81 lines
3.2 KiB
Rust
81 lines
3.2 KiB
Rust
//! Live round-trip test for the **static-credentials** S3 path against an
|
|
//! S3-compatible service. It is guarded by `#[ignore]`.
|
|
//!
|
|
//! This is the path local/dev and any static-key deployment uses
|
|
//! (`s3_access_key`/`s3_secret_key` both non-empty -> `Credentials::new`). It
|
|
//! exists to prove that adding the IRSA/credential-chain fallback did **not**
|
|
//! regress hardcoded credentials.
|
|
//!
|
|
//! Run it against the docker-compose MinIO (creds `buzz_dev`/`buzz_dev_secret`,
|
|
//! bucket `buzz-media`, endpoint `http://localhost:9000`):
|
|
//!
|
|
//! ```bash
|
|
//! docker compose up -d minio minio-init
|
|
//! cargo test -p buzz-media --test static_creds_minio -- --ignored
|
|
//! ```
|
|
//!
|
|
//! Overridable via `BUZZ_S3_ENDPOINT` / `BUZZ_S3_ACCESS_KEY` /
|
|
//! `BUZZ_S3_SECRET_KEY` / `BUZZ_S3_BUCKET` / `BUZZ_S3_REGION` /
|
|
//! `BUZZ_S3_ADDRESSING_STYLE`. The default remains `path` for MinIO.
|
|
|
|
use buzz_media::config::MediaConfig;
|
|
use buzz_media::storage::MediaStorage;
|
|
|
|
fn minio_config() -> MediaConfig {
|
|
MediaConfig {
|
|
s3_endpoint: std::env::var("BUZZ_S3_ENDPOINT")
|
|
.unwrap_or_else(|_| "http://localhost:9000".to_string()),
|
|
s3_access_key: std::env::var("BUZZ_S3_ACCESS_KEY")
|
|
.unwrap_or_else(|_| "buzz_dev".to_string()),
|
|
s3_secret_key: std::env::var("BUZZ_S3_SECRET_KEY")
|
|
.unwrap_or_else(|_| "buzz_dev_secret".to_string()),
|
|
s3_bucket: std::env::var("BUZZ_S3_BUCKET").unwrap_or_else(|_| "buzz-media".to_string()),
|
|
s3_region: std::env::var("BUZZ_S3_REGION").unwrap_or_else(|_| "us-east-1".to_string()),
|
|
s3_addressing_style: std::env::var("BUZZ_S3_ADDRESSING_STYLE")
|
|
.unwrap_or_else(|_| "path".to_string())
|
|
.parse()
|
|
.expect("BUZZ_S3_ADDRESSING_STYLE must be path or virtual"),
|
|
max_image_bytes: 50 * 1024 * 1024,
|
|
max_gif_bytes: 10 * 1024 * 1024,
|
|
max_video_bytes: 524_288_000,
|
|
max_file_bytes: 104_857_600,
|
|
public_base_url: "http://localhost:3000/media".to_string(),
|
|
upload_records_enabled: false,
|
|
upload_ip_header: None,
|
|
upload_port_header: None,
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
#[ignore = "requires a live MinIO (docker compose up -d minio minio-init)"]
|
|
async fn static_creds_round_trip_against_minio() {
|
|
let storage =
|
|
MediaStorage::new(&minio_config()).expect("static creds should build a storage client");
|
|
|
|
let key = format!("_test/static-creds-{}.bin", std::process::id());
|
|
let body = b"hardcoded-creds-still-work";
|
|
|
|
// PUT
|
|
storage
|
|
.put(&key, body, "application/octet-stream")
|
|
.await
|
|
.expect("put with static creds should succeed");
|
|
|
|
// HEAD -> exists with correct size
|
|
assert!(storage.head(&key).await.expect("head should succeed"));
|
|
let meta = storage
|
|
.head_with_metadata(&key)
|
|
.await
|
|
.expect("head_with_metadata should succeed")
|
|
.expect("object should exist");
|
|
assert_eq!(meta.size, body.len() as u64);
|
|
|
|
// GET round-trips the bytes
|
|
let got = storage.get(&key).await.expect("get should succeed");
|
|
assert_eq!(got, body);
|
|
|
|
// DELETE, then HEAD reports absence
|
|
storage.delete(&key).await.expect("delete should succeed");
|
|
assert!(!storage.head(&key).await.expect("head after delete"));
|
|
}
|