mirror of
https://github.com/block/buzz.git
synced 2026-10-31 06:21:34 +00:00
🤖 ## Summary Building on #7488's npub foundation, this PR finishes the identity display change for the controls where you actually manage people and keys: profile, settings, agent access, and workflows. Everywhere in these surfaces, an identity key shows — and copies — as its canonical npub (npub is the human-readable encoding of a Nostr public key: the compact `npub1j57...fjmv` form where space is tight, the full npub where the whole key matters), and accepts npub as input. After this change: - Profile panel: the public-key row and the managed-by / declared-owner copies show the full npub. If a key can't be encoded, you see "Unavailable" with no copy button — never a raw or partial key. - Settings: the identity card shows and copies the npub. The hosted-communities account identity derives from the bound key (`pubkey_hex`) — the same authority as the mismatch gate and hosted operations — so the display can never disagree with what the app acts on; an unusable hex falls back to a neutral label instead of rendering the unverified server npub. The connected claim and a community's Connect action require that same usable bound key to match the local one — with no usable binding the card cannot claim connected or start Connect, while the community list, linking, and delete/rebind recovery stay available. - Hosted create/onboarding: the account and device identity rows in the create flow and owner onboarding derive from the same authoritative fields (bound key / local key), with the same neutral fallback; readiness requires a usable bound key that matches the local one. - Respond-to allowlist (controls who may respond to an agent): entries can be typed or pasted as hex or npub; both spellings of the same key are recognized as one entry and dedupe. Search results, chips, and remove buttons use the compact npub. - Workflow key fields: to/from keys display as npubs in the form and save back as canonical hex. Templates like `{{trigger.author}}`, roles, and free text pass through untouched; placeholders accept both spellings. - Recipient and agent dialogs: the verify popover is npub-only (the raw-hex line is gone); denied-membership screens never show a raw key. - The Rust-side truncated display name (used for native surfaces) shows the same compact npub, so those surfaces match the web UI. Internal representation is unchanged: keys are still stored, sent, and matched as canonical 64-character hex — npub is a display and input spelling, normalized to hex at the boundary, so existing data and integrations keep working. Bound-key usability and comparison use one normalized form (trimmed, lowercased, 64 hex characters; npub rejected), so padded or mixed-case spellings of the same key match. Display names, private keys, and event IDs are untouched. ## Details - `respondToAllowlist` / `RespondToField`: npub entries normalize to canonical hex; cross-form dedupe; compact npub in rows and chips; direct-add accepts npub and stores canonical hex. - `workflowFormTypes` / `WorkflowStepCard`: hex → npub for display, npub → canonical hex on save; templates, roles, and free text pass through in both directions (roundtrip-tested). - `UserProfilePanelFields`, `ProfileSettingsCard`, `HostedCommunitiesSettingsCard`, `MembershipDenied`, `SelectedRecipientChip`, `AddAgentToChannelDialog`: npub display and copy; invalid keys → "Unavailable" with no copy; hosted identity rows derive from the bound `pubkey_hex` (create/onboarding rows from the bound and local keys), never the unverified server npub; connected/readiness/Connect gates use the same usable-bound-key predicate, and the settings Connect invocation callback re-checks it before starting. - `src-tauri/src/commands/identity.rs`: `truncated_display_name` compacts to the first 8 + last 4 characters of the npub (above a 12-char threshold), mirroring `truncateNpub`. - e2e: profile key rows and clipboard polls assert npub forms and raw-hex suppression; the display-screenshots spec pins the npub-only popover; hosted specs drive the real settings card, create flow, and onboarding rows through their real providers, and the unlinked/npub-only identity cases assert no connected claim and no Connect action. ### Related issue - Fixes: N/A. No separate issue; the related work is the stack below. - Stack: builds on #7488 (shared npub foundation), now merged; this PR is rebased onto main and stands on its own. ### Testing At head `303c90ffa` (base: main `bfc38485`; 24 files, +1125/−146): - Focused unit suites (respondToAllowlist, workflowFormTypes, hostedCommunityApi bound-key helpers) green; mutation-checked — dropping allowlist canonicalization fails the dedupe case, and dropping bound-key normalization fails the npub-in-hex and padded same-key cases. - Full desktop unit suite 6,477/6,477, `desktop-typecheck`, `desktop-check` (formatting fixed narrowly with `biome check --write` on the touched files only), and a fresh E2E build at the current head; the add-community + hosted-communities-settings specs 18/18 and onboarding integration 69/69 on a fresh dedicated port, with focused new-case runs 4+4 covering padded same-key (ready, Connect kept — no false rebind) and npub-in-hex (neutral label, recovery, no Connect) across the settings card, create flow, and first-community onboarding, plus the unlinked-account settings regression asserting Connect cannot occur. - `cargo fmt`/clippy (both feature sets) and `cargo test identity` (71 pass) passed at the earlier full-change head; since then, the only production changes in this PR's delta are the hosted identity display authority and its fail-closed bound-key gating/normalization above (base-side fixes carry #7488's receipts) — every other change is test-only. ### Task provenance Buzz channel: `1f0e4a3d-7e01-4efe-bb16-843b357f85c9` Task: buzz://message?channel=1f0e4a3d-7e01-4efe-bb16-843b357f85c9&id=86b34eb4bd84a1472419e9af22636c011c0fe273e3c196f967d7a36996e149b6 --------- Signed-off-by: Logan Johnson <loganj@squareup.com> Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
209 lines
6.8 KiB
TypeScript
209 lines
6.8 KiB
TypeScript
import { expect, test } from "@playwright/test";
|
|
import { npubEncode } from "nostr-tools/nip19";
|
|
|
|
import { waitForAnimations } from "../helpers/animations";
|
|
import { installMockBridge } from "../helpers/bridge";
|
|
|
|
const OUTDIR = "test-results/add-community";
|
|
const DEFAULT_MOCK_PUBKEY = "deadbeef".repeat(8);
|
|
const COMMUNITIES = [
|
|
{
|
|
id: "ws-a",
|
|
name: "Alpha",
|
|
relayUrl: "ws://localhost:3000",
|
|
addedAt: "2026-01-01T00:00:00.000Z",
|
|
},
|
|
{
|
|
id: "ws-b",
|
|
name: "Bravo",
|
|
relayUrl: "ws://localhost:3001",
|
|
addedAt: "2026-01-02T00:00:00.000Z",
|
|
},
|
|
];
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.addInitScript((communities) => {
|
|
window.localStorage.setItem(
|
|
"buzz-communities",
|
|
JSON.stringify(communities),
|
|
);
|
|
window.localStorage.setItem("buzz-active-community-id", communities[0].id);
|
|
}, COMMUNITIES);
|
|
await installMockBridge(
|
|
page,
|
|
{
|
|
builderlabAuth: {
|
|
email: "owner@example.com",
|
|
expiresAt: "2099-01-01T00:00:00Z",
|
|
},
|
|
builderlabIdentity: { pubkey_hex: DEFAULT_MOCK_PUBKEY },
|
|
},
|
|
{
|
|
skipCommunitySeed: true,
|
|
},
|
|
);
|
|
await page.goto("/");
|
|
await page.getByTestId("community-rail-add").click();
|
|
});
|
|
|
|
test("identity: npub-only account key is recovery, never a ready create flow", async ({
|
|
page,
|
|
}) => {
|
|
await installMockBridge(
|
|
page,
|
|
{
|
|
builderlabAuth: {
|
|
email: "old-owner@example.com",
|
|
expiresAt: "2099-01-01T00:00:00Z",
|
|
},
|
|
builderlabIdentity: {
|
|
// The identity object is present but carries no authoritative
|
|
// pubkey_hex — only the independent, unverified server npub.
|
|
npub: npubEncode("b".repeat(64)),
|
|
},
|
|
},
|
|
{ skipCommunitySeed: true },
|
|
);
|
|
await page.reload();
|
|
await page.getByTestId("community-rail-add").click();
|
|
await page.getByTestId("add-community-create").click();
|
|
// Presence of the identity object must not read as a ready account: the
|
|
// mismatch recovery branch owns the create tab instead.
|
|
await expect(
|
|
page.getByText("This Builderlab account uses a different Buzz identity."),
|
|
).toBeVisible();
|
|
await expect(page.getByText("Account: Unavailable")).toBeVisible();
|
|
await expect(
|
|
page.getByText(`This device: ${npubEncode(DEFAULT_MOCK_PUBKEY)}`),
|
|
).toBeVisible();
|
|
// The create form — and with it the create action — stays unrendered.
|
|
await expect(page.getByTestId("hosted-community-create-name")).toHaveCount(0);
|
|
await expect(page.getByTestId("hosted-community-create-submit")).toHaveCount(
|
|
0,
|
|
);
|
|
// The unverified hosted npub spelling never renders.
|
|
await expect(page.getByText(npubEncode("b".repeat(64)))).toHaveCount(0);
|
|
// Recovery stays explicit.
|
|
await expect(
|
|
page.getByRole("button", { name: "Use this device" }),
|
|
).toBeVisible();
|
|
});
|
|
|
|
test("identity: padded same-key hex is a ready create flow, not a mismatch", async ({
|
|
page,
|
|
}) => {
|
|
await installMockBridge(
|
|
page,
|
|
{
|
|
builderlabAuth: {
|
|
email: "owner@example.com",
|
|
expiresAt: "2099-01-01T00:00:00Z",
|
|
},
|
|
builderlabIdentity: {
|
|
// This device's own key, padded and uppercased: the same key
|
|
// after normalization, so the account is ready — never a mismatch
|
|
// demanding a delete/rebind of the identity it already holds.
|
|
pubkey_hex: ` ${DEFAULT_MOCK_PUBKEY.toUpperCase()} `,
|
|
},
|
|
},
|
|
{ skipCommunitySeed: true },
|
|
);
|
|
await page.reload();
|
|
await page.getByTestId("community-rail-add").click();
|
|
await page.getByTestId("add-community-create").click();
|
|
// The create form — and with it the create action — is available.
|
|
await expect(page.getByTestId("hosted-community-create-name")).toBeVisible();
|
|
await expect(
|
|
page.getByText("This Builderlab account uses a different Buzz identity."),
|
|
).toHaveCount(0);
|
|
});
|
|
|
|
test("capture: add-community choices", async ({ page }) => {
|
|
const dialog = page.getByTestId("add-community-dialog");
|
|
await dialog.waitFor();
|
|
await waitForAnimations(page);
|
|
await dialog.screenshot({ path: `${OUTDIR}/01-choices.png` });
|
|
});
|
|
|
|
test("capture: join an existing community", async ({ page }) => {
|
|
await page.getByTestId("add-community-join").click();
|
|
const dialog = page.getByTestId("add-community-dialog");
|
|
const communityUrl = page.getByLabel("Community URL or invite link");
|
|
await communityUrl.fill("community.example.com");
|
|
await page.getByTestId("community-api-token-reveal").waitFor({
|
|
state: "detached",
|
|
});
|
|
await waitForAnimations(page);
|
|
await dialog.screenshot({ path: `${OUTDIR}/02-join.png` });
|
|
});
|
|
|
|
test("capture: create a new community", async ({ page }) => {
|
|
await page.getByTestId("add-community-create").click();
|
|
const dialog = page.getByTestId("add-community-dialog");
|
|
await page.getByLabel("Community address").waitFor();
|
|
await waitForAnimations(page);
|
|
await dialog.screenshot({ path: `${OUTDIR}/03-create.png` });
|
|
});
|
|
|
|
test("identity: create owner shows the bound key's npub, never the hosted npub or raw hex", async ({
|
|
page,
|
|
}) => {
|
|
await installMockBridge(
|
|
page,
|
|
{
|
|
builderlabAuth: {
|
|
email: "old-owner@example.com",
|
|
expiresAt: "2099-01-01T00:00:00Z",
|
|
},
|
|
builderlabIdentity: {
|
|
pubkey_hex: "f".repeat(64),
|
|
npub: npubEncode("b".repeat(64)),
|
|
},
|
|
},
|
|
{ skipCommunitySeed: true },
|
|
);
|
|
await page.reload();
|
|
await page.getByTestId("community-rail-add").click();
|
|
await page.getByTestId("add-community-create").click();
|
|
await expect(
|
|
page.getByText("This Builderlab account uses a different Buzz identity."),
|
|
).toBeVisible();
|
|
await expect(
|
|
page.getByText(`Account: ${npubEncode("f".repeat(64))}`),
|
|
).toBeVisible();
|
|
await expect(
|
|
page.getByText(`This device: ${npubEncode(DEFAULT_MOCK_PUBKEY)}`),
|
|
).toBeVisible();
|
|
await expect(page.getByText(npubEncode("b".repeat(64)))).toHaveCount(0);
|
|
await expect(page.getByText("f".repeat(64))).toHaveCount(0);
|
|
});
|
|
|
|
test("identity: create owner renders the neutral label when the bound hex is unusable", async ({
|
|
page,
|
|
}) => {
|
|
await installMockBridge(
|
|
page,
|
|
{
|
|
builderlabAuth: {
|
|
email: "old-owner@example.com",
|
|
expiresAt: "2099-01-01T00:00:00Z",
|
|
},
|
|
builderlabIdentity: {
|
|
// Valid hex alphabet, wrong length — unusable as an identity key.
|
|
pubkey_hex: "f".repeat(63),
|
|
npub: npubEncode("b".repeat(64)),
|
|
},
|
|
},
|
|
{ skipCommunitySeed: true },
|
|
);
|
|
await page.reload();
|
|
await page.getByTestId("community-rail-add").click();
|
|
await page.getByTestId("add-community-create").click();
|
|
await expect(
|
|
page.getByText("This Builderlab account uses a different Buzz identity."),
|
|
).toBeVisible();
|
|
await expect(page.getByText("Account: Unavailable")).toBeVisible();
|
|
await expect(page.getByText(npubEncode("b".repeat(64)))).toHaveCount(0);
|
|
await expect(page.getByText("f".repeat(63))).toHaveCount(0);
|
|
});
|