Files
buzz/mobile/test/shared/emoji/emoji_burst_test.dart
klopez4212 85edc0572a feat(mobile): desktop-parity emoji and thread experience (#3485)
Brings the Flutter app's emoji and thread surfaces up to desktop parity.

## Emoji

- **Full emoji-mart dataset** generated from the same `@emoji-mart/data`
set desktop uses (1,870 emoji, 8 categories), committed as an asset — so
shortcodes, names, and keywords are identical across clients. `just
mobile-emoji-data` regenerates it.
- **Rebuilt the tray**: search (a Dart port of desktop's tiered
`emojiSearch` ranking, extended to names and keywords), a
frequently-used section, and one continuous scroll with pinned section
headers. The category rail is a shortcut into that list, not a page
switcher, and spans the full width the search field uses. Custom emoji
share the native glyph size and cell.
- **Reaction pills** match desktop's geometry, and the count shows at 1.
- **Emoji-only messages** render at 36px with 1.45em inline custom
emoji, matching desktop's `emojiOnly` treatment.
- **Positive-emoji burst** ported from desktop's `EmojiBurstProvider`,
suppressed under reduced motion.

## Threads

- **Top-down layout** — head first under the app bar, replies flowing
down, like desktop's thread panel. The old reversed list bottom-anchored
the content and jammed the head against the composer.
- **Tap a channel message to open its thread**; long-press still opens
the action sheet.
- **Live reactions.** The thread's relay query is one-shot and its
`kinds` filter carries only content rows, so a reaction event could not
reach an open thread at all, and `allMessages` was a snapshot frozen
when the route was pushed — a new pill only appeared after leaving and
re-entering, which refetched. The live channel events are now unioned
into the thread's list. The burst is also route-guarded, since the
channel timeline stays mounted underneath and was claiming it first.
- The `+` affordance follows the channel: replies stay bare until they
carry a reaction, and the head keeps a standing `+`.

## Keyboard

A deliberate downward drag past ~48px dismisses the keyboard; short
scrolls leave it alone. Applies to the channel list, the thread list,
and the compose bar (via a raw `Listener`, so it can't steal the field's
tap or selection drags).

True finger-tracking dismissal is out of scope — Flutter only offers
`manual`/`onDrag`, and 1:1 tracking needs a native `UIScrollView` proxy
plus Android's `WindowInsetsAnimationController`.

## Testing

`just mobile-check` and `just mobile-test` pass (965 tests). New
coverage for emoji search ranking, dataset parsing, the emoji-only
predicate, tray scroll/rail behavior, reaction pills and the burst, and
both thread fixes above. `just ci` green.

---------

Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: npub12zsjdqx8dud99s9h47xmk9lq93vryf7zjrae8wdrmma52cg5yglseyulst <50a12680c76f1a52c0b7af8dbb17e02c583227c290fb93b9a3defb456114223f@buzz.block.builderlab.xyz>
Signed-off-by: klopez4212 <klopez4212@gmail.com>
Co-authored-by: npub12zsjdqx8dud99s9h47xmk9lq93vryf7zjrae8wdrmma52cg5yglseyulst <50a12680c76f1a52c0b7af8dbb17e02c583227c290fb93b9a3defb456114223f@buzz.block.builderlab.xyz>
2026-07-30 07:29:40 -07:00

228 lines
6.9 KiB
Dart

import 'package:buzz/shared/emoji/emoji_burst.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
const _fire = '\u{1F525}';
/// Run the controller forward until it says it is done, capped so a physics
/// regression fails the test instead of hanging it.
int _runToCompletion(EmojiBurstController controller, {int maxSteps = 600}) {
var steps = 0;
while (controller.hasParticles && steps < maxSteps) {
controller.step();
steps += 1;
}
return steps;
}
void main() {
group('EmojiBurstController', () {
test('a burst spawns particles and eventually clears itself', () {
final controller = EmojiBurstController();
addTearDown(controller.dispose);
expect(controller.hasParticles, isFalse);
controller.burst(_fire, const Offset(100, 200));
expect(controller.hasParticles, isTrue);
final steps = _runToCompletion(controller);
expect(controller.hasParticles, isFalse);
// Desktop's particles live 108 frames and fade over the last 24%.
expect(steps, lessThanOrEqualTo(108));
expect(steps, greaterThan(60));
});
test('ignores a blank emoji', () {
final controller = EmojiBurstController();
addTearDown(controller.dispose);
controller.burst(' ', Offset.zero);
expect(controller.hasParticles, isFalse);
});
test('notifies on spawn and on every step', () {
final controller = EmojiBurstController();
addTearDown(controller.dispose);
var notifications = 0;
controller.addListener(() => notifications += 1);
controller.burst(_fire, Offset.zero);
expect(notifications, 1);
controller.step();
expect(notifications, 2);
});
test('calls onSpawn so the overlay can start its ticker', () {
final controller = EmojiBurstController();
addTearDown(controller.dispose);
var spawns = 0;
controller.onSpawn = () => spawns += 1;
controller.burst(_fire, Offset.zero);
controller.burst(_fire, Offset.zero);
expect(spawns, 2);
});
test('caps the active particle count', () {
final controller = EmojiBurstController();
addTearDown(controller.dispose);
// Far more bursts than the cap allows, with no steps in between so
// nothing expires.
for (var i = 0; i < 200; i += 1) {
controller.burst(_fire, Offset.zero);
}
// Still bounded, and still animating rather than wedged.
expect(controller.hasParticles, isTrue);
_runToCompletion(controller);
expect(controller.hasParticles, isFalse);
});
test('clear drops everything immediately', () {
final controller = EmojiBurstController();
addTearDown(controller.dispose);
controller.burst(_fire, Offset.zero);
controller.clear();
expect(controller.hasParticles, isFalse);
});
});
group('PendingReactionBurstNotifier', () {
ProviderContainer container() {
final result = ProviderContainer();
addTearDown(result.dispose);
return result;
}
test('arms only positive emoji', () {
final ref = container();
final notifier = ref.read(pendingReactionBurstProvider.notifier);
notifier.arm('msg-1', '\u{1F44E}'); // 👎
expect(ref.read(pendingReactionBurstProvider), isNull);
notifier.arm('msg-1', _fire);
expect(
ref.read(pendingReactionBurstProvider),
const PendingReactionBurst(messageId: 'msg-1', emoji: _fire),
);
});
test('claim succeeds once, so one pill bursts when a message is on screen '
'twice', () {
final ref = container();
final notifier = ref.read(pendingReactionBurstProvider.notifier);
const target = PendingReactionBurst(messageId: 'msg-1', emoji: _fire);
notifier.arm('msg-1', _fire);
expect(notifier.claim(target), isTrue);
expect(notifier.claim(target), isFalse);
expect(ref.read(pendingReactionBurstProvider), isNull);
});
test('a claim for a different message or emoji does not consume it', () {
final ref = container();
final notifier = ref.read(pendingReactionBurstProvider.notifier);
notifier.arm('msg-1', _fire);
expect(
notifier.claim(
const PendingReactionBurst(messageId: 'msg-2', emoji: _fire),
),
isFalse,
);
expect(
notifier.claim(
const PendingReactionBurst(messageId: 'msg-1', emoji: '\u{1F389}'),
),
isFalse,
);
expect(ref.read(pendingReactionBurstProvider), isNotNull);
});
test('a newer arm replaces the pending one', () {
final ref = container();
final notifier = ref.read(pendingReactionBurstProvider.notifier);
notifier.arm('msg-1', _fire);
notifier.arm('msg-2', '\u{1F389}');
expect(
ref.read(pendingReactionBurstProvider),
const PendingReactionBurst(messageId: 'msg-2', emoji: '\u{1F389}'),
);
});
});
group('EmojiBurstOverlay', () {
testWidgets('paints its child and drains the burst', (tester) async {
late EmojiBurstController controller;
await tester.pumpWidget(
ProviderScope(
child: MaterialApp(
home: Consumer(
builder: (context, ref, _) {
controller = ref.watch(emojiBurstControllerProvider);
return const EmojiBurstOverlay(child: Text('body'));
},
),
),
),
);
expect(find.text('body'), findsOneWidget);
controller.burst(_fire, const Offset(120, 240));
expect(controller.hasParticles, isTrue);
// Physics advances a bounded number of fixed steps per frame (no
// catch-up spiral), so drain it a frame at a time — 130 frames is past
// the 108-frame particle life.
await tester.pump();
for (var frame = 0; frame < 130; frame += 1) {
await tester.pump(const Duration(milliseconds: 16));
}
expect(controller.hasParticles, isFalse);
});
testWidgets('the overlay never takes a tap from the app below', (
tester,
) async {
var taps = 0;
late EmojiBurstController controller;
await tester.pumpWidget(
ProviderScope(
child: MaterialApp(
home: Consumer(
builder: (context, ref, _) {
controller = ref.watch(emojiBurstControllerProvider);
return EmojiBurstOverlay(
child: Center(
child: GestureDetector(
onTap: () => taps += 1,
child: const Text('tap me'),
),
),
);
},
),
),
),
);
controller.burst(_fire, const Offset(200, 400));
await tester.pump();
await tester.tap(find.text('tap me'));
expect(taps, 1);
});
});
}