mirror of
https://github.com/block/buzz.git
synced 2026-10-31 22:41:12 +00:00
85edc0572a
Brings the Flutter app's emoji and thread surfaces up to desktop parity. ## Emoji - **Full emoji-mart dataset** generated from the same `@emoji-mart/data` set desktop uses (1,870 emoji, 8 categories), committed as an asset — so shortcodes, names, and keywords are identical across clients. `just mobile-emoji-data` regenerates it. - **Rebuilt the tray**: search (a Dart port of desktop's tiered `emojiSearch` ranking, extended to names and keywords), a frequently-used section, and one continuous scroll with pinned section headers. The category rail is a shortcut into that list, not a page switcher, and spans the full width the search field uses. Custom emoji share the native glyph size and cell. - **Reaction pills** match desktop's geometry, and the count shows at 1. - **Emoji-only messages** render at 36px with 1.45em inline custom emoji, matching desktop's `emojiOnly` treatment. - **Positive-emoji burst** ported from desktop's `EmojiBurstProvider`, suppressed under reduced motion. ## Threads - **Top-down layout** — head first under the app bar, replies flowing down, like desktop's thread panel. The old reversed list bottom-anchored the content and jammed the head against the composer. - **Tap a channel message to open its thread**; long-press still opens the action sheet. - **Live reactions.** The thread's relay query is one-shot and its `kinds` filter carries only content rows, so a reaction event could not reach an open thread at all, and `allMessages` was a snapshot frozen when the route was pushed — a new pill only appeared after leaving and re-entering, which refetched. The live channel events are now unioned into the thread's list. The burst is also route-guarded, since the channel timeline stays mounted underneath and was claiming it first. - The `+` affordance follows the channel: replies stay bare until they carry a reaction, and the head keeps a standing `+`. ## Keyboard A deliberate downward drag past ~48px dismisses the keyboard; short scrolls leave it alone. Applies to the channel list, the thread list, and the compose bar (via a raw `Listener`, so it can't steal the field's tap or selection drags). True finger-tracking dismissal is out of scope — Flutter only offers `manual`/`onDrag`, and 1:1 tracking needs a native `UIScrollView` proxy plus Android's `WindowInsetsAnimationController`. ## Testing `just mobile-check` and `just mobile-test` pass (965 tests). New coverage for emoji search ranking, dataset parsing, the emoji-only predicate, tray scroll/rail behavior, reaction pills and the burst, and both thread fixes above. `just ci` green. --------- Signed-off-by: kenny lopez <klopez4212@gmail.com> Signed-off-by: npub12zsjdqx8dud99s9h47xmk9lq93vryf7zjrae8wdrmma52cg5yglseyulst <50a12680c76f1a52c0b7af8dbb17e02c583227c290fb93b9a3defb456114223f@buzz.block.builderlab.xyz> Signed-off-by: klopez4212 <klopez4212@gmail.com> Co-authored-by: npub12zsjdqx8dud99s9h47xmk9lq93vryf7zjrae8wdrmma52cg5yglseyulst <50a12680c76f1a52c0b7af8dbb17e02c583227c290fb93b9a3defb456114223f@buzz.block.builderlab.xyz>
82 lines
2.6 KiB
Dart
82 lines
2.6 KiB
Dart
import 'dart:convert';
|
|
import 'dart:io';
|
|
|
|
import 'package:buzz/shared/emoji/emoji_data.dart';
|
|
import 'package:buzz/shared/emoji/emoji_data_provider.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
/// Reads the committed asset straight off disk rather than through
|
|
/// `rootBundle`, so this test guards the generated file itself — if
|
|
/// `just mobile-emoji-data` ever emits a different shape, this fails.
|
|
EmojiDataset _loadFromDisk() {
|
|
final source = File(emojiDataAssetPath).readAsStringSync();
|
|
return EmojiDataset.fromJson(jsonDecode(source) as Map<String, dynamic>);
|
|
}
|
|
|
|
void main() {
|
|
late EmojiDataset dataset;
|
|
|
|
setUpAll(() {
|
|
dataset = _loadFromDisk();
|
|
});
|
|
|
|
test('parses every emoji-mart category in order', () {
|
|
expect(dataset.categories.map((category) => category.id), [
|
|
'people',
|
|
'nature',
|
|
'foods',
|
|
'activity',
|
|
'places',
|
|
'objects',
|
|
'symbols',
|
|
'flags',
|
|
]);
|
|
});
|
|
|
|
test('carries the full standard set, not a hand-picked subset', () {
|
|
// The hardcoded list this replaced had ~140 glyphs; emoji-mart ships ~1.9k.
|
|
expect(dataset.all.length, greaterThan(1800));
|
|
expect(
|
|
dataset.all.length,
|
|
dataset.categories.fold<int>(
|
|
0,
|
|
(total, category) => total + category.emoji.length,
|
|
),
|
|
);
|
|
});
|
|
|
|
test('every entry has an id, a glyph, and a category', () {
|
|
for (final entry in dataset.all) {
|
|
expect(entry.id, isNotEmpty);
|
|
expect(entry.native, isNotEmpty);
|
|
expect(entry.categoryId, isNotEmpty);
|
|
}
|
|
});
|
|
|
|
test('resolves glyphs back to desktop-identical shortcodes', () {
|
|
expect(dataset.nativeToShortcode['💯'], ':100:');
|
|
expect(dataset.nativeToShortcode['🔥'], ':fire:');
|
|
expect(dataset.nativeToShortcode['☝️'], ':point_up:');
|
|
expect(dataset.nativeToShortcode['👍🏽'], ':+1:');
|
|
expect(
|
|
dataset.all
|
|
.where((entry) => entry.id == '+1')
|
|
.map((entry) => entry.native),
|
|
containsAll(['👍', '👍🏻', '👍🏼', '👍🏽', '👍🏾', '👍🏿']),
|
|
);
|
|
});
|
|
|
|
test('displayName mirrors desktop emojiDisplayName', () {
|
|
expect(dataset.displayName('🎉'), ':tada:');
|
|
// Custom emoji already arrive as a shortcode and pass through untouched.
|
|
expect(dataset.displayName(':party_parrot:'), ':party_parrot:');
|
|
// Unknown glyphs fall back to themselves rather than a bogus name.
|
|
expect(dataset.displayName('\u{1FAF6}\u{200D}\u{2764}'), isNotEmpty);
|
|
});
|
|
|
|
test('empty dataset degrades safely', () {
|
|
expect(EmojiDataset.empty.isEmpty, isTrue);
|
|
expect(EmojiDataset.empty.displayName('🔥'), '🔥');
|
|
});
|
|
}
|