Files
buzz/mobile/test/shared/emoji/emoji_search_test.dart
klopez4212 85edc0572a feat(mobile): desktop-parity emoji and thread experience (#3485)
Brings the Flutter app's emoji and thread surfaces up to desktop parity.

## Emoji

- **Full emoji-mart dataset** generated from the same `@emoji-mart/data`
set desktop uses (1,870 emoji, 8 categories), committed as an asset — so
shortcodes, names, and keywords are identical across clients. `just
mobile-emoji-data` regenerates it.
- **Rebuilt the tray**: search (a Dart port of desktop's tiered
`emojiSearch` ranking, extended to names and keywords), a
frequently-used section, and one continuous scroll with pinned section
headers. The category rail is a shortcut into that list, not a page
switcher, and spans the full width the search field uses. Custom emoji
share the native glyph size and cell.
- **Reaction pills** match desktop's geometry, and the count shows at 1.
- **Emoji-only messages** render at 36px with 1.45em inline custom
emoji, matching desktop's `emojiOnly` treatment.
- **Positive-emoji burst** ported from desktop's `EmojiBurstProvider`,
suppressed under reduced motion.

## Threads

- **Top-down layout** — head first under the app bar, replies flowing
down, like desktop's thread panel. The old reversed list bottom-anchored
the content and jammed the head against the composer.
- **Tap a channel message to open its thread**; long-press still opens
the action sheet.
- **Live reactions.** The thread's relay query is one-shot and its
`kinds` filter carries only content rows, so a reaction event could not
reach an open thread at all, and `allMessages` was a snapshot frozen
when the route was pushed — a new pill only appeared after leaving and
re-entering, which refetched. The live channel events are now unioned
into the thread's list. The burst is also route-guarded, since the
channel timeline stays mounted underneath and was claiming it first.
- The `+` affordance follows the channel: replies stay bare until they
carry a reaction, and the head keeps a standing `+`.

## Keyboard

A deliberate downward drag past ~48px dismisses the keyboard; short
scrolls leave it alone. Applies to the channel list, the thread list,
and the compose bar (via a raw `Listener`, so it can't steal the field's
tap or selection drags).

True finger-tracking dismissal is out of scope — Flutter only offers
`manual`/`onDrag`, and 1:1 tracking needs a native `UIScrollView` proxy
plus Android's `WindowInsetsAnimationController`.

## Testing

`just mobile-check` and `just mobile-test` pass (965 tests). New
coverage for emoji search ranking, dataset parsing, the emoji-only
predicate, tray scroll/rail behavior, reaction pills and the burst, and
both thread fixes above. `just ci` green.

---------

Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: npub12zsjdqx8dud99s9h47xmk9lq93vryf7zjrae8wdrmma52cg5yglseyulst <50a12680c76f1a52c0b7af8dbb17e02c583227c290fb93b9a3defb456114223f@buzz.block.builderlab.xyz>
Signed-off-by: klopez4212 <klopez4212@gmail.com>
Co-authored-by: npub12zsjdqx8dud99s9h47xmk9lq93vryf7zjrae8wdrmma52cg5yglseyulst <50a12680c76f1a52c0b7af8dbb17e02c583227c290fb93b9a3defb456114223f@buzz.block.builderlab.xyz>
2026-07-30 07:29:40 -07:00

122 lines
3.8 KiB
Dart

import 'package:buzz/shared/emoji/emoji_data.dart';
import 'package:buzz/shared/emoji/emoji_search.dart';
import 'package:flutter_test/flutter_test.dart';
EmojiEntry _entry(
String id, {
String? name,
List<String> keywords = const [],
String native = '*',
}) {
return EmojiEntry(
id: id,
name: name ?? id,
keywords: keywords,
native: native,
categoryId: 'people',
);
}
void main() {
group('collapseSeparators', () {
test('lowercases and drops shortcode punctuation', () {
expect(collapseSeparators(':Point_Up:'), 'pointup');
expect(collapseSeparators('white-check-mark'), 'whitecheckmark');
expect(collapseSeparators(' thumbs up '), 'thumbsup');
});
});
group('scoreShortcodeMatch', () {
test('ranks exact above prefix above substring above subsequence', () {
final exact = scoreShortcodeMatch('point_up', 'point_up')!;
final prefix = scoreShortcodeMatch('point', 'point_up')!;
final substring = scoreShortcodeMatch('up', 'point_up')!;
final subsequence = scoreShortcodeMatch('pntup', 'point_up')!;
expect(exact.tier, lessThan(prefix.tier));
expect(prefix.tier, lessThan(substring.tier));
expect(substring.tier, lessThan(subsequence.tier));
});
test('crosses the separator emoji-mart cannot', () {
expect(scoreShortcodeMatch('pointup', 'point_up'), isNotNull);
expect(scoreShortcodeMatch('pointup', 'point_up')!.tier, 0);
});
test('returns null for an empty query or no match', () {
expect(scoreShortcodeMatch('', 'point_up'), isNull);
expect(scoreShortcodeMatch(' ', 'point_up'), isNull);
expect(scoreShortcodeMatch('zzzz', 'point_up'), isNull);
});
});
group('searchEmoji', () {
final entries = [
_entry(
'point_up',
name: 'Index Pointing Up',
keywords: ['point', 'hand'],
),
_entry('fire', name: 'Fire', keywords: ['flame', 'hot', 'lit']),
_entry(
'fire_engine',
name: 'Fire Engine',
keywords: ['fire', 'truck', 'emergency'],
),
_entry('firecracker', name: 'Firecracker', keywords: ['dynamite']),
_entry('smile', name: 'Grinning Face With Smiling Eyes'),
];
test('exact shortcode wins over longer prefixes', () {
final results = searchEmoji('fire', entries);
expect(results.first.id, 'fire');
expect(
results.map((entry) => entry.id),
containsAll(['fire', 'fire_engine', 'firecracker']),
);
});
test('shortcode prefix outranks a keyword-only hit', () {
final results = searchEmoji('flame', entries);
expect(results.single.id, 'fire');
});
test('separator-insensitive shortcode search still works', () {
expect(searchEmoji('pointup', entries).first.id, 'point_up');
expect(searchEmoji('fireengine', entries).first.id, 'fire_engine');
});
test('matches on name words when the shortcode does not contain them', () {
expect(searchEmoji('grinning', entries).single.id, 'smile');
});
test('honors the limit and returns empty for a blank query', () {
expect(searchEmoji('fire', entries, limit: 2), hasLength(2));
expect(searchEmoji('fire', entries, limit: 0), isEmpty);
expect(searchEmoji('', entries), isEmpty);
});
});
group('rankByShortcode', () {
test('ranks custom-emoji shortcodes with the desktop tiers', () {
final ranked = rankByShortcode('parrot', const [
'party_parrot',
'parrot',
'pirate_parrot',
], (code) => code);
expect(ranked.first, 'parrot');
expect(ranked, hasLength(3));
});
test('prefers the shorter shortcode within a tier', () {
final ranked = rankByShortcode('par', const [
'parrotparrot',
'park',
], (code) => code);
expect(ranked.first, 'park');
});
});
}