mirror of
https://github.com/block/buzz.git
synced 2026-10-28 13:01:10 +00:00
1329e6e622
Address re-review P1-4, P2-5, P2-6 on the rust-cache fix: - Checker uses rust-cache's raw startsWith (no separator) so sibling paths like <checkout>-cargo are flagged; flip the sibling test. - Clause guard captures nextest list output so list/compile errors abort with their own message instead of 'clause selects no tests'. - Add the checker script to the rust paths filter with a selection row. Signed-off-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz>
40 lines
2.1 KiB
JavaScript
Executable File
40 lines
2.1 KiB
JavaScript
Executable File
#!/usr/bin/env node
|
|
// Fails when Swatinem/rust-cache would mistake dependencies for workspace
|
|
// members. rust-cache keeps target/ outputs only for packages whose
|
|
// manifest_path is outside the workspace root; a dependency whose manifest
|
|
// sits under the root (a registry under the checkout, a vendored source, a
|
|
// path dependency into a nested directory) is treated as workspace code and
|
|
// cleaned away. When that covers every dependency the root-workspace cache
|
|
// saves an empty target/, and the exact-key hit blocks every later save.
|
|
//
|
|
// Usage: cargo metadata --all-features --format-version 1 | node scripts/check-rust-cache-workspace-root.mjs
|
|
import { readFileSync } from "node:fs";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
export function dependenciesUnderWorkspaceRoot(metadata) {
|
|
const members = new Set(metadata.workspace_members);
|
|
// Mirror rust-cache's raw prefix test (src/workspace.ts at e18b4977:
|
|
// `!pkg.manifest_path.startsWith(this.root)`, no separator), so a sibling
|
|
// such as `<checkout>-cargo` counts as inside, exactly as rust-cache sees it.
|
|
const root = metadata.workspace_root;
|
|
return metadata.packages
|
|
.filter((pkg) => !members.has(pkg.id) && pkg.manifest_path.startsWith(root))
|
|
.map((pkg) => `${pkg.name} ${pkg.version} (${pkg.manifest_path})`);
|
|
}
|
|
|
|
if (process.argv[1] === fileURLToPath(import.meta.url)) {
|
|
const metadata = JSON.parse(readFileSync(0, "utf8"));
|
|
const inside = dependenciesUnderWorkspaceRoot(metadata);
|
|
if (inside.length > 0) {
|
|
console.error(
|
|
`${inside.length} non-member package(s) have a manifest under ${metadata.workspace_root}; ` +
|
|
"rust-cache would treat them as workspace code and save an empty target/. " +
|
|
"Keep CARGO_HOME and vendored sources outside the checkout (see bin/hermit.hcl).",
|
|
);
|
|
for (const line of inside.slice(0, 10)) console.error(` ${line}`);
|
|
process.exit(1);
|
|
}
|
|
const outside = metadata.packages.length - metadata.workspace_members.length;
|
|
console.log(`rust-cache workspace root ok: ${outside} dependency package(s) outside ${metadata.workspace_root}`);
|
|
}
|