Files
buzz/mobile/lib/features/channels/members_sheet.dart
Logan Johnson 82656ffea0 fix(mobile): standardize public-key identity display on npub (#7493)
🤖

## Summary

In the mobile app, anyone who hasn't set a display name shows up as a
raw 64-character hex key (e.g. `3a5d4f9c…`) — unreadable, and
unrecognizable as the same identity across screens. Profile and Settings
also let you copy that raw hex. Nostr public keys have a standard
readable form — `npub1…`, the same encoding other Nostr apps and our
desktop app already display. This PR makes every mobile identity surface
render npub instead:

- **Unnamed people everywhere** — message and thread authors, reactions,
typing indicators, member lists, channel details, DM headers and tiles,
inbox, search, forum cards, Pulse notes and reply context, mention
suggestions, and invite rows — now show a compact npub label: first 8 +
last 4 characters of the full npub joined by an ellipsis
(`npub1abcd…wxyz`), the same truncation desktop uses. Previously these
showed truncated raw hex.
- **DM fallback avatars and blank names** — 1:1 DM tiles and headers key
their fallback avatar to the same non-self counterpart the label names,
including self-first participant order; a self-DM keeps its
hex-key-derived initial. Blank or whitespace-only display names fall
back to the compact npub instead of rendering empty, while nonblank
authored names render verbatim (padding included).
- **Profile sheet → "Copy public key"** now copies the full canonical
npub — never raw hex. When the identity string isn't a valid public key,
the copy tile is disabled, so a malformed key never reaches the
clipboard.
- **Settings → Identity (pubkey)** displays and copies the full npub; an
invalid identity reads "Identity unavailable" with copy disabled.
- **Invalid identities never leak truncated raw hex** into the UI
anywhere — they render a neutral "Unknown identity" label.
- **Unchanged on purpose:** display names and verified handles (NIP-05 —
the `name@domain` badge) still render as before. Unnamed avatars keep
distinct per-key initials, derived from the underlying hex key rather
than the npub — otherwise every unnamed key would render the same "N"
initial. Event IDs are not public keys, so they keep their hex
truncation (in Pulse's "Replying to", the parent author shows npub while
an event-id fallback still shows hex). The nevent share link, private
keys, and internal hex storage are untouched. Inputs that accept a key
(invite/member entry) accept both hex and npub and keep working in hex
internally.

### Related issue

N/A. Searched open issues/PRs for npub identity display on mobile —
closest related: none found. Desktop's parallel npub standardization
lives in the stacked desktop PRs (#7488 foundation, #7489 controls,
#7495 display surfaces); this is the independent mobile slice (based
directly on `main`, not on those branches).

### Testing

At exact head `5a620e420a1fd57d9d8011ac26434eed32fcf765` (base: `main`
`44316ff72`; 40 files, +1,345/−154):

- Full mobile suite: 2,098 tests passing (`cd mobile && flutter test`);
`flutter analyze` clean; `dart format --set-exit-if-changed .` clean —
the same checks CI runs.
- Widget/unit coverage at production seams: compact labels and hex-keyed
avatar initials for DM headers/tiles, member rows, mention suggestions,
and Pulse reply context; DM fallback avatars keyed to the labeled
counterpart (self-first order and self-DMs); blank/whitespace
display-name npub fallback with nonblank authored labels verbatim,
including the Activity inbox sender and profile-sheet heading (each with
its own empty/whitespace production-seam regression); full-npub copy and
disabled-copy semantics in profile and settings; invalid-key
suppression; and hex↔npub input round-trips.

Verified via unit and widget tests — no device/simulator validation is
claimed.

### Task provenance

Buzz channel: `1f0e4a3d-7e01-4efe-bb16-843b357f85c9`

Task:
buzz://message?channel=1f0e4a3d-7e01-4efe-bb16-843b357f85c9&id=86b34eb4bd84a1472419e9af22636c011c0fe273e3c196f967d7a36996e149b6

---------

Signed-off-by: Logan Johnson <loganj@squareup.com>
Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
2026-09-09 14:08:24 -04:00

469 lines
16 KiB
Dart

import 'package:flutter/material.dart';
import 'package:flutter_hooks/flutter_hooks.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:lucide_icons_flutter/lucide_icons.dart';
import '../../shared/theme/theme.dart';
import '../../shared/widgets/avatar_image.dart';
import '../../shared/widgets/buzz_loading_indicator.dart';
import '../../shared/widgets/modal_presentation.dart';
import '../../shared/profile/user_cache_provider.dart';
import '../../shared/profile/user_profile.dart';
import '../profile/user_status.dart';
import '../profile/user_status_cache_provider.dart';
import 'agent_activity/agent_activity_sheet.dart';
import 'agent_activity/working_bots_provider.dart';
import 'channel.dart';
import 'channel_management_provider.dart';
class MembersSheet extends HookConsumerWidget {
final Channel channel;
final String? currentPubkey;
const MembersSheet({
super.key,
required this.channel,
required this.currentPubkey,
});
@override
Widget build(BuildContext context, WidgetRef ref) {
final membersAsync = ref.watch(channelMembersProvider(channel.id));
final allMembers = membersAsync.asData?.value ?? const <ChannelMember>[];
final people = allMembers.where((member) => !member.isBot).toList();
final bots = allMembers.where((member) => member.isBot).toList();
final userCache = ref.watch(userCacheProvider);
final typingBotPubkeys = ref.watch(workingBotPubkeysProvider(channel.id));
final statusCache = ref.watch(userStatusCacheProvider);
final bottomClearance = Grid.md + MediaQuery.viewPaddingOf(context).bottom;
// Determine if the current user can manage members.
final currentMember = allMembers.cast<ChannelMember?>().firstWhere(
(m) => m!.pubkey.toLowerCase() == currentPubkey?.toLowerCase(),
orElse: () => null,
);
final canManage =
currentMember != null &&
currentMember.isElevated &&
!channel.isArchived;
void openActivity(ChannelMember bot) {
final navigator = Navigator.of(context);
navigator.pop();
WidgetsBinding.instance.addPostFrameCallback((_) {
if (!navigator.mounted) return;
showBuzzModalBottomSheet<void>(
context: navigator.context,
isScrollControlled: true,
showDragHandle: true,
builder: (_) => AgentActivitySheet(
channelId: channel.id,
agentPubkey: bot.pubkey,
),
);
});
}
// Preload profiles for all members so avatars appear.
useEffect(() {
if (allMembers.isNotEmpty) {
ref
.read(userCacheProvider.notifier)
.preload(allMembers.map((m) => m.pubkey).toList());
// Track user statuses for people (not bots).
final peoplePubkeys = allMembers
.where((m) => !m.isBot)
.map((m) => m.pubkey)
.toList();
if (peoplePubkeys.isNotEmpty) {
ref.read(userStatusCacheProvider.notifier).track(peoplePubkeys);
}
}
return null;
}, [allMembers.length]);
return Padding(
key: const ValueKey('members-sheet-content-padding'),
padding: EdgeInsets.fromLTRB(Grid.gutter, 0, Grid.gutter, 0),
child: ConstrainedBox(
key: const ValueKey('members-sheet-viewport'),
constraints: BoxConstraints(maxHeight: 400 + bottomClearance),
child: membersAsync.when(
data: (_) => ListView(
key: const ValueKey('members-sheet-list'),
shrinkWrap: true,
padding: EdgeInsets.only(top: Grid.xxs, bottom: bottomClearance),
children: [
if (people.isNotEmpty) ...[
_SectionLabel(label: 'People · ${people.length}'),
for (final member in people)
_MemberTile(
member: member,
currentPubkey: currentPubkey,
profile: userCache[member.pubkey.toLowerCase()],
canManage: canManage,
isSelf:
member.pubkey.toLowerCase() ==
currentPubkey?.toLowerCase(),
channelId: channel.id,
userStatus: statusCache[member.pubkey.toLowerCase()],
),
],
if (bots.isNotEmpty) ...[
const SizedBox(height: Grid.xxs),
_SectionLabel(label: 'Agents · ${bots.length}'),
for (final bot in bots)
_MemberTile(
member: bot,
currentPubkey: currentPubkey,
profile: userCache[bot.pubkey.toLowerCase()],
canManage: canManage,
isSelf: false,
channelId: channel.id,
isWorking: typingBotPubkeys.contains(
bot.pubkey.toLowerCase(),
),
onViewActivity: () => openActivity(bot),
onActivityTap:
typingBotPubkeys.contains(bot.pubkey.toLowerCase())
? () => openActivity(bot)
: null,
),
],
if (people.isEmpty && bots.isEmpty)
Center(
child: Text(
'No members found.',
style: context.textTheme.bodySmall?.copyWith(
color: context.colors.onSurfaceVariant,
),
),
),
],
),
loading: () => const Center(
child: BuzzLoadingIndicator(
size: 44,
semanticLabel: 'Loading members',
),
),
error: (error, _) => Center(
child: Text(
error.toString(),
style: context.textTheme.bodySmall?.copyWith(
color: context.colors.error,
),
),
),
),
),
);
}
}
class _SectionLabel extends StatelessWidget {
final String label;
const _SectionLabel({required this.label});
@override
Widget build(BuildContext context) {
return Padding(
padding: const EdgeInsets.only(top: Grid.half, bottom: Grid.half),
child: Text(
label,
style: context.textTheme.labelMedium?.copyWith(
color: context.colors.onSurfaceVariant,
fontWeight: FontWeight.w600,
),
),
);
}
}
const _changeableRoles = ['admin', 'member', 'guest'];
String _roleLabel(String role) {
if (role == 'bot') return 'Agent';
if (role.isEmpty) return 'Member';
return '${role[0].toUpperCase()}${role.substring(1)}';
}
class _MemberTile extends ConsumerWidget {
final ChannelMember member;
final String? currentPubkey;
final UserProfile? profile;
final bool canManage;
final bool isSelf;
final String channelId;
final bool isWorking;
final VoidCallback? onActivityTap;
final VoidCallback? onViewActivity;
final UserStatus? userStatus;
const _MemberTile({
required this.member,
required this.currentPubkey,
required this.profile,
required this.canManage,
required this.isSelf,
required this.channelId,
this.isWorking = false,
this.onActivityTap,
this.onViewActivity,
this.userStatus,
});
@override
Widget build(BuildContext context, WidgetRef ref) {
final label = isSelf
? 'You'
: (profile?.displayName?.trim().isNotEmpty == true
? profile!.displayName!.trim()
: member.labelFor(currentPubkey));
// Named members initial from their name; unnamed ones stay keyed to the
// hex public key so the compact-npub label doesn't render `N` for all.
final hasName = profile?.displayName?.trim().isNotEmpty == true;
final initial = isSelf || hasName
? label[0].toUpperCase()
: (member.pubkey.isNotEmpty ? member.pubkey[0].toUpperCase() : '?');
final showManagementActions = canManage && !isSelf && !member.isOwner;
final showMenu = showManagementActions || onViewActivity != null;
return ListTile(
contentPadding: EdgeInsets.zero,
leading: _MemberAvatar(
avatarUrl: profile?.avatarUrl,
initial: initial,
isAgent: member.isBot || profile?.isAgent == true,
),
title: Text(label),
subtitle: isWorking
? Row(
mainAxisSize: MainAxisSize.min,
children: [
BuzzLoadingIndicator(
size: 14,
color: context.appColors.success,
semanticLabel: 'Agent working',
),
const SizedBox(width: Grid.half),
Text(
'Working\u2026',
style: context.textTheme.bodySmall?.copyWith(
color: context.appColors.success,
fontWeight: FontWeight.w600,
),
),
],
)
: userStatus != null && !userStatus!.isEmpty
? Text(
'${userStatus!.emoji.isNotEmpty ? '${userStatus!.emoji} ' : ''}${userStatus!.text}',
style: context.textTheme.bodySmall?.copyWith(
color: context.colors.onSurfaceVariant,
),
maxLines: 1,
overflow: TextOverflow.ellipsis,
)
: Text(
_roleLabel(member.role),
style: context.textTheme.bodySmall?.copyWith(
color: context.colors.onSurfaceVariant,
),
),
trailing: showMenu
? IconButton(
icon: const Icon(LucideIcons.ellipsis, size: 18),
onPressed: () => _showMemberActions(
context,
ref,
showManagementActions: showManagementActions,
),
visualDensity: VisualDensity.compact,
)
: null,
onTap: onActivityTap,
);
}
void _showMemberActions(
BuildContext context,
WidgetRef ref, {
required bool showManagementActions,
}) {
final label = isSelf
? 'You'
: (profile?.displayName?.trim().isNotEmpty == true
? profile!.displayName!.trim()
: member.labelFor(currentPubkey));
final canChangeRole = showManagementActions && !member.isBot;
showBuzzModalBottomSheet<void>(
context: context,
title: label,
showDragHandle: true,
builder: (sheetContext) => SafeArea(
child: Column(
mainAxisSize: MainAxisSize.min,
crossAxisAlignment: CrossAxisAlignment.start,
children: [
if (onViewActivity != null)
ListTile(
leading: Icon(
LucideIcons.activity,
size: 18,
color: context.colors.primary,
),
title: const Text('View activity'),
onTap: () {
Navigator.of(sheetContext).pop();
WidgetsBinding.instance.addPostFrameCallback((_) {
onViewActivity?.call();
});
},
),
if (showManagementActions) ...[
if (canChangeRole) ...[
const SizedBox(height: Grid.xxs),
_RoleSelector(
selectedRole: member.role,
onChanged: (role) async {
Navigator.of(sheetContext).pop();
await ref
.read(channelActionsProvider)
.changeMemberRole(
channelId: channelId,
pubkey: member.pubkey,
role: role,
);
},
),
const SizedBox(height: Grid.xs),
],
ListTile(
leading: Icon(
LucideIcons.userMinus,
size: 18,
color: context.colors.error,
),
title: Text(
'Remove from channel',
style: TextStyle(color: context.colors.error),
),
onTap: () async {
Navigator.of(context).pop();
final confirmed = await showBuzzDialog<bool>(
context: context,
builder: (context) => AlertDialog(
title: const Text('Remove member'),
content: Text('Remove $label from this channel?'),
actions: [
TextButton(
onPressed: () => Navigator.of(context).pop(false),
child: const Text('Cancel'),
),
TextButton(
onPressed: () => Navigator.of(context).pop(true),
child: Text(
'Remove',
style: TextStyle(color: context.colors.error),
),
),
],
),
);
if (confirmed == true) {
await ref
.read(channelActionsProvider)
.removeMember(
channelId: channelId,
pubkey: member.pubkey,
);
}
},
),
],
const SizedBox(height: Grid.xxs),
],
),
),
);
}
}
class _RoleSelector extends StatelessWidget {
final String selectedRole;
final ValueChanged<String> onChanged;
const _RoleSelector({required this.selectedRole, required this.onChanged});
@override
Widget build(BuildContext context) {
final hasKnownRole = _changeableRoles.contains(selectedRole);
return Padding(
padding: const EdgeInsets.symmetric(horizontal: Grid.gutter),
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Text(
'Role',
style: context.textTheme.labelMedium?.copyWith(
color: context.colors.onSurfaceVariant,
),
),
const SizedBox(height: Grid.xxs),
SizedBox(
width: double.infinity,
child: SegmentedButton<String>(
segments: [
for (final role in _changeableRoles)
ButtonSegment<String>(
value: role,
label: Text(_roleLabel(role)),
),
],
selected: hasKnownRole ? {selectedRole} : const <String>{},
emptySelectionAllowed: !hasKnownRole,
showSelectedIcon: false,
style: ButtonStyle(
visualDensity: VisualDensity.compact,
tapTargetSize: MaterialTapTargetSize.shrinkWrap,
textStyle: WidgetStatePropertyAll(context.textTheme.labelSmall),
),
onSelectionChanged: (roles) {
if (roles.isEmpty) return;
final role = roles.single;
if (role == selectedRole) return;
onChanged(role);
},
),
),
],
),
);
}
}
class _MemberAvatar extends StatelessWidget {
final String? avatarUrl;
final String initial;
final bool isAgent;
const _MemberAvatar({
required this.avatarUrl,
required this.initial,
required this.isAgent,
});
@override
Widget build(BuildContext context) {
return AvatarImage(
imageUrl: avatarUrl,
radius: 20,
fallback: Text(initial),
isAgent: isAgent,
);
}
}